Differential D12327

[move-only] Move CAddrMan function definitions to cpp
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:54.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9e405b4d2a3b: [move-only] Move CAddrMan function definitions to cpp

Summary

In preparation for introducing the pimpl pattern to addrman, move all function bodies out of the header file.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/5faa7dd6d871eac1a0ec5c4a93f2ad7577781a56

Depends on D12326.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:54

Fabien requested review of this revision.Oct 20 2022, 12:54

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:54

Fabien added a child revision: D12328: [move-only] Match ordering of CAddrMan declarations and definitions.Oct 20 2022, 12:55

Harbormaster completed remote builds in B20634: Diff 35880.Oct 20 2022, 13:06

PiRK accepted this revision.Oct 20 2022, 13:48

This revision is now accepted and ready to land.Oct 20 2022, 13:48

Closed by commit rABC9e405b4d2a3b: [move-only] Move CAddrMan function definitions to cpp (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9e405b4d2a3b: [move-only] Move CAddrMan function definitions to cpp.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

121 lines

addrman.cpp

129 lines

Diff 35908

View Options

src/addrman.h