Page MenuHomePhabricator

log: improve addrman logging
ClosedPublic

Authored by Fabien on Oct 20 2022, 13:13.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1136c0b57542: log: improve addrman logging
Summary
The addrman helper functions GetNewBucket() and GetTriedBucket()

    log into the wrong category (BCLog::NET instead of BCLog::ADDRMAN)
    log too unspecifically - especially GetTriedBucket() gets called from many different places (e.g. Check_(), Serialize()), it seems sufficient to me logging these when moving an address from new to tried. Running a node with -checkaddrman=1and net logging currently results in a lot of repetitive log entries.

This PR moves these log entries to Add_() and Good_() and also adds logging for Select_() (allowing statistics about New/Tried success probabilities), GetAddr_(), ClearNew() and MakeTried().

Backport of core#22839.

Depends on D12338.

Test Plan
ninja all check-all