Page MenuHomePhabricator
Differential D13121

mempool: Evict transactions by modified feerate
ClosedPublic
Actions

Authored by Fabien on Feb 10 2023, 11:43.

Details

Reviewers
PiRK
sdulfari
Group Reviewers
Restricted Project
Commits
rABC874473cdf5fb: mempool: Evict transactions by modified feerate
Summary
When trimming the mempool, remove transactions by lowest (modified) feerate rather than feerate-with-descendants.

Port of bchn#1080.

Depends on D13116 and D13120.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Feb 10 2023, 11:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2023, 11:43
Fabien requested review of this revision.Feb 10 2023, 11:43
teamcity edited the summary of this revision. (Show Details)Feb 10 2023, 11:43
Harbormaster completed remote builds in B21974: Diff 37873.Feb 10 2023, 11:56
Fabien added a child revision: D13122: miner: Misc small refactor and renaming.Feb 10 2023, 13:57
PiRK accepted this revision.Feb 14 2023, 09:34
This revision is now accepted and ready to land.Feb 14 2023, 09:34
sdulfari requested changes to this revision.Feb 14 2023, 21:40
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/test/mempool_tests.cpp
681–683

This special case ceil usage gives a bad smell. Could we do away with this change by just picking a more workable fee value?

src/txmempool.cpp
1278–1279

Easier to read

This revision now requires changes to proceed.Feb 14 2023, 21:40
Fabien added inline comments.Feb 15 2023, 09:13
src/txmempool.cpp
1278–1279

That won't work unfortunately, because the cast below expects a forward iterator

1293

here the cast requires a forward iterator, and converting the iterator makes the code less readable overall

Fabien updated this revision to Diff 37896.Feb 15 2023, 09:15

Pick a better value for the test to avoid the need for std::ceil

Harbormaster completed remote builds in B21990: Diff 37896.Feb 15 2023, 09:40
Fabien updated this revision to Diff 37902.Feb 15 2023, 16:42

Rebase

sdulfari accepted this revision.Feb 15 2023, 17:08
sdulfari added inline comments.
src/test/mempool_tests.cpp
17 ↗(On Diff #37902)

cleanup

This revision is now accepted and ready to land.Feb 15 2023, 17:08
Harbormaster completed remote builds in B21993: Diff 37902.Feb 15 2023, 17:11
Closed by commit rABC874473cdf5fb: mempool: Evict transactions by modified feerate (authored by jtoomim, committed by Fabien). · Explain WhyFeb 15 2023, 18:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC874473cdf5fb: mempool: Evict transactions by modified feerate.

Revision Contents
Changeset List

PathSize
src/
test/
176 lines
55 lines
30 lines

Diff 37873

View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...