Details
Details
- Reviewers
PiRK sdulfari - Group Reviewers
Restricted Project - Commits
- rABC874473cdf5fb: mempool: Evict transactions by modified feerate
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- MR1080
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21990 Build 43615: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 43614: arc lint + arc unit
Event Timeline
| src/test/mempool_tests.cpp | ||
|---|---|---|
| 681–683 ↗ | (On Diff #37873) | This special case ceil usage gives a bad smell. Could we do away with this change by just picking a more workable fee value? |
| src/txmempool.cpp | ||
| 1278–1279 ↗ | (On Diff #37873) | Easier to read |
| src/txmempool.cpp | ||
|---|---|---|
| 1278–1279 ↗ | (On Diff #37873) | That won't work unfortunately, because the cast below expects a forward iterator |
| 1293 ↗ | (On Diff #37873) | here the cast requires a forward iterator, and converting the iterator makes the code less readable overall |
| src/test/mempool_tests.cpp | ||
|---|---|---|
| 17 ↗ | (On Diff #37902) | cleanup |