Page MenuHomePhabricator

Bump automatic replay protection to May 2019 upgrade
ClosedPublic

Authored by Mengerian on Jul 30 2018, 03:04.

Details

Summary

This returns main chain to ForkID of 0 after the Nov 2018
upgrade, and implements automatic replay protection for
the May 2019 upgrade.

For reference see last HF:
https://reviews.bitcoinabc.org/D1199

Test Plan

Replay protection is covered by unit tests, however
it is very important to manually double check that the timestamp
for activation is set correctly.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
May-2019-HF
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2995
Build 4084: Bitcoin ABC Buildbot (legacy)
Build 4083: arc lint + arc unit

Event Timeline

schancel requested changes to this revision.Aug 3 2018, 16:36
schancel added inline comments.
src/chainparams.cpp
135

Please put the exact time:

Wed May 15 12:00:00 2019 UTC

👍

This revision now requires changes to proceed.Aug 3 2018, 16:36

More specific time in comment

jasonbcox requested changes to this revision.Aug 5 2018, 16:29
jasonbcox added inline comments.
src/validation.cpp
600 ↗(On Diff #4495)

There is zero documentation of this arg anywhere. Can you add comments here to describe the intended behavior?

This revision now requires changes to proceed.Aug 5 2018, 16:29

Add comment describing intended behavior of -replayprotectionactivationtime

Fix whitespace, and more detailed date in one more place

This revision is now accepted and ready to land.Aug 8 2018, 20:11
This revision was automatically updated to reflect the committed changes.