This ensure the state within avalanche is consistent with the outside world.
Depends on D2142
Adapted test cases.
Only poll blocks worth polling.
Maybe you could also add a test to check that you won't poll an invalid block
New blocks are now considered accepted
Please remove the "now" from the comment
It is accepted
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
nit, remove "are"
I think it's accepted instead of rejected ?
Having a really hard time reading this variable name. Is it supposed to be vraccepter?
I think we should stick to zero-indexing to prevent future errors. I think AVALANCHE_FINALIZATION_SCORE - 1 reads better.
The rest of these changes look good.
The index right now indicate how many confirmations were made. Zero based index represent nothing, so I fail to see haw it makes the code more meaningful in any way.
Fix vairable name
Don't you want to add a test to ensure that invalid blocks are not polled ?
vraccpeted => vraccepted
Add a check for invalid blocks
I guess that makes sense.