- Remove blanket std import from wallet.cpp
- Add braces around control flow statements
- Remove useless scopes.
- Use nullptr instead of NULL
- Various other small changes.
Details
Details
- Reviewers
freetrader sickpig kyuupichan awemany - Group Reviewers
Restricted Project - Commits
- rSTAGING81c68f1e8506: A ton of style change to wallet.cpp
rABC81c68f1e8506: A ton of style change to wallet.cpp
make check ../qa/pull-tester/rpc-tests.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- walletstd
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 464 Build 464: arc lint + arc unit
Event Timeline
Comment Actions
Didn't see any semantic change, but due to amount of changes it would be good if another person went over it carefully as well to see if I missed any.
The scope removals and transformations of if..else's look ok to me - a good improvement.
There are still C comments ( /* ... */ ) lurking, and comments which have not been capitalized.
But so far this looks good.
| src/wallet/wallet.cpp | ||
|---|---|---|
| 1444 ↗ | (On Diff #750) | Generally you left blank lines after loops, but not this one. |
| 4034 ↗ | (On Diff #750) | Why transform this one into an 'if' when the following ones remain 'else if' ? |
Comment Actions
I asked for others to review (repeating this request on Slack on Jul 10).
It seems no-one is available.
Ran the tests, they're fine, so I'm accepting this one.