Page MenuHomePhabricator

A ton of style change to wallet.cpp
ClosedPublic

Authored by deadalnix on Jul 7 2017, 14:44.

Details

Summary
  • Remove blanket std import from wallet.cpp
  • Add braces around control flow statements
  • Remove useless scopes.
  • Use nullptr instead of NULL
  • Various other small changes.
Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletstd
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 464
Build 464: arc lint + arc unit

Event Timeline

Didn't see any semantic change, but due to amount of changes it would be good if another person went over it carefully as well to see if I missed any.
The scope removals and transformations of if..else's look ok to me - a good improvement.

There are still C comments ( /* ... */ ) lurking, and comments which have not been capitalized.
But so far this looks good.

src/wallet/wallet.cpp
1444 ↗(On Diff #750)

Generally you left blank lines after loops, but not this one.

4034 ↗(On Diff #750)

Why transform this one into an 'if' when the following ones remain 'else if' ?

I asked for others to review (repeating this request on Slack on Jul 10).
It seems no-one is available.

Ran the tests, they're fine, so I'm accepting this one.

This revision is now accepted and ready to land.Jul 12 2017, 11:12
This revision was automatically updated to reflect the committed changes.