Page MenuHomePhabricator
Differential D3078

Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn
ClosedPublic
Actions

Authored by markblundeberg on May 20 2019, 19:23.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING27bc83a0e6ac: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn
rABC27bc83a0e6ac: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn
Summary

PR10503 backport https://github.com/bitcoin/bitcoin/pull/10503/files
d9bec888f Use REJECT_DUPLICATE for already known and conflicted txn (Pieter Wuille)

(nb one change was already done in D1734)

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 20 2019, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2019, 19:23
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 20 2019, 19:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)May 20 2019, 19:26
markblundeberg edited the summary of this revision. (Show Details)May 20 2019, 19:28
teamcity added a comment.May 20 2019, 19:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5909: Diff 8751.May 20 2019, 19:37
markblundeberg added a child revision: D3079: Merge #11742: rpc: Add testmempoolaccept.May 21 2019, 01:34
deadalnix accepted this revision.May 21 2019, 23:49

This is rather disconcerting that this comes with no tests.

This revision is now accepted and ready to land.May 21 2019, 23:49
Closed by commit rABC27bc83a0e6ac: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 22 2019, 19:31
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC27bc83a0e6ac: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING27bc83a0e6ac: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn.Sep 18 2019, 23:41

Revision Contents
Changeset List

PathSize
src/
4 lines
5 lines

Diff 8805

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...