Page MenuHomePhabricator

re-fix feature_cltv.py
ClosedPublic

Authored by markblundeberg on May 22 2019, 23:59.

Details

Summary

The core version of this test relied on nonpush opcodes in scriptsig
and thus got heavily rewritten in D2120 in order to comply with ABC's
consensus sigpushonly rule. This cleans up / fixes the test.

  • Make it actually validate -1 CLTV before activation, like it used to.
  • Change confusing name spendtx to fundtx. fundtx is always valid, as it does not execute CLTV.
  • Integrate creation of the actual spending tx at the same time (DRY).
  • Restore code that actually uses promiscuousmempoolflags; fix comment that inaccurately refers to promiscuousmempoolflags .
  • Simplify the ending.
Test Plan

test_runner.py feature_cltv.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_cltv_test
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5948
Build 9956: Bitcoin ABC Buildbot (legacy)
Build 9955: arc lint + arc unit

Event Timeline

remove nonbreaking space from comment (U+00A0)

Thanks, this is much better !

This revision is now accepted and ready to land.May 23 2019, 08:26