Page MenuHomePhabricator
Differential D3095

re-fix feature_cltv.py
ClosedPublic
Actions

Authored by markblundeberg on May 22 2019, 23:59.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7af708e9f744: re-fix feature_cltv.py
rABC7af708e9f744: re-fix feature_cltv.py
Summary

The core version of this test relied on nonpush opcodes in scriptsig
and thus got heavily rewritten in D2120 in order to comply with ABC's
consensus sigpushonly rule. This cleans up / fixes the test.

  • Make it actually validate -1 CLTV before activation, like it used to.
  • Change confusing name spendtx to fundtx. fundtx is always valid, as it does not execute CLTV.
  • Integrate creation of the actual spending tx at the same time (DRY).
  • Restore code that actually uses promiscuousmempoolflags; fix comment that inaccurately refers to promiscuousmempoolflags .
  • Simplify the ending.
Test Plan

test_runner.py feature_cltv.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_cltv_test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5948
Build 9956: Bitcoin ABC Buildbot (legacy)
Build 9955: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 22 2019, 23:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2019, 23:59
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 23 2019, 00:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 23 2019, 00:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5946: Diff 8814.May 23 2019, 00:14
markblundeberg added a child revision: D3080: Merge #13527: policy: Remove promiscuousmempoolflags.May 23 2019, 00:21
markblundeberg updated this revision to Diff 8816.May 23 2019, 00:25

remove nonbreaking space from comment (U+00A0)

teamcity added a comment.May 23 2019, 00:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 23 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5948: Diff 8816.May 23 2019, 00:40
Fabien accepted this revision.May 23 2019, 08:26

Thanks, this is much better !

This revision is now accepted and ready to land.May 23 2019, 08:26
Closed by commit rABC7af708e9f744: re-fix feature_cltv.py (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 23 2019, 14:15
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC7af708e9f744: re-fix feature_cltv.py.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING7af708e9f744: re-fix feature_cltv.py.Sep 18 2019, 23:41

Revision Contents
Changeset List

PathSize
test/
functional/
141 lines

Diff 8816

View Options

test/functional/feature_cltv.py

Loading...