Page MenuHomePhabricator

Add help text for uahfstarttime command line option
ClosedPublic

Authored by freetrader on Jul 13 2017, 14:15.

Details

Summary

Adds a help text that also shows default value.

Test Plan

make check

Run 'src/bitcoind --help' and check uahfstartttime description.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 13 2017, 14:15
dagurval requested changes to this revision.Jul 13 2017, 16:44
dagurval added a subscriber: dagurval.

It's missing a note about setting start time to 0, if implemented.

From spec:

NOTE 1: Configuring a "activation time" value of zero (0) shall disable any UAHF hard fork special rules (see REQ-DISABLE)

This revision now requires changes to proceed.Jul 13 2017, 16:44

My understanding is that REQ-DISABLE is not implemented at this stage.

T54 is open.

As long as there is a task tracking this, I think we are good here.

@freetrader you should request review in these cases, because that's unclear that further review is required here.

This revision is now accepted and ready to land.Jul 13 2017, 18:24
This revision was automatically updated to reflect the committed changes.