Remove unused DoWarning function
ClosedPublic
Actions

Authored by markblundeberg on Jun 6 2019, 04:42.

Details

Reviewers

nakihito
jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGce4e304800ac: Remove unused DoWarning function
rABCce4e304800ac: Remove unused DoWarning function

Summary

Since BIP9 code has been removed in D1539 and now D3181 removed the other
usage, this static function is now unused and generates compiler warning.

Depends on D3181.

Test Plan

compile bitcoind

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6180
Build 10408: Bitcoin ABC Buildbot (legacy)
Build 10407: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 6 2019, 04:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 04:42

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6180: Diff 9186.Jun 6 2019, 04:52

Fabien accepted this revision.Jun 6 2019, 07:42

This revision is now accepted and ready to land.Jun 6 2019, 07:42

nakihito accepted this revision.Jun 6 2019, 17:39

Closed by commit rABCce4e304800ac: Remove unused DoWarning function (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 13 2019, 01:42

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCce4e304800ac: Remove unused DoWarning function.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGce4e304800ac: Remove unused DoWarning function.Sep 19 2019, 00:14

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

9 lines

Diff 9186

View Options

Remove unused DoWarning functionClosedPublicActions