Use nullptr consistently
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2017, 13:18.

Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING92b1a124b7cb: Use nullptr consistently
rABC92b1a124b7cb: Use nullptr consistently

Summary

As per title.

Test Plan

Compiled and ran test suite.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nullptr

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 509
Build 509: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2017, 13:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2017, 13:18

freetrader mentioned this in D325: Use nullptr instead of NULL in net_processing.cpp.Jul 14 2017, 13:34

This also passed tests on my end.

This revision is now accepted and ready to land.Jul 14 2017, 15:10

sickpig accepted this revision.Jul 14 2017, 15:13

Closed by commit rABC92b1a124b7cb: Use nullptr consistently (authored by deadalnix, committed by deadalnix). · Explain WhyJul 14 2017, 15:13

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

4 lines

4 lines

4 lines

4 lines

2 lines

bench/

2 lines

12 lines

2 lines

50 lines

12 lines

2 lines

2 lines

8 lines

2 lines

2 lines

consensus/

4 lines

4 lines

2 lines

10 lines

16 lines

36 lines

12 lines

6 lines

49 lines

76 lines

2 lines

4 lines

14 lines

2 lines

14 lines

qt/

2 lines

14 lines

2 lines

4 lines

34 lines

2 lines

paymentrequestplus.cpp

10 lines

paymentserver.h

12 lines

paymentserver.cpp

8 lines

receiverequestdialog.cpp

2 lines

recentrequeststablemodel.cpp

2 lines

rpcconsole.h

10 lines

rpcconsole.cpp

6 lines

test/

paymentservertests.cpp

4 lines

transactionrecord.cpp

2 lines

transactionview.cpp

2 lines

walletmodel.h

7 lines

walletview.cpp

5 lines

winshutdownmonitor.cpp

2 lines

random.cpp

8 lines

rest.cpp

8 lines

rpc/

4 lines

6 lines

4 lines

2 lines

2 lines

6 lines

script/

bitcoinconsensus.cpp

6 lines

standard.cpp

2 lines

streams.h

20 lines

support/

2 lines

4 lines

2 lines

2 lines

test/

6 lines

2 lines

12 lines

15 lines

4 lines

2 lines

txvalidationcache_tests.cpp

4 lines

util_tests.cpp

40 lines

versionbits_tests.cpp

18 lines

10 lines

8 lines

2 lines

33 lines

6 lines

12 lines

2 lines

13 lines

220 lines

2 lines

8 lines

wallet/

db.h

25 lines

db.cpp

47 lines

rpcwallet.cpp

6 lines

test/

crypto_tests.cpp

8 lines

wallet_test_fixture.cpp

2 lines

wallet.h

18 lines

walletdb.cpp

4 lines

Diff 814

View Options

src/addrman.h

View Options

src/addrman.cpp

View Options

src/arith_uint256.h

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/bench/bench.cpp

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoind.cpp

View Options

src/chain.h

View Options

src/chain.cpp

View Options

src/chainparamsbase.cpp

View Options

src/checkpoints.cpp

View Options

src/checkqueue.h

View Options

src/coins.h

View Options

src/coins.cpp

View Options

src/consensus/merkle.h

View Options

src/consensus/merkle.cpp

View Options

src/dbwrapper.h

View Options

src/dbwrapper.cpp

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/key.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/netaddress.h

View Options

src/netaddress.cpp

View Options

src/netbase.cpp

View Options

src/prevector.h

View Options

src/pubkey.cpp

View Options

src/qt/addressbookpage.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/openuridialog.cpp

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentserver.h

View Options

src/qt/paymentserver.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/recentrequeststablemodel.cpp

View Options

src/qt/rpcconsole.h

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.h

View Options

src/qt/walletview.cpp

View Options

src/qt/winshutdownmonitor.cpp

View Options

src/random.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/server.h

View Options

src/rpc/server.cpp

View Options

src/script/bitcoinconsensus.cpp

View Options

src/script/standard.cpp

View Options

src/streams.h

View Options

src/support/events.h

View Options

src/support/lockedpool.cpp

View Options

src/sync.h

View Options

src/sync.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/raii_event_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/test_bitcoin.h

View Options

src/test/test_bitcoin.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/versionbits_tests.cpp

View Options

src/torcontrol.cpp

View Options

src/txmempool.h

View Options

src/util.h

View Options

src/util.cpp

View Options

src/utilstrencodings.h

View Options

src/utilstrencodings.cpp

View Options

src/utiltime.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/versionbits.h

View Options

src/versionbits.cpp

View Options

src/wallet/db.h

View Options

src/wallet/db.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/crypto_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/wallet.h

View Options

Use nullptr consistentlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 814

src/addrman.h

src/addrman.cpp

src/arith_uint256.h

src/base58.h

src/base58.cpp

src/bench/bench.cpp

src/bitcoin-cli.cpp

src/bitcoind.cpp

src/chain.h

src/chain.cpp

src/chainparamsbase.cpp

src/checkpoints.cpp

src/checkqueue.h

src/coins.h

src/coins.cpp

src/consensus/merkle.h

src/consensus/merkle.cpp

src/dbwrapper.h

src/dbwrapper.cpp

src/httpserver.cpp

src/init.cpp

src/key.cpp

src/net.h

src/net.cpp

src/net_processing.cpp

src/netaddress.h

src/netaddress.cpp

src/netbase.cpp

src/prevector.h

src/pubkey.cpp

src/qt/addressbookpage.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/guiutil.cpp

src/qt/openuridialog.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.h

src/qt/paymentserver.cpp

src/qt/receiverequestdialog.cpp

src/qt/recentrequeststablemodel.cpp

src/qt/rpcconsole.h

src/qt/rpcconsole.cpp

src/qt/test/paymentservertests.cpp

src/qt/transactionrecord.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.h

src/qt/walletview.cpp

src/qt/winshutdownmonitor.cpp

src/random.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/server.h

src/rpc/server.cpp

src/script/bitcoinconsensus.cpp

src/script/standard.cpp

src/streams.h

src/support/events.h

src/support/lockedpool.cpp

src/sync.h

src/sync.cpp

src/test/addrman_tests.cpp

src/test/miner_tests.cpp

src/test/raii_event_tests.cpp

src/test/skiplist_tests.cpp

src/test/test_bitcoin.h

src/test/test_bitcoin.cpp

src/test/txvalidationcache_tests.cpp

src/test/util_tests.cpp

src/test/versionbits_tests.cpp

src/torcontrol.cpp

Use nullptr consistently
ClosedPublic
Actions

Revision Contents
Changeset List