Page MenuHomePhabricator

clean up script_tests -- move segwit recovery into static json
ClosedPublic

Authored by markblundeberg on Jun 26 2019, 01:41.

Details

Summary

The script_build generated tests in script_tests are best reserved for
those tests that have transaction signatures in them -- they may need to
be regenerated for some reason as they are sensitive to transaction
contents and hashtype. Though non-signature tests can be done this way,
they unnecessarily add to the (quite large) computational resources used
during script_tests.cpp compilation and cause a warning during build:
variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without

Since segwit recovery tests involve no signatures, they can be moved into
the static parts of the json file.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanup_scripttests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6486
Build 11019: Bitcoin ABC Buildbot (legacy)
Build 11018: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 26 2019, 23:07