Page MenuHomePhabricator

Add error code when increasing DoS scores
ClosedPublic

Authored by deadalnix on Jul 26 2017, 23:18.

Details

Summary

This makes the logs clearer.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
misbehavereason
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 588
Build 588: arc lint + arc unit

Event Timeline

src/net_processing.h
58

typo s/reasoon/reason/

Test plan for such error changes needs to include system test suite.

(I tested, the extended suite passes - but please reflect in test plan)

This revision now requires changes to proceed.Jul 27 2017, 08:55
awemany requested changes to this revision.EditedJul 27 2017, 08:56

Maybe I am at Nazi complaint level here, but any new feature should be tested, no?

In that case, I think there should be a test that a call to Misbehaving will create the corresponding enhanced log message.

EDIT: make check succeeds.

make check works, log message testing is too much as per dev slack.

This revision is now accepted and ready to land.Jul 27 2017, 09:27
This revision was automatically updated to reflect the committed changes.