Page MenuHomePhabricator
Differential D380

Add error code when increasing DoS scores
ClosedPublic
Actions

Authored by deadalnix on Jul 26 2017, 23:18.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGINGe9b9c5101811: Add error code when increasing DoS scores
rABCe9b9c5101811: Add error code when increasing DoS scores
Summary

This makes the logs clearer.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
misbehavereason
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 589
Build 589: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 26 2017, 23:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2017, 23:18
sickpig added inline comments.Jul 26 2017, 23:27
src/net_processing.h
58 ↗(On Diff #946)

typo s/reasoon/reason/

deadalnix updated this revision to Diff 947.Jul 27 2017, 00:46

Fix typo

Harbormaster completed remote builds in B589: Diff 947.Jul 27 2017, 00:46
freetrader requested changes to this revision.Jul 27 2017, 08:55

Test plan for such error changes needs to include system test suite.

(I tested, the extended suite passes - but please reflect in test plan)

This revision now requires changes to proceed.Jul 27 2017, 08:55
awemany requested changes to this revision.EditedJul 27 2017, 08:56

Maybe I am at Nazi complaint level here, but any new feature should be tested, no?

In that case, I think there should be a test that a call to Misbehaving will create the corresponding enhanced log message.

EDIT: make check succeeds.

awemany accepted this revision.Jul 27 2017, 09:13

make check works, log message testing is too much as per dev slack.

awemany mentioned this in D384: Factor out getId() from Misbehaving(..) calls.Jul 27 2017, 09:18
deadalnix edited the test plan for this revision. (Show Details)Jul 27 2017, 09:26
freetrader accepted this revision.Jul 27 2017, 09:27
This revision is now accepted and ready to land.Jul 27 2017, 09:27
Closed by commit rABCe9b9c5101811: Add error code when increasing DoS scores (authored by deadalnix, committed by deadalnix). · Explain WhyJul 27 2017, 09:29
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D4150: Merge #12218: net: Move misbehaving logging to net logging category.Sep 24 2019, 21:20

Revision Contents
Changeset List

PathSize
src/
2 lines
138 lines
test/
14 lines

Diff 947

View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/DoS_tests.cpp

Loading...