Page MenuHomePhabricator
Differential D3875

Read more reject messages from debug logs in feature_dersig.py
ClosedPublic
Actions

Authored by jasonbcox on Aug 14 2019, 18:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py
rABCae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py
Summary

Partial backport of Core PR14119
https://github.com/bitcoin/bitcoin/pull/14119/files#diff-a22114218da7fa06c1bcd16d75c29bc7

Depends on D3862

Reviewer note: Some parts of the test differ due to changes done in D521. I left out the forced single-threaded validation since it's no longer relevant.

Test Plan

test_runner.py feature_dersig

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14119-p4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7148
Build 12341: Bitcoin ABC Buildbot (legacy)
Build 12340: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 14 2019, 18:23
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 14 2019, 18:23
teamcity added a comment.Aug 14 2019, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 14 2019, 18:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7148: Diff 10791.Aug 14 2019, 18:30
jasonbcox updated this revision to Diff 10797.Aug 14 2019, 19:11

Removed unnecessary -par arg and cleaned up unnecessary changes to imports

teamcity added a comment.Aug 14 2019, 19:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Aug 14 2019, 19:13
teamcity added a comment.Aug 14 2019, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7153: Diff 10797.Aug 14 2019, 19:18
Fabien accepted this revision.Aug 16 2019, 07:19
This revision is now accepted and ready to land.Aug 16 2019, 07:19
Closed by commit rABCae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py (authored by jasonbcox). · Explain WhyAug 16 2019, 23:09
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py.
jasonbcox added a commit: rSTAGINGae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py.Sep 19 2019, 01:53
PiRK mentioned this in D7981: p2p: Remove BIP61 reject messages.Oct 19 2020, 15:22
majcosta mentioned this in D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.Jan 13 2021, 13:58

Revision Contents
Changeset List

PathSize
test/
functional/
42 lines

Diff 10791

View Options

test/functional/feature_dersig.py

Loading...