Page MenuHomePhabricator
Differential D4368

[wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table
ClosedPublic
Actions

Authored by nakihito on Nov 4 2019, 19:08.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table
rABCc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table
Summary

Remove duplicate listreceivedby{account,label} methods.

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/a28b907f8a1e398eb458088a415d002ddbeee491

Depends on D4361

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12953-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7973
Build 13949: Bitcoin ABC Buildbot (legacy)
Build 13948: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 4 2019, 19:08
Owners added a reviewer: Restricted Owners Package.Nov 4 2019, 19:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 19:08
teamcity added a comment.Nov 4 2019, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Nov 4 2019, 19:09
nakihito added a parent revision: D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.
nakihito added a child revision: D4369: [wallet] Deprecate account RPC methods.Nov 4 2019, 19:14
teamcity added a comment.Nov 4 2019, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7973: Diff 13894.Nov 4 2019, 19:18
nakihito mentioned this in D3950: Merge #12953: Deprecate accounts.Nov 4 2019, 19:33
jasonbcox accepted this revision.Nov 5 2019, 01:04
This revision is now accepted and ready to land.Nov 5 2019, 01:04
Closed by commit rABCc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table (authored by John Newbery <john@johnnewbery.com>, committed by nakihito). · Explain WhyNov 5 2019, 21:25
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.
nakihito added a commit: rSTAGINGc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.Apr 7 2020, 21:36

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines

Diff 13894

View Options

src/wallet/rpcwallet.cpp

Loading...