This ensure we don't accept and relay non replay protected txns. It also fixes maxuploadtarget.py and get the test suite back to green.
Details
Details
- Reviewers
freetrader sickpig awemany kyuupichan hanchon CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGINGd6e6df4c5e8a: Only accept replay protected transactions in the mempool.
rABCd6e6df4c5e8a: Only accept replay protected transactions in the mempool.
make check ../qa/pull-tester/rpc-tests.py -extended
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
This comment was removed by CCulianu.
Comment Actions
I think you need to update the txvalidationcache_tests -- right now C++ tests are failing with this patch, because the test case doesn't construct replay protected tx's.
calin@ubuntu:~/scratch/btc-abc.phab/bitcoin-abc$ depends/out_dir-i686-pc-linux-gnu/bin/test_bitcoin -t txvalidationcache_tests Running 1 test case... test/txvalidationcache_tests.cpp(69): error: in "txvalidationcache_tests/tx_mempool_block_doublespend": check ToMemPool(spends[0]) has failed test/txvalidationcache_tests.cpp(75): error: in "txvalidationcache_tests/tx_mempool_block_doublespend": check ToMemPool(spends[1]) has failed test/txvalidationcache_tests.cpp(83): error: in "txvalidationcache_tests/tx_mempool_block_doublespend": check ToMemPool(spends[1]) has failed *** 3 failures are detected in the test module "Bitcoin Test Suite"
Comment Actions
Oops! I didn't realize D440 was part of this stack. You should have mentioned that. i totally didn't see it.
yeah with D440 applied this change passes and looks good. I'm going to go ahead and approve it as it runs fine and looks 100% ok to me.
Sorry for the confusion with my saying it failed tests -- I didn't realize it was related. Kindly do mention that next time when you have related changes because it makes it a lot easier...