Page MenuHomePhabricator

[backport#15288] Remove uses of g_connman in wallet code
ClosedPublic

Authored by majcosta on Apr 25 2020, 22:47.

Details

Summary

00dfb2a440b94a24b61cafb519fb122f6a0ae176 This commit does not change behavior. (Russell Yanofsky)


Depends on D5839

This is a partial backport of Core PR15288

Test Plan
../configure --enable-deprecated-build-system --enable-werror --enable-debug --disable-wallet
make check-recursive
../configure --enable-deprecated-build-system --enable-werror --enable-debug
make check-recursive
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10410
Build 18641: Default Diff Build & Tests
Build 18640: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 25 2020, 23:38
deadalnix added a subscriber: deadalnix.

cmake build?

This revision now requires changes to proceed.Apr 25 2020, 23:38

Also, please edit your test plan so tat command appear like command. Prefix with two spaces for instance.

majcosta edited the test plan for this revision. (Show Details)

corrected test plan and formatting

deadalnix requested changes to this revision.Apr 26 2020, 13:27

You need to modify the cmake build to reflect the changes as well.

This revision now requires changes to proceed.Apr 26 2020, 13:27

added linking zmq target to wallet. apparently the bench project already links to server and to wallet, if the latter is being built

This revision is now accepted and ready to land.Apr 27 2020, 13:42