Differential D8791

Rename CheckIfBanned() to MaybeDiscourageAndDisconnect()
ClosedPublic
Actions

Authored by Fabien on Jan 5 2021, 13:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6176f87a9d44: Rename CheckIfBanned() to MaybeDiscourageAndDisconnect()

Summary

This completes backport of core PR19219.
This renaming part was previously skipped from D7146 due to missing
backports:
https://reviews.bitcoinabc.org/D7146?id=22789#inline-42357

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19219

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14572
Build 29106: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29105: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 5 2021, 13:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 13:32

Fabien requested review of this revision.Jan 5 2021, 13:32

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 13:32

Harbormaster completed remote builds in B14572: Diff 26635.Jan 5 2021, 13:49

Fabien added a child revision: D8792: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect().Jan 5 2021, 14:07

PiRK accepted this revision.Jan 5 2021, 18:35

This revision is now accepted and ready to land.Jan 5 2021, 18:35

Closed by commit rABC6176f87a9d44: Rename CheckIfBanned() to MaybeDiscourageAndDisconnect() (authored by Fabien). · Explain WhyJan 6 2021, 10:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6176f87a9d44: Rename CheckIfBanned() to MaybeDiscourageAndDisconnect().

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

3 lines

net_processing.cpp

6 lines

Diff 26635

src/net_processing.h

Loading...

src/net_processing.cpp

Loading...