Page MenuHomePhabricator
Differential D521

Always use the parallel check codepath for block validation
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2017, 20:23.

Details

Reviewers
freetrader
CCulianu
sickpig
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGING8ed800afad05: Always use the parallel check codepath for block validation
rABC8ed800afad05: Always use the parallel check codepath for block validation
Summary

Less codepath, more fun. We also had a bug linked to only one of the two path being tested.

Test Plan

Synced the testnet with -par=0 and -par=1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alwaysparcheckinputs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 825
Build 825: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2017, 20:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2017, 20:23
sickpig added a subscriber: sickpig.Sep 5 2017, 09:59
sickpig added inline comments.
src/validation.cpp
1341

nit: it is a pretty simple change but I wonder it wouldn't be better to this kind of modifications in a separate diff and for the entire file (there are 22 instances of unsigned int in this file alone)

sickpig accepted this revision as: sickpig.Sep 5 2017, 10:01

Accepted modulo the unsigned int unrelated change (but I'm good in either case) .

dagurval requested changes to this revision.Sep 5 2017, 22:27
dagurval added a subscriber: dagurval.

After this chance there is nothing but init.cpp using nScriptCheckThreads. How about making it a local variable there? One less global variable.

This revision now requires changes to proceed.Sep 5 2017, 22:27
deadalnix updated this revision to Diff 1325.Sep 5 2017, 23:17
deadalnix edited edge metadata.

Rebase.

@dagurval, removing the global variable and querying GetArg instead doesn't make the value any less global.

Harbormaster completed remote builds in B836: Diff 1325.Sep 5 2017, 23:17
dagurval accepted this revision as: dagurval.Sep 6 2017, 06:17
In D521#9312, @deadalnix wrote:

@dagurval, removing the global variable and querying GetArg instead doesn't make the value any less global.

You'll literally have one less global variable decleration in validation.h.

dagurval accepted this revision.Sep 6 2017, 21:51
This revision is now accepted and ready to land.Sep 6 2017, 21:51
Closed by commit rABC8ed800afad05: Always use the parallel check codepath for block validation (authored by deadalnix, committed by deadalnix). · Explain WhySep 6 2017, 21:53
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D3875: Read more reject messages from debug logs in feature_dersig.py.Aug 14 2019, 18:23
jasonbcox mentioned this in D3878: Read more reject messages from debug logs in feature_cltv.py.Aug 14 2019, 19:09
jasonbcox mentioned this in rABCae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py.Aug 16 2019, 23:09
jasonbcox mentioned this in rABC958009f15f09: Read more reject messages from debug logs in feature_cltv.py.
jasonbcox mentioned this in rSTAGINGae9f9b6054c0: Read more reject messages from debug logs in feature_dersig.py.Sep 19 2019, 01:53
jasonbcox mentioned this in rSTAGING958009f15f09: Read more reject messages from debug logs in feature_cltv.py.
majcosta mentioned this in D7275: [backport#17342][refactor] Remove global int nScriptCheckThreads.Aug 31 2020, 20:09
majcosta mentioned this in rABC6b134a6895e1: [backport#17342][refactor] Remove global int nScriptCheckThreads.Sep 1 2020, 12:20
PiRK mentioned this in D7981: p2p: Remove BIP61 reject messages.Oct 19 2020, 15:22

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
3 lines
src/
8 lines

Diff 1311

View Options

qa/rpc-tests/abc-rpc.py

Loading...
View Options

src/validation.cpp

Loading...