Page MenuHomePhabricator
Differential D5816

[backport#15288] Remove uses of CheckFinalTx in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 23 2020, 16:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code
rABC2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code
Summary

80f52a2267f44a9cae4440615df3ff989be1579c This commit does not change behavior. (Russell Yanofsky)

This is a follow up to D5804 and a partial backport of Core PR15288

Test Plan
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check check-functional
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10365
Build 18551: Default Diff Build & Tests
Build 18550: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 23 2020, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 16:48
teamcity edited the summary of this revision. (Show Details)Apr 23 2020, 16:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 23 2020, 16:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta planned changes to this revision.Apr 23 2020, 16:52
teamcity added a comment.Apr 23 2020, 16:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10365: Diff 19059.Apr 23 2020, 16:58
majcosta requested review of this revision.Apr 23 2020, 17:01
majcosta edited the summary of this revision. (Show Details)Apr 23 2020, 17:15
majcosta added a child revision: D5819: [backport#15288] Remove use of IsRBFOptIn in wallet code.Apr 23 2020, 20:08
deadalnix requested changes to this revision.Apr 23 2020, 22:34
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
139

Why flags?

src/interfaces/chain.h
9

You can forward declare instead of adding includes, because you only pass by ref.

This revision now requires changes to proceed.Apr 23 2020, 22:34
majcosta updated this revision to Diff 19071.Apr 23 2020, 23:34

replaced header includes with forward declarations and removed optional flag argument to contextualCheckTransactionForCurrentBlock

teamcity added a comment.Apr 23 2020, 23:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Apr 23 2020, 23:38
This revision is now accepted and ready to land.Apr 23 2020, 23:38
teamcity added a comment.Apr 23 2020, 23:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10372: Diff 19071.Apr 23 2020, 23:44
Closed by commit rABC2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 23 2020, 23:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code.
majcosta added a commit: rSTAGING2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
src/
interfaces/
8 lines
7 lines
8 lines
wallet/
16 lines
19 lines

Diff 19059

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...