Differential D5840

[backport#15288] Remove uses of g_connman in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 25 2020, 22:47.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGce4499d4eb69: [backport#15288] Remove uses of g_connman in wallet code
rABCce4499d4eb69: [backport#15288] Remove uses of g_connman in wallet code

Summary

00dfb2a440b94a24b61cafb519fb122f6a0ae176 This commit does not change behavior. (Russell Yanofsky)

Depends on D5839

This is a partial backport of Core PR15288

Test Plan

../configure --enable-deprecated-build-system --enable-werror --enable-debug --disable-wallet
make check-recursive
../configure --enable-deprecated-build-system --enable-werror --enable-debug
make check-recursive
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15288

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10410
Build 18641: Default Diff Build & Tests
Build 18640: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 25 2020, 22:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 25 2020, 22:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10410: Diff 19127.Apr 25 2020, 22:57

cmake build?

This revision now requires changes to proceed.Apr 25 2020, 23:38

Also, please edit your test plan so tat command appear like command. Prefix with two spaces for instance.

corrected test plan and formatting

You need to modify the cmake build to reflect the changes as well.

This revision now requires changes to proceed.Apr 26 2020, 13:27

added linking zmq target to wallet. apparently the bench project already links to server and to wallet, if the latter is being built

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10421: Diff 19142.Apr 27 2020, 07:13

majcosta edited the test plan for this revision. (Show Details)Apr 27 2020, 08:52

deadalnix accepted this revision.Apr 27 2020, 13:42

This revision is now accepted and ready to land.Apr 27 2020, 13:42

Closed by commit rABCce4499d4eb69: [backport#15288] Remove uses of g_connman in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 27 2020, 13:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCce4499d4eb69: [backport#15288] Remove uses of g_connman in wallet code.

majcosta added a child revision: D5851: [backport#15288] Remove use of g_connman / PushInventory in wallet code.Apr 27 2020, 14:02

Fabien mentioned this in D5872: [CMAKE] Fix the build with ZMQ disabled.Apr 28 2020, 12:23

Fabien mentioned this in rABCee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled.Apr 28 2020, 13:43

majcosta added a commit: rSTAGINGce4499d4eb69: [backport#15288] Remove uses of g_connman in wallet code.May 5 2020, 19:09

Fabien mentioned this in rSTAGINGee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled.May 5 2020, 19:11

Revision Contents
Changeset List

Path

Size

src/

8 lines

Makefile.bench.include

2 lines

interfaces/

3 lines

2 lines

wallet/

6 lines

Diff 19127

src/Makefile.am

Loading...

src/Makefile.bench.include

Loading...

src/interfaces/chain.h

Loading...

src/interfaces/chain.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...