Page MenuHomePhabricator
Differential D1101

Adds OP_BIN2NUM functionality into interpreter.cpp
AbandonedPublic
Actions

Authored by schancel on Feb 15 2018, 01:18.

Details

Reviewers
movrcx
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Takes a byte string in sign magnitude little endian format and outputs a minimally-encoded number.

Co-authored-by: Marcos Mayorga <mm@mm-studios.com>
Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1099
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2058
Build 2263: Bitcoin ABC Buildbot (legacy)
Build 2262: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 01:18
Harbormaster completed remote builds in B1855: Diff 2878.Feb 15 2018, 01:18
movrcx added a child revision: D1102: unit tests for OP_BIN2NUM.Feb 15 2018, 01:20
movrcx added parent revisions: D1090: Adds Bitwise functionality into interpreter.cpp, D1099: Adds OP_SPLIT functionality into interpreter.cpp, D1100: unit tests for OP_SPLIT, D1097: Add support for CAT, and SPLIT opcodes, D1098: unit test for OP_CAT, D1093: Adds OP_DIV functionality into interpreter.cpp, D1092: unit test for bitwise operations (AND, OR, XOR), D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1096: unit test for OP_MOD, D1094: unit test for OP_DIV, D1095: Adds OP_MOD functionality into interpreter.cpp.
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57
shadders added a subscriber: shadders.Feb 15 2018, 03:24
movrcx updated this revision to Diff 2901.Feb 16 2018, 08:22

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Harbormaster completed remote builds in B1877: Diff 2901.Feb 16 2018, 08:22
danconnolly added a subscriber: danconnolly.Feb 21 2018, 08:50
jasonbcox added a subscriber: jasonbcox.Feb 23 2018, 18:46
jasonbcox added inline comments.
src/script/interpreter.cpp
1300 ↗(On Diff #2901)

More descriptive comment. Something like: // big Endian to little Endian

movrcx marked an inline comment as done.Feb 28 2018, 00:25
movrcx updated this revision to Diff 3002.Feb 28 2018, 00:25

Update comments and add OP_BIN2NUM definition in script.cpp

Harbormaster completed remote builds in B1944: Diff 3002.Feb 28 2018, 00:25
movrcx added a child revision: D1142: Added tests for disabled opcodes before/after the fork..Feb 28 2018, 01:57
schancel removed a child revision: D1102: unit tests for OP_BIN2NUM.Mar 9 2018, 10:42
schancel removed a child revision: D1142: Added tests for disabled opcodes before/after the fork..Mar 9 2018, 10:49
schancel removed parent revisions: D1094: unit test for OP_DIV, D1096: unit test for OP_MOD, D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1092: unit test for bitwise operations (AND, OR, XOR), D1098: unit test for OP_CAT, D1100: unit tests for OP_SPLIT.Mar 9 2018, 10:52
schancel edited parent revisions, added: D1103: Add support for NUM2BIN, and BIN2NUM opcodes; removed: D1095: Adds OP_MOD functionality into interpreter.cpp, D1093: Adds OP_DIV functionality into interpreter.cpp, D1097: Add support for CAT, and SPLIT opcodes, D1099: Adds OP_SPLIT functionality into interpreter.cpp, D1090: Adds Bitwise functionality into interpreter.cpp.Mar 9 2018, 11:03
danconnolly edited parent revisions, added: D1099: Adds OP_SPLIT functionality into interpreter.cpp; removed: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Mar 12 2018, 21:07
danconnolly added a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
danconnolly updated this revision to Diff 3163.Mar 12 2018, 21:23

resubmit D1101, updated for underlying changes

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 21:23
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 21:23
danconnolly edited the test plan for this revision. (Show Details)Mar 12 2018, 21:23
teamcity added a subscriber: teamcity.Mar 12 2018, 21:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

movrcx updated this revision to Diff 3227.Mar 16 2018, 02:57

Cleaning up due to D1202

teamcity added a comment.Mar 16 2018, 03:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 16 2018, 03:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2109: Diff 3227!Mar 16 2018, 03:16
movrcx updated this revision to Diff 3257.Mar 17 2018, 02:20

Rebase off of master

teamcity added a comment.Mar 17 2018, 02:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 17 2018, 03:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2136: Diff 3257!Mar 17 2018, 03:10
schancel commandeered this revision.Mar 18 2018, 02:59
schancel abandoned this revision.
schancel added a reviewer: movrcx.
schancel removed a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Mar 18 2018, 03:14

Revision Contents
Changeset List

PathSize
src/
script/
35 lines
1 line
2 lines
test/
73 lines

Diff 3163

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/op_code.cpp

Loading...