Page MenuHomePhabricator
Differential D1612

Bump automatic replay protection to May 2019 upgrade
ClosedPublic
Actions

Authored by Mengerian on Jul 30 2018, 03:04.

Details

Reviewers
deadalnix
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING92da404962cc: Bump automatic replay protection to May 2019 upgrade
rABC92da404962cc: Bump automatic replay protection to May 2019 upgrade
Summary

This returns main chain to ForkID of 0 after the Nov 2018
upgrade, and implements automatic replay protection for
the May 2019 upgrade.

For reference see last HF:
https://reviews.bitcoinabc.org/D1199

Test Plan

Replay protection is covered by unit tests, however
it is very important to manually double check that the timestamp
for activation is set correctly.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
May-2019-HF
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 3040
Build 4172: Bitcoin ABC Buildbot (legacy)
Build 4171: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jul 30 2018, 03:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2018, 03:04
teamcity added a subscriber: teamcity.Jul 30 2018, 03:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 30 2018, 03:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2995: Diff 4470.Jul 30 2018, 03:47
schancel requested changes to this revision.Aug 3 2018, 16:36
schancel added inline comments.
src/chainparams.cpp
135 ↗(On Diff #4470)

Please put the exact time:

Wed May 15 12:00:00 2019 UTC

👍

This revision now requires changes to proceed.Aug 3 2018, 16:36
Mengerian updated this revision to Diff 4495.Aug 4 2018, 17:42

More specific time in comment

teamcity added a comment.Aug 4 2018, 17:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 4 2018, 18:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3015: Diff 4495.Aug 4 2018, 18:26
jasonbcox requested changes to this revision.Aug 5 2018, 16:29
jasonbcox added inline comments.
src/validation.cpp
600 ↗(On Diff #4495)

There is zero documentation of this arg anywhere. Can you add comments here to describe the intended behavior?

This revision now requires changes to proceed.Aug 5 2018, 16:29
Mengerian updated this revision to Diff 4508.Aug 5 2018, 21:39

Add comment describing intended behavior of -replayprotectionactivationtime

teamcity added a comment.Aug 5 2018, 21:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian updated this revision to Diff 4509.Aug 5 2018, 21:50

Fix whitespace, and more detailed date in one more place

teamcity added a comment.Aug 5 2018, 21:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 5 2018, 22:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3024: Diff 4508.Aug 5 2018, 22:17
teamcity added a comment.Aug 5 2018, 22:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3025: Diff 4509.Aug 5 2018, 22:31
schancel accepted this revision.Aug 7 2018, 19:11
deadalnix accepted this revision.Aug 8 2018, 18:57
jasonbcox accepted this revision.Aug 8 2018, 20:11
This revision is now accepted and ready to land.Aug 8 2018, 20:11
Mengerian updated this revision to Diff 4533.Aug 8 2018, 21:12

rebase

teamcity added a comment.Aug 8 2018, 21:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 8 2018, 21:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3040: Diff 4533.Aug 8 2018, 21:54
Closed by commit rABC92da404962cc: Bump automatic replay protection to May 2019 upgrade (authored by Mengerian). · Explain WhyAug 8 2018, 22:13
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in D2376: Bump automatic replay protection to Nov 2019 upgrade.Jan 22 2019, 01:13
dagurval mentioned this in rABC31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade.Feb 12 2019, 00:09
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade.Sep 18 2019, 22:22

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
9 lines
consensus/
2 lines
6 lines

Diff 4533

View Options

doc/release-notes.md

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/validation.cpp

Loading...