Differential D16288

Fix some std::move issues
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 18:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC54d457d91401: Fix some std::move issues

Summary

These moves are either:

copies because the variable being moved is const
references because the function parameter the var is moved to is a reference

Either fix by removing the constness or removing the move.
For the places where the move is removed, there is no performance impact as it was not working anyway.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_abusive_move

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29229
Build 57994: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 57993: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 5 2024, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 18:11

Fabien requested review of this revision.Jun 5 2024, 18:11

Fabien added a child revision: D16285: Fix issues when calling std::move(const&).Jun 5 2024, 18:18

PiRK accepted this revision.Jun 5 2024, 18:36

This revision is now accepted and ready to land.Jun 5 2024, 18:36

Harbormaster completed remote builds in B29229: Diff 48127.Jun 5 2024, 19:01

Closed by commit rABC54d457d91401: Fix some std::move issues (authored by Fabien). · Explain WhyJun 5 2024, 22:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC54d457d91401: Fix some std::move issues.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

2 lines

test/

processor_tests.cpp

4 lines

bench/

4 lines

blockencodings.cpp

2 lines

net_processing.cpp

2 lines

rpc/

5 lines

Diff 48127

src/avalanche/processor.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...

src/bench/chained_tx.cpp

Loading...

src/blockencodings.cpp

Loading...

src/net_processing.cpp

Loading...

src/rpc/avalanche.cpp

Loading...