As per title. When unparking chain automatically, we do not want to unpark all children by default. Only the RPC should do this.
Depends on D2004
Details
Details
- Reviewers
jasonbcox schancel - Group Reviewers
Restricted Project - Commits
- rSTAGING45ca215ceb4f: Do not unpark children of blocks outside of the RPC
rABC45ca215ceb4f: Do not unpark children of blocks outside of the RPC
make check ./test/functional/test_runner.py --extended
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- unparkrefac
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3880 Build 5833: Bitcoin ABC Buildbot (legacy) Build 5832: arc lint + arc unit
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 2923 ↗ | (On Diff #5788) | Seeing that both UnparkBlockAndChildren() and UnparkBlock() return true, it's probably better design-wise to make UnparkBlockImpl return bool type and have it return true at the end of the function. Then those two functions just return UnparkBlockImpl(...); |
Comment Actions
Ideally this would come with a test. Something like node0: A -> B (parked) --------> C -> D (chaintip) B -> E (parked-parent and parked). node1 goes through IBD and E remains parked.