Avalanche will need to pool peers on a regular basis, which require an event loop. This introduces the event loop, but it does nothing so far.
Depends on D2042
Details
Details
- Reviewers
jasonbcox schancel Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING3aeef6295cbe: [avalanche] Create an event loop facility.
rABC3aeef6295cbe: [avalanche] Create an event loop facility.
make check
Added unit tests.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avaeventloop
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4059 Build 6189: Bitcoin ABC Buildbot (legacy) Build 6188: arc lint + arc unit
Event Timeline
| src/avalanche.cpp | ||
|---|---|---|
| 61 ↗ | (On Diff #5750) | MILISECONDS -> MILLISECONDS Comment says every 20ms, so this should be 20 not 10 (or just fix the comment). |
| 76 ↗ | (On Diff #5750) | This statement can be more concise: if (stopRequest) {
// A stop request was made.
LOCK(cs_running);
running = false;
cond_running.notify_all();
}
return running; |
| src/test/avalanche_tests.cpp | ||
| 179 ↗ | (On Diff #5750) | taht -> , so or , so that |
| src/avalanche.cpp | ||
|---|---|---|
| 76 ↗ | (On Diff #5750) | More concise and also incorrect. |
| src/avalanche.cpp | ||
|---|---|---|
| 81 ↗ | (On Diff #5757) | You may add braces surrounding LOCK and running=false to (slightly) reduce the scope of the lock. |
| src/avalanche.cpp | ||
|---|---|---|
| 81 ↗ | (On Diff #5757) | That would introduce a race condition. |