Page MenuHomePhabricator
Differential D2122

[avalanche] Enforce cooldown request present in AvalancheResponse
ClosedPublic
Actions

Authored by deadalnix on Nov 23 2018, 02:13.

Details

Reviewers
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING751f09e7dbac: [avalanche] Enforce cooldown request present in AvalancheResponse
rABC751f09e7dbac: [avalanche] Enforce cooldown request present in AvalancheResponse
Summary

It is important in order to ensure the health of the network that node are able to throttle the requests they get from peers. This makes sure the core mechanics respect these cooldown requests.

Depends on D2117

Test Plan

Added tests case.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nodecooldown
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4076
Build 6223: Bitcoin ABC Buildbot (legacy)
Build 6222: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 23 2018, 02:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2018, 02:13
teamcity added a subscriber: teamcity.Nov 23 2018, 02:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 23 2018, 02:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4076: Diff 6048.Nov 23 2018, 02:24
Fabien added a subscriber: Fabien.Nov 23 2018, 19:41
Fabien added inline comments.
src/avalanche.cpp
274

needa => need a

schancel retitled this revision from [avalanche] Ensfore cooldown request present in AvalancheResponse to [avalanche] Enforce cooldown request present in AvalancheResponse.Nov 23 2018, 22:22
schancel edited the summary of this revision. (Show Details)
deadalnix updated this revision to Diff 6074.Nov 24 2018, 15:34

Fix typo

teamcity added a comment.Nov 24 2018, 15:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4098: Diff 6074.Nov 24 2018, 15:44
teamcity added a comment.Nov 24 2018, 15:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Nov 26 2018, 18:47
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche.cpp
72 ↗(On Diff #6074)

Is there a reason we're departing from GetTime() / GetTimeMillis() / GetTimeMicros()? If chrono is strictly better, then we should begin migrating away from the current GetTime implementation (in separate diffs, obviously).

This revision now requires changes to proceed.Nov 26 2018, 18:47
deadalnix added a child revision: D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out..Nov 26 2018, 20:45
deadalnix requested review of this revision.Nov 27 2018, 13:08
deadalnix marked an inline comment as done.

There is nothing actionable in that review.

src/avalanche.cpp
72 ↗(On Diff #6074)

These times can be mocked. They use an ancestor of chrono from boost under the hood.

Fabien accepted this revision as: Fabien.Nov 27 2018, 13:48
jasonbcox accepted this revision.Nov 27 2018, 18:05
In D2122#47045, @deadalnix wrote:

There is nothing actionable in that review.

There is. Answering my question is (imo) critical to getting this code reviewed.

This revision is now accepted and ready to land.Nov 27 2018, 18:05
Closed by commit rABC751f09e7dbac: [avalanche] Enforce cooldown request present in AvalancheResponse (authored by deadalnix). · Explain WhyNov 27 2018, 19:03
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
5 lines
29 lines
test/
29 lines

Diff 6048

View Options

src/avalanche.h

Loading...
View Options

src/avalanche.cpp

Loading...
View Options

src/test/avalanche_tests.cpp

Loading...