Details

Reviewers

jasonbcox
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING1951a4e6cfef: [avalanche] Use a multi_index to track request so it is easy to determine which…
rABC1951a4e6cfef: [avalanche] Use a multi_index to track request so it is easy to determine which…

Summary

As per title. This also adds the requirement that an avaresponse needs to return the round it is responding to. This ensure it is possible to have several queries in flight for a given node if we want to.

Depends on D2122

Test Plan

Updated unit tests accordingly.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avareqtracking

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4130
Build 6331: Bitcoin ABC Buildbot (legacy)
Build 6330: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 26 2018, 20:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2018, 20:45

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4130: Diff 6112.Nov 26 2018, 20:55

jasonbcox requested changes to this revision.Nov 26 2018, 21:15

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/avalanche.h
132	What is this and what is it for?

This revision now requires changes to proceed.Nov 26 2018, 21:15

deadalnix added a child revision: D2140: [avalanche] Delegate node management to caller.Nov 26 2018, 23:39

Fabien requested changes to this revision.Nov 27 2018, 15:09

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche.h
15	This requires an update in the build documentation build-unix.md: in section "Dependency Build Instructions : Ubuntu & Debian" add `libboost-serialization-dev` to the list of the required boost library files.