Page MenuHomePhabricator
Differential D1969

[Part 2 of 5] Add a CChainState class to clarify internal interfaces
ClosedPublic
Actions

Authored by jasonbcox on Oct 24 2018, 18:50.

Details

Reviewers
schancel
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4e4fb6e1bb28: [Part 2 of 5] Add a CChainState class to clarify internal interfaces
rABC4e4fb6e1bb28: [Part 2 of 5] Add a CChainState class to clarify internal interfaces
Summary

Move block writing out of AcceptBlock

Backport of Core PR 10279 commit e104f0f
https://github.com/bitcoin/bitcoin/pull/10279/commits/e104f0fb7e464f8cadb4cbc99e8329d22c35c36a
Depends on D1968
Progress towards T572

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1969
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4178
Build 6422: Bitcoin ABC Buildbot (legacy)
Build 6421: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 24 2018, 18:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:50
teamcity added a subscriber: teamcity.Oct 24 2018, 18:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel edited the summary of this revision. (Show Details)Oct 24 2018, 18:52
schancel added a parent revision: D1968: [Part 1 of 5] Add a CChainState class to clarify internal interfaces.
schancel added a child revision: D1970: [Part 3 of 5] Add a CChainState class to clarify internal interfaces.
teamcity added a comment.Oct 24 2018, 18:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3675: Diff 5524.Oct 24 2018, 18:59
schancel planned changes to this revision.Oct 26 2018, 22:47
schancel requested review of this revision.Nov 29 2018, 21:50
schancel updated this revision to Diff 6183.Nov 29 2018, 21:57

Rebase, remove excess whitespace change

teamcity added a comment.Nov 29 2018, 21:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 29 2018, 22:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4178: Diff 6183.Nov 29 2018, 22:05
jasonbcox requested changes to this revision.Nov 30 2018, 22:43
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3176

Missing lines from e104f0f

3879

is this equivalent to return false; as in the original PR?

4815

This line was moved in the original PR

This revision now requires changes to proceed.Nov 30 2018, 22:43
jasonbcox commandeered this revision.Mar 27 2019, 23:17
jasonbcox edited reviewers, added: schancel; removed: jasonbcox.
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox updated this revision to Diff 7851.Mar 27 2019, 23:48

Rebase + fixes described above

jasonbcox edited the summary of this revision. (Show Details)Mar 27 2019, 23:48
teamcity added a comment.Mar 27 2019, 23:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 28 2019, 00:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5320: Diff 7851.Mar 28 2019, 00:02
Fabien accepted this revision.Mar 28 2019, 10:12
This revision is now accepted and ready to land.Mar 28 2019, 10:12
Closed by commit rABC4e4fb6e1bb28: [Part 2 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>, committed by jasonbcox). · Explain WhyMar 28 2019, 23:21
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING4e4fb6e1bb28: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.Sep 18 2019, 22:49

Revision Contents
Changeset List

PathSize
src/
60 lines

Diff 6183

View Options

src/validation.cpp

Loading...