Page MenuHomePhabricator
Feed Advanced Search

Aug 3 2018

schancel updated the diff for D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.

Fix unit tests

Aug 3 2018, 01:52

Aug 2 2018

schancel requested changes to D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Aug 2 2018, 21:12
Herald added a reviewer for D1615: Make transaction ordering tests easier to debug: Restricted Project.
Aug 2 2018, 20:55
schancel requested changes to D1614: Change bdb prefix to correct version.
Aug 2 2018, 20:29
schancel accepted D1614: Change bdb prefix to correct version.
Aug 2 2018, 20:02

Jul 30 2018

schancel updated the diff for D1480: Tweak UTXO weight based agreed suggested costs.

Rebase

Jul 30 2018, 22:24
schancel updated the diff for D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.

Fix package fee modification during mining

Jul 30 2018, 22:21

Jul 29 2018

schancel accepted D1601: Pass flags down to GetSigOpCount.
Jul 29 2018, 19:35

Jul 27 2018

schancel accepted D1605: Count OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY as sigops when the proper flag is set..
Jul 27 2018, 17:24
schancel requested changes to D1601: Pass flags down to GetSigOpCount.
Jul 27 2018, 17:23
schancel updated the diff for D1480: Tweak UTXO weight based agreed suggested costs.

Rebase on D1581

Jul 27 2018, 00:51
schancel updated the diff for D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.

Rebase

Jul 27 2018, 00:49
schancel abandoned D1607: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.
Jul 27 2018, 00:49
Herald added a reviewer for D1607: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs: Restricted Project.
Jul 27 2018, 00:47

Jul 26 2018

schancel added inline comments to D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.
Jul 26 2018, 22:24
schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Rebase

Jul 26 2018, 21:56
schancel updated the diff for D1480: Tweak UTXO weight based agreed suggested costs.

Rebase

Jul 26 2018, 21:55
schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Rebase

Jul 26 2018, 21:33
schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Rebase

Jul 26 2018, 21:33
schancel committed rABC23e15185df78: [qa] use calculate_fee for prioritise_transaction (authored by schancel).
[qa] use calculate_fee for prioritise_transaction
Jul 26 2018, 21:23
schancel closed D1587: [qa] use calculate_fee for prioritise_transaction.
Jul 26 2018, 21:23
schancel committed rABCd685f64625d5: [qa] Use proper fee accounting in mempool_limit (authored by schancel).
[qa] Use proper fee accounting in mempool_limit
Jul 26 2018, 20:49
schancel closed D1582: [qa] Use proper fee accounting in mempool_limit.
Jul 26 2018, 20:48
schancel added inline comments to D1600: Added RPCCommand and associated classes.
Jul 26 2018, 20:32
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Reword comment to be more intelligible.

Jul 26 2018, 20:29
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Update to depend on D1582

Jul 26 2018, 20:15
schancel updated the diff for D1582: [qa] Use proper fee accounting in mempool_limit.

Incorporate feedback

Jul 26 2018, 20:11
schancel committed rABC1ab9230f5c56: [qa] change bip68 sequence to use calculate_fee (authored by schancel).
[qa] change bip68 sequence to use calculate_fee
Jul 26 2018, 19:37
schancel closed D1561: [qa] change bip68 sequence to use calculate_fee.
Jul 26 2018, 19:37
schancel added inline comments to D1561: [qa] change bip68 sequence to use calculate_fee.
Jul 26 2018, 19:33
schancel added inline comments to D1600: Added RPCCommand and associated classes.
Jul 26 2018, 16:36
schancel added inline comments to D1587: [qa] use calculate_fee for prioritise_transaction.
Jul 26 2018, 16:10

Jul 25 2018

schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Include billable_size in this diff

Jul 25 2018, 18:43
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Remove billable size function

Jul 25 2018, 18:41
schancel updated the diff for D1582: [qa] Use proper fee accounting in mempool_limit.

Address feedback about create_lots_of_big_transactions

Jul 25 2018, 18:32
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Address feedback from Jason about OP_PUSHDATA2

Jul 25 2018, 18:31
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Fix typo

Jul 25 2018, 18:10
schancel updated the diff for D1582: [qa] Use proper fee accounting in mempool_limit.

Fix mempool_limit and address feedback

Jul 25 2018, 18:08
schancel added inline comments to D1582: [qa] Use proper fee accounting in mempool_limit.
Jul 25 2018, 18:04
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Fix some feedback

Jul 25 2018, 18:03
schancel added inline comments to D1582: [qa] Use proper fee accounting in mempool_limit.
Jul 25 2018, 18:03
schancel added a comment to D1587: [qa] use calculate_fee for prioritise_transaction.

@deadalnix Yeah there was a bunch because I asked Jason to take a look at it. It's rebased now.

Jul 25 2018, 18:00
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Clean up unnecessary LogPrints

Jul 25 2018, 17:59
schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Rebase on master

Jul 25 2018, 17:57
schancel committed rABC9c6f4b94b4a1: Remove blockFinished from BlockAssembler (authored by schancel).
Remove blockFinished from BlockAssembler
Jul 25 2018, 15:53
schancel closed D1591: Remove blockFinished from BlockAssembler.
Jul 25 2018, 15:53
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Fix a few nits

Jul 25 2018, 15:41
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Fix a typo

Jul 25 2018, 15:24
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Address some more feedback

Jul 25 2018, 15:13
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Fix nits

Jul 25 2018, 14:58
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Reword TestForBlockResult parameter to make it clearer

Jul 25 2018, 02:18
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Remove wild semicolon

Jul 25 2018, 02:08
schancel committed rABC38c5c298bdd7: Couple of code nits in miner.cpp (authored by schancel).
Couple of code nits in miner.cpp
Jul 25 2018, 01:43
schancel closed D1590: Couple of code nits in miner.cpp.
Jul 25 2018, 01:43
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Remove a missed reference

Jul 25 2018, 01:43
schancel updated the diff for D1591: Remove blockFinished from BlockAssembler.

Fix accidentally removed code during rebase

Jul 25 2018, 01:14
Herald added a reviewer for D1591: Remove blockFinished from BlockAssembler: Restricted Project.
Jul 25 2018, 01:11
schancel updated the diff for D1590: Couple of code nits in miner.cpp.

One more nit

Jul 25 2018, 00:39
Herald added a reviewer for D1590: Couple of code nits in miner.cpp: Restricted Project.
Jul 25 2018, 00:35

Jul 24 2018

schancel updated the diff for D1587: [qa] use calculate_fee for prioritise_transaction.

Derp?

Jul 24 2018, 22:42

Jul 23 2018

Herald added a reviewer for D1587: [qa] use calculate_fee for prioritise_transaction: Restricted Project.
Jul 23 2018, 16:36

Jul 20 2018

schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Fix double fee_multiplier

Jul 20 2018, 20:02
Herald added a reviewer for D1582: [qa] Use proper fee accounting in mempool_limit: Restricted Project.
Jul 20 2018, 19:57
schancel committed rABC184cf2684319: Create a typedef for handling mapDeltas in the mempool. (authored by schancel).
Create a typedef for handling mapDeltas in the mempool.
Jul 20 2018, 18:33
schancel closed D1383: Create a typedef for handling mapDeltas in the mempool..
Jul 20 2018, 18:32
schancel updated the diff for D1383: Create a typedef for handling mapDeltas in the mempool..

Rebase to see if test is fixed?

Jul 20 2018, 17:23
schancel planned changes to D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.
Jul 20 2018, 16:54

Jul 19 2018

Herald added a reviewer for D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs: Restricted Project.
Jul 19 2018, 20:18

Jul 18 2018

schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Rebase

Jul 18 2018, 22:15
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

fuuuuuu

Jul 18 2018, 22:14
schancel updated the summary of D1480: Tweak UTXO weight based agreed suggested costs.
Jul 18 2018, 21:32
schancel updated the diff for D1480: Tweak UTXO weight based agreed suggested costs.

Rebase with lower fee

Jul 18 2018, 21:29
schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

rebase

Jul 18 2018, 21:02
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Address feedback

Jul 18 2018, 20:59
schancel updated the diff for D1486: Use a modified size for transaction minimum fee calculation..

Rebase

Jul 18 2018, 19:15
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Address feedback

Jul 18 2018, 19:13
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Fix fee heuristics

Jul 18 2018, 17:11
schancel reclaimed D1561: [qa] change bip68 sequence to use calculate_fee.
Jul 18 2018, 16:32
schancel abandoned D1561: [qa] change bip68 sequence to use calculate_fee.
Jul 18 2018, 16:31
schancel added a comment to D1561: [qa] change bip68 sequence to use calculate_fee.

Okay, so the issue is the unsigned transaction is significantly smaller than the signed version. Adding a heuristic to get it to an equivalent or larger billable size when unsigned.

Jul 18 2018, 01:11

Jul 16 2018

schancel accepted D1564: Add a flag to activate OP_CHECKDATASIG.
Jul 16 2018, 16:46
schancel accepted D1563: Add CHECKDATASIG opcode..
Jul 16 2018, 16:41
schancel accepted D1556: vout parameter check in createrawtransaction is confused with missing & type_error..
Jul 16 2018, 16:39

Jul 13 2018

schancel planned changes to D1561: [qa] change bip68 sequence to use calculate_fee.

Something is still not right here. Trying to get to the bottom of this.

Jul 13 2018, 03:13

Jul 12 2018

schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Remove extraneous log message

Jul 12 2018, 23:40
schancel updated the diff for D1561: [qa] change bip68 sequence to use calculate_fee.

Finally done

Jul 12 2018, 22:18
schancel updated the diff for D1383: Create a typedef for handling mapDeltas in the mempool..

Change name of parameter back to mapDeltas

Jul 12 2018, 18:38
schancel requested changes to D554: Change default for key fee transactions policies.
Jul 12 2018, 18:28
schancel accepted D1431: Added error message when logging on categories NONE and ALL.
Jul 12 2018, 18:26
schancel accepted D1555: Added test for CBlockIndexWorkComparator.
Jul 12 2018, 18:26
schancel requested changes to D1470: Add gitian-sigs path and description to use it.
Jul 12 2018, 18:20
schancel added inline comments to D1470: Add gitian-sigs path and description to use it.
Jul 12 2018, 18:20
schancel requested changes to D1556: vout parameter check in createrawtransaction is confused with missing & type_error..

Seems like a good change. However, please fix the code style as per what I suggested. Just check for null first.

Jul 12 2018, 18:18
Herald added a reviewer for D1561: [qa] change bip68 sequence to use calculate_fee: Restricted Project.
Jul 12 2018, 18:16

Jul 11 2018

schancel accepted D1528: Update ApplyBlockUndo to be able to undo out of order blocks..
Jul 11 2018, 22:15
schancel accepted D1469: Introduce the concept of parked chain..
Jul 11 2018, 22:14
schancel accepted D1529: Implement canonical transaction ordering..
Jul 11 2018, 19:26

Jul 10 2018

schancel committed rABC815bd4800dcc: [qa] change abandonconflict to explicitly calculate fees (authored by schancel).
[qa] change abandonconflict to explicitly calculate fees
Jul 10 2018, 23:45
schancel closed D1552: [qa] change abandonconflict to explicitly calculate fees.
Jul 10 2018, 23:45
schancel updated the diff for D1552: [qa] change abandonconflict to explicitly calculate fees.

rebase to master

Jul 10 2018, 20:28