Page MenuHomePhabricator
Feed All Stories

Jan 17 2020

Fabien accepted D5000: Note intention of timing sidechannel freeness..
Jan 17 2020, 15:38
Fabien accepted D4999: Guard memcmp in tests against mixed size inputs..
Jan 17 2020, 15:36
Fabien accepted D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.
Jan 17 2020, 15:33
Fabien accepted D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.
Jan 17 2020, 15:24
Fabien accepted D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.
Jan 17 2020, 15:20
Fabien accepted D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).
Jan 17 2020, 15:18
Fabien accepted D4994: Pass scalar by reference in secp256k1_wnaf_const().
Jan 17 2020, 15:15
deadalnix accepted D4961: [CMAKE] Add a check_linker_flag function.
Jan 17 2020, 15:07
deadalnix committed rABCbaaa4fa3e1d8: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build (authored by Gregory Maxwell <greg@xiph.org>).
Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
Jan 17 2020, 14:50
deadalnix closed D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.
Jan 17 2020, 14:50
Fabien accepted D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.
Jan 17 2020, 14:46
teamcity added a comment to D4994: Pass scalar by reference in secp256k1_wnaf_const().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:37
deadalnix created D5000: Note intention of timing sidechannel freeness..
Jan 17 2020, 14:29
teamcity added a comment to D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:29
deadalnix created D4999: Guard memcmp in tests against mixed size inputs..
Jan 17 2020, 14:28
teamcity added a comment to D4991: Use size_t shifts when computing a size_t.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:26
deadalnix created D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.
Jan 17 2020, 14:26
teamcity added a comment to D4993: Clear a copied secret key after negation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:24
teamcity added a comment to D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:23
teamcity added a comment to D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:22
teamcity added a comment to D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:22
teamcity added a comment to D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:19
teamcity added a comment to D4987: Fix integer overflow in ecmult_multi_var when n is large.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:19
teamcity added a comment to D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:19
deadalnix closed D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..
Jan 17 2020, 14:19
deadalnix committed rABCa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values. (authored by Gregory Maxwell <greg@xiph.org>).
Switch x86_64 asm to use "i" instead of "n" for immediate values.
Jan 17 2020, 14:19
teamcity added a comment to D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:18
teamcity added a comment to D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:18
teamcity added a comment to D4994: Pass scalar by reference in secp256k1_wnaf_const().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:17
deadalnix committed rABC850100d894fa: Allow field_10x26_arm.s to compile for ARMv7 architecture (authored by Roman Zeyde <me@romanzey.de>).
Allow field_10x26_arm.s to compile for ARMv7 architecture
Jan 17 2020, 14:17
deadalnix closed D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.
Jan 17 2020, 14:16
teamcity added a comment to D4993: Clear a copied secret key after negation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:14
teamcity added a comment to D4985: Add trivial ecmult_multi algorithm which does not require a scratch space.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:14
teamcity added a comment to D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:14
teamcity added a comment to D4990: travis: Remove unused sudo:false.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:14
deadalnix committed rABC3edf3fa19742: Clear a copied secret key after negation (authored by Seonpyo Kim <spkim@kodebox.io>).
Clear a copied secret key after negation
Jan 17 2020, 14:13
deadalnix closed D4993: Clear a copied secret key after negation.
Jan 17 2020, 14:13
teamcity added a comment to D4991: Use size_t shifts when computing a size_t.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:12
deadalnix committed rABCd3afd5bacd84: Use size_t shifts when computing a size_t (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use size_t shifts when computing a size_t
Jan 17 2020, 14:11
deadalnix closed D4991: Use size_t shifts when computing a size_t.
Jan 17 2020, 14:11
teamcity added a comment to D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 14:10
teamcity added a comment to D4990: travis: Remove unused sudo:false.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:10
deadalnix committed rABCfd66a562632e: Fix integer overflow in ecmult_multi_var when n is large (authored by Jonas Nick <jonasd.nick@gmail.com>).
Fix integer overflow in ecmult_multi_var when n is large
Jan 17 2020, 14:10
deadalnix closed D4987: Fix integer overflow in ecmult_multi_var when n is large.
Jan 17 2020, 14:09
deadalnix committed rABC69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space (authored by Jonas Nick <jonasd.nick@gmail.com>).
Add trivial ecmult_multi algorithm which does not require a scratch space
Jan 17 2020, 14:08
teamcity added a comment to D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:08
deadalnix closed D4985: Add trivial ecmult_multi algorithm which does not require a scratch space.
Jan 17 2020, 14:08
deadalnix committed rABC1921c4972fd5: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. (authored by Gregory Maxwell <greg@xiph.org>).
Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
Jan 17 2020, 14:06
deadalnix closed D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing..
Jan 17 2020, 14:06
teamcity added a comment to D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing..
Jan 17 2020, 14:06
teamcity added a comment to D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:06
Harbormaster failed remote builds in B9009: Diff 15573 for D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.!
Jan 17 2020, 14:06
deadalnix committed rABC5079f3218b77: travis: Remove unused sudo:false (authored by MarcoFalke <falke.marco@gmail.com>).
travis: Remove unused sudo:false
Jan 17 2020, 14:05
deadalnix closed D4990: travis: Remove unused sudo:false.
Jan 17 2020, 14:05
Fabien accepted D4993: Clear a copied secret key after negation.
Jan 17 2020, 14:05
teamcity added a comment to D4987: Fix integer overflow in ecmult_multi_var when n is large.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:05
teamcity added a comment to D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:03
Fabien accepted D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.

I have a few Cortex-M boards here, I should try to build something with these one day.

Jan 17 2020, 14:00
teamcity added a comment to D4985: Add trivial ecmult_multi algorithm which does not require a scratch space.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 14:00
Fabien accepted D4991: Use size_t shifts when computing a size_t.
Jan 17 2020, 13:49
Fabien accepted D4990: travis: Remove unused sudo:false.

I love your test plan.

Jan 17 2020, 13:45
Fabien accepted D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..
Jan 17 2020, 13:44
Fabien accepted D4987: Fix integer overflow in ecmult_multi_var when n is large.
Jan 17 2020, 13:34
Fabien accepted D4985: Add trivial ecmult_multi algorithm which does not require a scratch space.
Jan 17 2020, 13:28
Fabien accepted D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing..
Jan 17 2020, 13:17
deadalnix created D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.
Jan 17 2020, 13:06
deadalnix created D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.
Jan 17 2020, 13:00
deadalnix created D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).
Jan 17 2020, 12:52
deadalnix created D4994: Pass scalar by reference in secp256k1_wnaf_const().
Jan 17 2020, 12:29
deadalnix created D4993: Clear a copied secret key after negation.
Jan 17 2020, 12:27
deadalnix created D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.
Jan 17 2020, 12:24
deadalnix created D4991: Use size_t shifts when computing a size_t.
Jan 17 2020, 12:22
deadalnix created D4990: travis: Remove unused sudo:false.
Jan 17 2020, 12:20
deadalnix created D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..
Jan 17 2020, 12:18
deadalnix created D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.
Jan 17 2020, 12:15
deadalnix created D4987: Fix integer overflow in ecmult_multi_var when n is large.
Jan 17 2020, 12:13
deadalnix created D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing..
Jan 17 2020, 12:08
deadalnix created D4985: Add trivial ecmult_multi algorithm which does not require a scratch space.
Jan 17 2020, 12:05
deadalnix committed rABCb2d3f9c8b803: Summarize build options in configure script (authored by Evan Klitzke <evan@eklitzke.org>).
Summarize build options in configure script
Jan 17 2020, 11:58
deadalnix closed D4981: Summarize build options in configure script.
Jan 17 2020, 11:58
deadalnix committed rABC59ef20ed1cc1: Portability fix for the configure scripts generated (authored by Pierre Pronchery <khorben@defora.org>).
Portability fix for the configure scripts generated
Jan 17 2020, 11:55
deadalnix closed D4978: Portability fix for the configure scripts generated.
Jan 17 2020, 11:55
deadalnix committed rABC4992216f3f0e: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call. (authored by Phillip Mienk <mienkphi@gmail.com>).
Correct order of libs returned on pkg-config --libs --static libsecp256k1 call.
Jan 17 2020, 11:51
deadalnix closed D4979: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call..
Jan 17 2020, 11:51
deadalnix committed rABC4f96122dfc29: Eliminate scratch memory used when generating contexts (authored by Andrew Poelstra <apoelstra@wpsoftware.net>).
Eliminate scratch memory used when generating contexts
Jan 17 2020, 11:50
deadalnix closed D4972: Eliminate scratch memory used when generating contexts.
Jan 17 2020, 11:49
deadalnix committed rABC72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls. (authored by Russell O'Connor <roconnor@blockstream.io>).
Optimize secp256k1_fe_normalize_weak calls.
Jan 17 2020, 11:47
deadalnix closed D4974: Optimize secp256k1_fe_normalize_weak calls..
Jan 17 2020, 11:47
deadalnix committed rABCe548e945cb53: Assorted minor corrections (authored by Russell O'Connor <roconnor@blockstream.io>).
Assorted minor corrections
Jan 17 2020, 11:46
deadalnix closed D4975: Assorted minor corrections.
Jan 17 2020, 11:46
deadalnix committed rABC0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static… (authored by Russell O'Connor <roconnor@blockstream.io>).
Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static…
Jan 17 2020, 11:44
deadalnix closed D4977: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;.
Jan 17 2020, 11:44
deadalnix committed rABCc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias. (authored by Russell O'Connor <roconnor@blockstream.io>).
secp256k1_fe_sqrt: Verify that the arguments don't alias.
Jan 17 2020, 11:43
deadalnix closed D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias..
Jan 17 2020, 11:42
deadalnix committed rABC1899cc11d7e8: Make randomization of a non-signing context a noop (authored by Tim Ruffing <crypto@timruffing.de>).
Make randomization of a non-signing context a noop
Jan 17 2020, 11:41
deadalnix closed D4980: Make randomization of a non-signing context a noop.
Jan 17 2020, 11:41
deadalnix committed rABC0cf6dd3618ab: add static context object which has no capabilities (authored by Andrew Poelstra <apoelstra@wpsoftware.net>).
add static context object which has no capabilities
Jan 17 2020, 11:40
deadalnix closed D4971: add static context object which has no capabilities.
Jan 17 2020, 11:40
deadalnix committed rABC50ce5c795ddb: Fix algorithm selection in bench_ecmult (authored by Jonas Nick <jonasd.nick@gmail.com>).
Fix algorithm selection in bench_ecmult
Jan 17 2020, 11:38
deadalnix closed D4982: Fix algorithm selection in bench_ecmult.
Jan 17 2020, 11:38