Page MenuHomePhabricator
Feed All Stories

Mar 30 2020

Fabien created D5601: depends: Add 'make clean' and 'make clean-all' rules.
Mar 30 2020, 11:29
teamcity added a comment to D5600: [tests] Remove rpc_zmq.py.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 10:26
teamcity added a comment to D5600: [tests] Remove rpc_zmq.py.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 10:16
teamcity added a comment to D5600: [tests] Remove rpc_zmq.py.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 30 2020, 10:16
teamcity updated the summary of D5600: [tests] Remove rpc_zmq.py.
Mar 30 2020, 10:16
Fabien created D5600: [tests] Remove rpc_zmq.py.
Mar 30 2020, 10:16
teamcity added a comment to D5599: depends: zeromq 4.2.3.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 10:04
teamcity added a comment to D5599: depends: zeromq 4.2.3.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 09:55
teamcity added a comment to D5599: depends: zeromq 4.2.3.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 30 2020, 09:55
teamcity updated the summary of D5599: depends: zeromq 4.2.3.
Mar 30 2020, 09:55
Fabien created D5599: depends: zeromq 4.2.3.
Mar 30 2020, 09:55
teamcity added a comment to D5598: [SECP256K1] Travis Don't run the constant time check with java tests.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 08:24
teamcity added a comment to D5598: [SECP256K1] Travis Don't run the constant time check with java tests.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 08:15
Fabien created D5598: [SECP256K1] Travis Don't run the constant time check with java tests.
Mar 30 2020, 08:15
Fabien accepted D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.
Mar 30 2020, 07:48

Mar 29 2020

teamcity added a comment to D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 29 2020, 19:50
teamcity added a comment to D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 29 2020, 19:37
deadalnix created D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.
Mar 29 2020, 19:37
deadalnix committed rABC1147a5277298: Constant-time behaviour test using valgrind memtest. (authored by Gregory Maxwell <greg@xiph.org>).
Constant-time behaviour test using valgrind memtest.
Mar 29 2020, 18:40
deadalnix closed D5580: Constant-time behaviour test using valgrind memtest..
Mar 29 2020, 18:40
Fabien accepted D5580: Constant-time behaviour test using valgrind memtest..
Mar 29 2020, 18:28
teamcity added a comment to D5580: Constant-time behaviour test using valgrind memtest..

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 29 2020, 16:14
teamcity added a comment to D5580: Constant-time behaviour test using valgrind memtest..

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 29 2020, 16:02
deadalnix updated the diff for D5580: Constant-time behaviour test using valgrind memtest..

Update travis strategy

Mar 29 2020, 16:02
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

I spotted at least one discrepancy. This is review hell. Generating the list of help for all RPC before and after that patch and providing a diff is the only way to go here.

Mar 29 2020, 15:31

Mar 28 2020

jasonbcox committed rABC3b7267b39b6b: Bump version to 0.21.4 (authored by jasonbcox).
Bump version to 0.21.4
Mar 28 2020, 00:03
jasonbcox closed D5591: Bump version to 0.21.4.
Mar 28 2020, 00:03

Mar 27 2020

nakihito planned changes to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

Going to have to go through some dependencies to remove the assert.

Mar 27 2020, 23:24
jasonbcox accepted D5380: [seeder] Require good seeds to have latest checkpoint.
Mar 27 2020, 20:58
Fabien committed rABC179fdb728aaf: [depends] ZeroMQ 4.2.2 (authored by fanquake <fanquake@gmail.com>).
[depends] ZeroMQ 4.2.2
Mar 27 2020, 17:29
Fabien closed D5574: [depends] ZeroMQ 4.2.2.
Mar 27 2020, 17:29
Fabien committed rABCd45a3e8756de: [CMAKE] Pull zmq windows library dependencies in the find module (authored by Fabien).
[CMAKE] Pull zmq windows library dependencies in the find module
Mar 27 2020, 17:28
Fabien closed D5577: [CMAKE] Pull zmq windows library dependencies in the find module.
Mar 27 2020, 17:28
Fabien committed rABC28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module (authored by Fabien).
[CMAKE] Pull miniupnpc windows library dependencies in the find module
Mar 27 2020, 17:27
Fabien closed D5575: [CMAKE] Pull miniupnpc windows library dependencies in the find module.
Mar 27 2020, 17:27
Fabien committed rABCb511395ba352: [CMAKE] Pass the interface linked libraries to find_component (authored by Fabien).
[CMAKE] Pass the interface linked libraries to find_component
Mar 27 2020, 17:26
Fabien closed D5576: [CMAKE] Pass the interface linked libraries to find_component.
Mar 27 2020, 17:26
Fabien accepted D5591: Bump version to 0.21.4.
Mar 27 2020, 17:25
teamcity added a comment to D5591: Bump version to 0.21.4.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 16:34
teamcity added a comment to D5591: Bump version to 0.21.4.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 16:09
jasonbcox created D5591: Bump version to 0.21.4.
Mar 27 2020, 16:09
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:44
Fabien committed rABCe409be178eae: Disable thread_local for i686-mingw (authored by Fabien).
Disable thread_local for i686-mingw
Mar 27 2020, 15:36
Fabien closed D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 15:36
Fabien committed rABCe32abdcf10e9: [SECP256K1] Turn off ASM by default on target with no ASM support (authored by Fabien).
[SECP256K1] Turn off ASM by default on target with no ASM support
Mar 27 2020, 15:35
Fabien closed D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:35
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:34
Fabien updated the diff for D5587: Disable thread_local for i686-mingw.

Add missing comment.

Mar 27 2020, 15:34
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Mar 27 2020, 15:31
jasonbcox accepted D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 15:30
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:28
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:28
deadalnix committed rABC98369fa6fd64: [secp256k1] Install all packages in travis (authored by deadalnix).
[secp256k1] Install all packages in travis
Mar 27 2020, 15:28
deadalnix closed D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 15:27
Fabien accepted D5589: [secp256k1] Install all packages in travis.

See https://travis-ci.org/github/Fabcien/secp256k1/builds/667740396

Mar 27 2020, 15:22
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:18
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:18
Fabien updated the diff for D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Remove obsolete if available from docstring.

Mar 27 2020, 15:18
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make sure that the opposite of no is indeed gmp.

Mar 27 2020, 15:18
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Mar 27 2020, 15:13
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:13
deadalnix retitled D5589: [secp256k1] Install all packages in travis from [secp256k1] Install all packes in travis to [secp256k1] Install all packages in travis.
Mar 27 2020, 15:10
deadalnix accepted D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:09
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Mar 27 2020, 15:08
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Mar 27 2020, 15:05
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

Mar 27 2020, 15:05
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Mar 27 2020, 15:04
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:03
Fabien created D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:03
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 14:48
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 14:39
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 14:31
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make bignum explicitely yes and remove install directive

Mar 27 2020, 14:31
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 14:27
deadalnix created D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 14:26
Fabien requested changes to D5580: Constant-time behaviour test using valgrind memtest..
Mar 27 2020, 14:12
Fabien committed rABCb6265e2acb6c: [SECP256K1] Fix Travis missing ninja (authored by Fabien).
[SECP256K1] Fix Travis missing ninja
Mar 27 2020, 13:56
teamcity added a comment to D5588: [SECP256K1] Fix Travis missing ninja.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 13:56
Fabien closed D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:56
deadalnix accepted D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:55
teamcity added a comment to D5588: [SECP256K1] Fix Travis missing ninja.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 13:46
Fabien created D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:46
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

I'm sorry, but I don't buy the finalization argument, mostly because it's not an argument. I've seen enough cultish behavior in this industry to know people will say you shouldn't do X or must do Y the Z way with absolutely no reason whatsoever and it often turns out to be a bad idea. If there is a reason to not do it, then people should be able to state it and we should be able to assert why it applies or not to our current situation. Every time someone brings up that this is the "the way" without providing a proper rationale, this is only a stronger reason to dismiss this concern.

Mar 27 2020, 13:34
Fabien requested changes to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Mar 27 2020, 13:25
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 13:09
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 12:56
teamcity updated the summary of D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 12:56
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 27 2020, 12:56
Fabien created D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 12:56
abc-bot committed rABC5da5396e8d0d: [Automated] Update manpages (authored by abc-bot).
[Automated] Update manpages
Mar 27 2020, 01:21
jasonbcox committed rABCd9f4298eca5b: [test_runner] Fix result collector variable shadowing (authored by jasonbcox).
[test_runner] Fix result collector variable shadowing
Mar 27 2020, 01:13
jasonbcox closed D5584: [test_runner] Fix result collector variable shadowing.
Mar 27 2020, 01:13
jasonbcox committed rABCe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon() (authored by jasonbcox).
[test_runner] Use the daemon property directly instead of setDaemon()
Mar 27 2020, 01:13
jasonbcox closed D5583: [test_runner] Use the daemon property directly instead of setDaemon().
Mar 27 2020, 01:12
jasonbcox committed rABC1e2aab4a99d7: Add missing softforks help text to getblockchaininfo (authored by jasonbcox).
Add missing softforks help text to getblockchaininfo
Mar 27 2020, 01:12
jasonbcox closed D5581: Add missing softforks help text to getblockchaininfo.
Mar 27 2020, 01:12
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 00:32
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 00:22
teamcity updated the summary of D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Mar 27 2020, 00:22
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 27 2020, 00:22