Added unit tests.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 25 2020
Apr 25 2020
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
No need to break this up.
No need to break this up.
Apr 24 2020
Apr 24 2020
Rename IsGood() to IsReliable()
Fixed formatting.
nakihito committed rABC6cc421370619: Pass zmq RPC results and examples to RPCHelpMan (authored by nakihito).
Pass zmq RPC results and examples to RPCHelpMan
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Passed more information to CSeederNode. Moved banning logic to DetermineBan().
Apr 23 2020
Apr 23 2020
nakihito committed rABCae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan (authored by nakihito).
Pass rpc/server RPC results and examples to RPCHelpMan
Added comments, fixed naming, and increased unit testing coverage.
Restored newline.
nakihito committed rABCe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan (authored by nakihito).
Pass rpc/abc RPC Results and Examples to RPCHelpMan
Apr 22 2020
Apr 22 2020
nakihito requested changes to D5811: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists..
QT test plan?
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Rebased.
Remove TestNode()
nakihito retitled D5800: Remove TestNode() from Fully pass in CServiceResult to TestNode() and make it void to Remove TestNode().
Removed TestNode() completely.
nakihito updated the summary of D5686: Implement banning logic for Seeder for nodes on the wrong chain.
nakihito updated the summary of D5686: Implement banning logic for Seeder for nodes on the wrong chain.
nakihito updated the summary of D5686: Implement banning logic for Seeder for nodes on the wrong chain.
See D5809 and others to follow.
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Separated the TestNode() refactor out to its own diff (D5800).
Apr 20 2020
Apr 20 2020
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Folded information into fReliable to limit the amount of CAddrInfo that is exposed.
nakihito updated the diff for D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Pushed banning logic into TestNode().
nakihito committed rABC43d44b2e899b: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan
nakihito committed rABCf7690c0f382b: Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc
Reproduction is difficult~ish. I can add logs of this bug using one of my testing branches.
Rebased.
Apr 18 2020
Apr 18 2020
Let all returns fall through except Finished. Make logic more robust to account for some out-of-order messages. Update unit tests to reflect changes.
Apr 17 2020
Apr 17 2020
Restructured code for handling HEADERS messages.
nakihito requested review of D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Apr 16 2020
Apr 16 2020
nakihito requested review of D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
nakihito updated the summary of D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
nakihito updated the test plan for D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
nakihito updated the test plan for D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
nakihito planned changes to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
nakihito updated the diff for D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Rebased of D5746 to remove assert.
nakihito updated the summary of D5746: Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc.
nakihito committed rABCc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15943: tests: Fail if RPC has been added without tests
Apr 15 2020
Apr 15 2020
nakihito committed rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names (authored by nakihito).
Complete PR14796 by cleaning up some old functions and names
Rebase.
nakihito committed rABCa0950966fd85: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to… (authored by nakihito).
Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to…
nakihito updated the diff for D5722: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan.
Rebase.
nakihito committed rABC245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan (authored by nakihito).
Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan