Page MenuHomePhabricator
Feed Advanced Search

Sep 23 2020

jasonbcox closed D7543: Merge #13924: tests: Simplify comparison in rpc_blockchain.py.
Sep 23 2020, 23:23
jasonbcox requested review of D7544: Add heading to release notes template.
Sep 23 2020, 22:48
jasonbcox requested review of D7543: Merge #13924: tests: Simplify comparison in rpc_blockchain.py.
Sep 23 2020, 22:10
jasonbcox accepted D7542: [Backport]test: add BIP37 'filterclear' test to p2p_filter.py.
Sep 23 2020, 22:09
jasonbcox committed rABC655d9359a6e4: [land-bot] Introduce an autogen amendment step and update version numbers using… (authored by jasonbcox).
[land-bot] Introduce an autogen amendment step and update version numbers using…
Sep 23 2020, 00:32
jasonbcox closed D7527: [land-bot] Introduce an autogen amendment step and update version numbers using it.
Sep 23 2020, 00:32

Sep 22 2020

jasonbcox updated the diff for D7527: [land-bot] Introduce an autogen amendment step and update version numbers using it.

Good call on the priority naming. Let's start doing that now. Although it's hard to tell what the
priority will be, so let's start in the middle.

Sep 22 2020, 20:01
jasonbcox added inline comments to D7527: [land-bot] Introduce an autogen amendment step and update version numbers using it.
Sep 22 2020, 19:55
jasonbcox requested review of D7527: [land-bot] Introduce an autogen amendment step and update version numbers using it.
Sep 22 2020, 18:56
jasonbcox committed rABC309ea9405477: Decouple archiving release notes from automated commits pipeline (authored by jasonbcox).
Decouple archiving release notes from automated commits pipeline
Sep 22 2020, 17:06
jasonbcox closed D7505: Decouple archiving release notes from automated commits pipeline.
Sep 22 2020, 17:06
jasonbcox committed rABC39063a6f203f: Decouple updating timings from automated commit pipeline (authored by jasonbcox).
Decouple updating timings from automated commit pipeline
Sep 22 2020, 16:49
jasonbcox closed D7504: Decouple updating timings from automated commit pipeline.
Sep 22 2020, 16:49
jasonbcox requested review of D7505: Decouple archiving release notes from automated commits pipeline.

This is a move and cleanup in preparation for doing it correctly. See the summary.

Sep 22 2020, 16:20
jasonbcox updated the diff for D7504: Decouple updating timings from automated commit pipeline.

Rebase

Sep 22 2020, 16:17
jasonbcox requested review of D7505: Decouple archiving release notes from automated commits pipeline.
Sep 22 2020, 00:14

Sep 21 2020

jasonbcox committed rABC9119eef6b046: Decouple updating seeds from automated commits pipeline (authored by jasonbcox).
Decouple updating seeds from automated commits pipeline
Sep 21 2020, 23:55
jasonbcox closed D7501: Decouple updating seeds from automated commits pipeline.
Sep 21 2020, 23:55
jasonbcox committed rABC7ca857bdffff: Decouple updating chainparams from automated commits pipeline (authored by jasonbcox).
Decouple updating chainparams from automated commits pipeline
Sep 21 2020, 23:54
jasonbcox closed D7500: Decouple updating chainparams from automated commits pipeline.
Sep 21 2020, 23:54
jasonbcox committed rABC8f754a4d5734: Add a check for unstaged changes when generating automated commits (authored by jasonbcox).
Add a check for unstaged changes when generating automated commits
Sep 21 2020, 23:53
jasonbcox closed D7481: Add a check for unstaged changes when generating automated commits.
Sep 21 2020, 23:53
jasonbcox requested review of D7504: Decouple updating timings from automated commit pipeline.
Sep 21 2020, 23:51
jasonbcox abandoned D7479: [land-bot] Add an entry point for the land bot.
Sep 21 2020, 23:37
jasonbcox abandoned D7503: [land-bot] Move apply-revision to patch recipes.

Clearly this was possible with D7490 already and nothing really needs to be done. It can be argued that moving it to patch-recipes isn't even the right place anyway. Sorry for the noise.

Sep 21 2020, 23:37
jasonbcox requested review of D7503: [land-bot] Move apply-revision to patch recipes.
Sep 21 2020, 23:04
jasonbcox requested changes to D7499: test: allows test_runner command line to receive parameters for each test.

The test plan does not test the supposed change, nor does it test the wildcard behavior that differs from the original PR.

Sep 21 2020, 20:34
jasonbcox requested review of D7501: Decouple updating seeds from automated commits pipeline.
Sep 21 2020, 20:31
jasonbcox updated the summary of D7481: Add a check for unstaged changes when generating automated commits.
Sep 21 2020, 18:05
jasonbcox updated the diff for D7481: Add a check for unstaged changes when generating automated commits.

Cleanup unneeded commit parent logic

Sep 21 2020, 18:02
jasonbcox requested review of D7500: Decouple updating chainparams from automated commits pipeline.
Sep 21 2020, 17:55
jasonbcox planned changes to D7481: Add a check for unstaged changes when generating automated commits.
Sep 21 2020, 17:53
jasonbcox added inline comments to D7480: [land-bot] Cleanup unnecessary revision acceptable check.
Sep 21 2020, 17:25
jasonbcox committed rABC35d9cfa9751c: [buildbot] Strip out commonly used separators when detecting backports in diff… (authored by jasonbcox).
[buildbot] Strip out commonly used separators when detecting backports in diff…
Sep 21 2020, 17:14
jasonbcox closed D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sep 21 2020, 17:14
jasonbcox committed rABCc3337e007433: Decouple AUR patch recipe from the rest of the automated commits pipeline (authored by jasonbcox).
Decouple AUR patch recipe from the rest of the automated commits pipeline
Sep 21 2020, 17:03
jasonbcox closed D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.
Sep 21 2020, 17:03
jasonbcox committed rABCf9c450dbf502: [land-bot] Bail early if there's nothing to land (authored by jasonbcox).
[land-bot] Bail early if there's nothing to land
Sep 21 2020, 16:52
jasonbcox closed D5808: [land-bot] Bail early if there's nothing to land.
Sep 21 2020, 16:52

Sep 19 2020

jasonbcox committed rABC9acea42cd09f: [land-bot] Fix git HEAD after checking revision (authored by jasonbcox).
[land-bot] Fix git HEAD after checking revision
Sep 19 2020, 00:12
jasonbcox closed D7478: [land-bot] Fix git HEAD after checking revision.
Sep 19 2020, 00:12
jasonbcox requested review of D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.

I don't think you read the summary. All of these variants are re-written to appear as the first variant, ensuring that these are both greppable and linked.

Sep 19 2020, 00:11
jasonbcox updated the summary of D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.
Sep 19 2020, 00:08
jasonbcox requested review of D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.
Sep 19 2020, 00:07

Sep 18 2020

jasonbcox requested review of D5808: [land-bot] Bail early if there's nothing to land.
Sep 18 2020, 23:58
jasonbcox planned changes to D5808: [land-bot] Bail early if there's nothing to land.
Sep 18 2020, 23:55
jasonbcox added inline comments to D5808: [land-bot] Bail early if there's nothing to land.
Sep 18 2020, 23:38
jasonbcox retitled D5808: [land-bot] Bail early if there's nothing to land from [land-patch] Bail early if there's nothing to land to [land-bot] Bail early if there's nothing to land.
Sep 18 2020, 23:36
jasonbcox updated the diff for D5808: [land-bot] Bail early if there's nothing to land.

Rebase

Sep 18 2020, 23:33
jasonbcox committed rABCd7bea469527a: Use heredoc for outputting help text in automated commit scripts (authored by jasonbcox).
Use heredoc for outputting help text in automated commit scripts
Sep 18 2020, 23:03
jasonbcox closed D7482: Use heredoc for outputting help text in automated commit scripts.
Sep 18 2020, 23:03
jasonbcox requested review of D7481: Add a check for unstaged changes when generating automated commits.
Sep 18 2020, 22:36
jasonbcox accepted D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
Sep 18 2020, 20:12
jasonbcox accepted D7485: fix MarkDown links and code formatting.
Sep 18 2020, 19:08
jasonbcox requested changes to D7486: update outdated links related to UAHF and use explicit MarkDown syntax.

I noticed your test plan is rather complex and duplicates a lot of the logic in scripts/fetch_documentation.sh in the website repo. Consider improving it so it can take a local target instead of always pulling from the internet. This should come in a separate diff of course.

Sep 18 2020, 18:52
jasonbcox requested changes to D7485: fix MarkDown links and code formatting.
Sep 18 2020, 18:48
jasonbcox accepted D7483: [Backport] Fix Markdown formatting issues in init.md.
Sep 18 2020, 18:47
jasonbcox updated the summary of D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sep 18 2020, 18:45
jasonbcox updated the diff for D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.

Match more cases

Sep 18 2020, 18:45
jasonbcox planned changes to D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sep 18 2020, 18:41
jasonbcox updated the summary of D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sep 18 2020, 18:33
jasonbcox requested review of D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sep 18 2020, 18:32
jasonbcox accepted D7484: [LINTER] Accept hard line breaks in markdown files.
Sep 18 2020, 18:21
jasonbcox abandoned D7488: [buildbot] Explicitly set the build agent pool for TSAN builds.
Sep 18 2020, 17:33
jasonbcox planned changes to D7488: [buildbot] Explicitly set the build agent pool for TSAN builds.
Sep 18 2020, 17:07
jasonbcox requested review of D7488: [buildbot] Explicitly set the build agent pool for TSAN builds.
Sep 18 2020, 17:07
jasonbcox updated the diff for D7478: [land-bot] Fix git HEAD after checking revision.

Add explicit check that HEAD has no changes from master

Sep 18 2020, 16:26
jasonbcox requested changes to D7484: [LINTER] Accept hard line breaks in markdown files.

I don't think this makes sense. Even if markdown supports trailing whitespace as a line break, it doesn't mean it's a good idea. Consider:

  • Not linting this will now allow accidental trailing whitespaces.
  • Trailing whitespace does not render well in all IDEs/editors.
  • Intentional line breaks should be obvious, which trailing whitespace are not.
Sep 18 2020, 15:52

Sep 17 2020

jasonbcox updated the test plan for D7480: [land-bot] Cleanup unnecessary revision acceptable check.
Sep 17 2020, 21:45
jasonbcox updated the diff for D7480: [land-bot] Cleanup unnecessary revision acceptable check.

Rebase

Sep 17 2020, 21:45
jasonbcox updated the test plan for D7479: [land-bot] Add an entry point for the land bot.
Sep 17 2020, 21:44
jasonbcox updated the diff for D7479: [land-bot] Add an entry point for the land bot.

Rename the script to something more sensible

Sep 17 2020, 21:43
jasonbcox updated the test plan for D7479: [land-bot] Add an entry point for the land bot.
Sep 17 2020, 21:43
jasonbcox accepted D7477: Add missing release flag to the debian package build.
Sep 17 2020, 19:30
jasonbcox planned changes to D7479: [land-bot] Add an entry point for the land bot.
Sep 17 2020, 19:28
jasonbcox requested review of D7482: Use heredoc for outputting help text in automated commit scripts.
Sep 17 2020, 18:55
jasonbcox requested review of D7481: Add a check for unstaged changes when generating automated commits.
Sep 17 2020, 18:51
jasonbcox committed rABCda60e76e598d: [land-bot] Call land-patch when generating automated commits (authored by jasonbcox).
[land-bot] Call land-patch when generating automated commits
Sep 17 2020, 18:46
jasonbcox closed D7476: [land-bot] Call land-patch when generating automated commits.
Sep 17 2020, 18:45
jasonbcox requested review of D7480: [land-bot] Cleanup unnecessary revision acceptable check.
Sep 17 2020, 18:42
jasonbcox requested review of D7479: [land-bot] Add an entry point for the land bot.
Sep 17 2020, 18:35
jasonbcox requested review of D7478: [land-bot] Fix git HEAD after checking revision.
Sep 17 2020, 18:24
jasonbcox updated subscribers of D7476: [land-bot] Call land-patch when generating automated commits.

I' not sure why you would revert back other changes, there were not bad per se.

Sep 17 2020, 17:41
jasonbcox updated the summary of D7476: [land-bot] Call land-patch when generating automated commits.
Sep 17 2020, 17:02
jasonbcox retitled D7476: [land-bot] Call land-patch when generating automated commits from [land-bot] Remove all landing logic from automated-commits script to [land-bot] Call land-patch when generating automated commits.
Sep 17 2020, 17:02
jasonbcox updated the diff for D7476: [land-bot] Call land-patch when generating automated commits.

Remove all the refactoring and just call the land patch script

Sep 17 2020, 17:02
jasonbcox committed rABCe6059d542505: [land-bot] Split land bot logic into distinct scripts (authored by jasonbcox).
[land-bot] Split land bot logic into distinct scripts
Sep 17 2020, 16:36
jasonbcox closed D7467: [land-bot] Split land bot logic into distinct scripts.
Sep 17 2020, 16:36
jasonbcox added inline comments to D7467: [land-bot] Split land bot logic into distinct scripts.
Sep 17 2020, 16:35
jasonbcox committed rABC1a74941b7641: [land-bot] Split arc land into distinct parts in preparation for supporting non… (authored by jasonbcox).
[land-bot] Split arc land into distinct parts in preparation for supporting non…
Sep 17 2020, 16:33
jasonbcox closed D7455: [land-bot] Split arc land into distinct parts in preparation for supporting non-revision patches.
Sep 17 2020, 16:33
jasonbcox requested review of D7476: [land-bot] Call land-patch when generating automated commits.
Sep 17 2020, 15:59
jasonbcox requested review of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Sep 17 2020, 15:33
jasonbcox updated the summary of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Sep 17 2020, 15:33
jasonbcox requested review of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Sep 17 2020, 00:24
jasonbcox committed rABC7842514c4385: [land-bot] Use --nobranch for revisions by default (authored by jasonbcox).
[land-bot] Use --nobranch for revisions by default
Sep 17 2020, 00:01
jasonbcox closed D7466: [land-bot] Use --nobranch for revisions by default.
Sep 17 2020, 00:01
jasonbcox updated the test plan for D7467: [land-bot] Split land bot logic into distinct scripts.
Sep 17 2020, 00:00

Sep 16 2020

jasonbcox requested review of D7467: [land-bot] Split land bot logic into distinct scripts.
Sep 16 2020, 23:59
jasonbcox requested review of D7455: [land-bot] Split arc land into distinct parts in preparation for supporting non-revision patches.
Sep 16 2020, 23:14