Test coverage looks good and afaict the code is correct. I can't really review the API itself, I'm not in the loop regarding the intended use cases.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 9 2024
Apr 9 2024
Apr 8 2024
Apr 8 2024
Remove unused CDataStream methods
Apr 5 2024
Apr 5 2024
PiRK committed rABCe6d49c9dae4f: [electrum] push notification for release 5.2.12 (authored by PiRK).
[electrum] push notification for release 5.2.12
PiRK committed rABC23ac3f84c939: Generalize/simplify VectorReader into SpanReader (authored by Pieter Wuille <pieter@wuille.net>).
Generalize/simplify VectorReader into SpanReader
scripted-diff: Move bloom to src/common
PiRK committed rABCae2feb449f1d: bloom: use Span instead of std::vector for `insert` and `contains` (authored by William Casarin <jb55@jb55.com>).
bloom: use Span instead of std::vector for `insert` and `contains`
PiRK updated the diff for D15901: bloom: use Span instead of std::vector for `insert` and `contains`.
rebase
In D15901#359396, @teamcity wrote:Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.Failed tests logs:
====== Bitcoin ABC functional tests: abc_rpc_mocktime.py ======
PiRK requested review of D15901: bloom: use Span instead of std::vector for `insert` and `contains`.
Apr 4 2024
Apr 4 2024
PiRK committed rABCd97242ade07e: span: Add std::byte helpers (authored by MarcoFalke <falke.marco@gmail.com>).
span: Add std::byte helpers
PiRK committed rABC5ad88878f816: refactor: Use ignore helper when unserializing an invalid pubkey (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Use ignore helper when unserializing an invalid pubkey
PiRK committed rABCd88558168af1: Use value_type in CDataStream where possible (authored by MarcoFalke <falke.marco@gmail.com>).
Use value_type in CDataStream where possible
PiRK committed rABC1c890885e27e: [electrum] build: fix incompatible dependencies (authored by PiRK).
[electrum] build: fix incompatible dependencies
Apr 3 2024
Apr 3 2024
PiRK committed rABC35b8201a4d31: [electrum] Bump version to 5.2.12 and add release notes (authored by PiRK).
[electrum] Bump version to 5.2.12 and add release notes
PiRK committed rABC3523f2d225d1: [electrum] Progress on AppImage reproducibility (authored by EchterAgo).
[electrum] Progress on AppImage reproducibility
PiRK committed rABCf0d661a5be7e: [electrum] Use native architecture when building on macos (authored by Dustin Henning <ghrptr@mynym.us>).
[electrum] Use native architecture when building on macos
[electrum] bump python dependencies
PiRK committed rABC3e26da4561f2: [electrum] build: remove deprecated apt-key for winehq key (authored by EchterAgo).
[electrum] build: remove deprecated apt-key for winehq key
rebase after moving the unrelated change to where it belongs (D15872)
this was missing the filter_deps bash function, accidentaly amended to D15873
Apr 2 2024
Apr 2 2024
PiRK committed rABCe0f63054e494: [electrum] add the option to always add new addresses to wallet when scanning… (authored by PiRK).
[electrum] add the option to always add new addresses to wallet when scanning…
still working on an issue in the last commit of the PR, let's wait before reviewing this
still working on an issue in the last commit of the PR, let's wait before working on this
PiRK updated the diff for D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.
No need for the intermediate vars
[electrum] minor cleanup of scan_beyond_gap.py
PiRK updated the summary of D15849: [electrum] add the option to always add new addresses to wallet when scanning beyond gap.
Apr 1 2024
Apr 1 2024
PiRK committed rABCa6ab58f19c2d: [electrum] fix historical fiat prices via CoinGecko (authored by PiRK).
[electrum] fix historical fiat prices via CoinGecko
Mar 31 2024
Mar 31 2024
PiRK committed rABCa51d89123b68: [test] allow passing test checkpoints to ContextualCheckBlockHeader (authored by PiRK).
[test] allow passing test checkpoints to ContextualCheckBlockHeader
Mar 30 2024
Mar 30 2024
PiRK updated the summary of D15825: [test] allow passing test checkpoints to ContextualCheckBlockHeader.
PiRK published D15825: [test] allow passing test checkpoints to ContextualCheckBlockHeader for review.
teamcity awarded D15825: [test] allow passing test checkpoints to ContextualCheckBlockHeader a Haypence token.
teamcity awarded D15824: [test] fix asan initialization-order-fiasco a Doubloon token.
teamcity awarded D15824: [test] fix asan initialization-order-fiasco a Piece of Eight token.
teamcity awarded D15824: [test] fix asan initialization-order-fiasco a Haypence token.
PiRK committed rABC6a1dfbe3d989: Move ::fCheckBlockIndex into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>).
Move ::fCheckBlockIndex into ChainstateManager
PiRK committed rABC3ece82b609c1: Move ::nMinimumChainWork into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>).
Move ::nMinimumChainWork into ChainstateManager
PiRK committed rABC7538f22924c4: Move ::fCheckpointsEnabled into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>).
Move ::fCheckpointsEnabled into ChainstateManager
PiRK committed rABC69db3b4f2a4c: Move ::hashAssumeValid into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>).
Move ::hashAssumeValid into ChainstateManager