Page MenuHomePhabricator
Feed Advanced Search

Jul 20 2024

emack accepted D16496: [Cashtab] Add ecash-agora lib and helper methods.
Jul 20 2024, 14:41

Jul 18 2024

emack accepted D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 17:13
emack requested changes to D16496: [Cashtab] Add ecash-agora lib and helper methods.
Jul 18 2024, 09:53
emack added inline comments to D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 09:22
emack requested changes to D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 09:19
emack accepted D16492: [Cashtab] Add chronik method to get all tx history by lokad id.

minor nit

Jul 18 2024, 09:12

Jul 15 2024

emack requested changes to D16462: [Cashtab] Copy amounts on clikc.

The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.

  1. npm test
  2. click here, check blah...
Jul 15 2024, 05:14

Jul 13 2024

emack accepted D16461: [Cashtab] Special handling for tx inputs that are required and do not require wallet signature.
Jul 13 2024, 07:15
emack closed D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 07:02
emack committed rABC0f69d70a11ba: [Cashtab] Update paywall article link (authored by emack).
[Cashtab] Update paywall article link
Jul 13 2024, 07:02
emack added inline comments to D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 06:58
emack updated the diff for D16459: [Cashtab] Update paywall article link.

Version bump

Jul 13 2024, 06:57

Jul 12 2024

emack published D16459: [Cashtab] Update paywall article link for review.
Jul 12 2024, 14:44

Jul 11 2024

emack accepted D16440: [Cashtab] Replace 546 magic number with dust const.
Jul 11 2024, 00:09

Jul 10 2024

emack accepted D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 12:53
emack added inline comments to D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 11:45
emack requested changes to D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 11:38
emack added a comment to D16437: [Cashtab] Update comment and TODO in sendXec function.

@bot cashtab-tests

Jul 10 2024, 03:05

Jul 9 2024

emack accepted D16427: [Cashtab] Build all targetOutputs with script instead of address key.
Jul 9 2024, 13:53

Jun 12 2024

emack accepted D16325: [Cashtab] Link backup wallet warning to wallet backup screen.
Jun 12 2024, 01:46
emack accepted D16324: [Cashtab] Remove "webapp tx request" warning.
Jun 12 2024, 01:43

Jun 8 2024

emack accepted D16287: [Cashtab] Support copying full amount.
Jun 8 2024, 00:20

Jun 7 2024

emack requested changes to D16287: [Cashtab] Support copying full amount.

Tested all ok but I think the icon should be available even in uncollapsed state, otherwise if the user/merchant needs to copy a large number of txs for book keeping then that extra click to reveal the copy icon adds up.

Jun 7 2024, 00:27

Jun 4 2024

emack accepted D16271: [Cashtab] Update README to advise of local dependencies.
Jun 4 2024, 14:45
emack added a comment to D16261: [Cashtab] Modify extension manifest to support wasm.

The above build order should probably be in one of the 3 module's README, given how the dependencies are relative now.

Jun 4 2024, 07:37
emack accepted D16261: [Cashtab] Modify extension manifest to support wasm.
cd modules/ecash-lib-wasm
./dockerbuild.sh
cd ../ecash-lib
npm run build
cd ../../cashtab
npm run extension

Yup it was this order of build that fixed the issue. Loaded extension manually and works fine.

Jun 4 2024, 07:23

Jun 1 2024

emack requested changes to D16261: [Cashtab] Modify extension manifest to support wasm.

The local extension build fails as it can't find ecash-lib, even after I've npm ci'ed already. I assume this is likely to be a relative path issue?

image.png (599×854 px, 83 KB)

Jun 1 2024, 02:13

May 30 2024

emack accepted D16247: [website] Change title on landing page copy.

Clarified on tg, duplicated text found in https://e.cash/wealth-redefined

May 30 2024, 13:09
emack requested changes to D16247: [website] Change title on landing page copy.

The reason why I removed the last sentence is because it will be retained in the "about" page

May 30 2024, 03:43

May 29 2024

emack accepted D16237: [Cashtab] Show full-height screen with no nav footer for onboarding page.
May 29 2024, 02:21

May 27 2024

emack closed D16218: [Cashtab] Update tx history to recognize paywall payments.
May 27 2024, 00:16
emack committed rABC9ae5f3a3ac7d: [Cashtab] Update tx history to recognize paywall payments (authored by emack).
[Cashtab] Update tx history to recognize paywall payments
May 27 2024, 00:16

May 26 2024

emack updated the diff for D16218: [Cashtab] Update tx history to recognize paywall payments.

Removed redundant utf8 param and added integration test for invalid paywall transaction.

May 26 2024, 13:32

May 25 2024

emack updated the summary of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 25 2024, 13:18
emack updated the diff for D16218: [Cashtab] Update tx history to recognize paywall payments.

Updated paywall description to render an explorer link to the paywalled article

May 25 2024, 12:45

May 24 2024

emack updated the summary of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 24 2024, 04:41
emack requested review of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 24 2024, 04:39

May 21 2024

emack closed D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 21 2024, 12:47
emack committed rABCd953088e8a8e: [OP_RETURN Prefix] Paywall payment prefix (authored by emack).
[OP_RETURN Prefix] Paywall payment prefix
May 21 2024, 12:47

May 20 2024

emack updated the summary of D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 20 2024, 13:45
emack requested review of D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 20 2024, 13:33

May 8 2024

emack accepted D16119: [chronik-client] Support websocket subscriptions to tokenId.
May 8 2024, 21:31
emack accepted D16123: [Cashtab] Debounce wallet select.

Debounces all ok on mobile and desktop 👍

May 8 2024, 03:02
emack requested changes to D16123: [Cashtab] Debounce wallet select.

We already have an implementation of this in the Alias codebase, what additional benefit do you get from using this library to achieve this?

May 8 2024, 02:46

May 7 2024

emack added a comment to D16119: [chronik-client] Support websocket subscriptions to tokenId.

Is there anywhere I can read up on the concept of an SLP Mint Vault referenced in this diff?

May 7 2024, 06:33
emack accepted D16122: [Cashtab] Improve minified nav header to prevent content jumping.

Much better. Although I noticed it is scrolling even when there isn't content down below, however that's in prod too so not specific to this diff but nontheless I think previously we tried to stop that?

May 7 2024, 05:57

May 6 2024

emack accepted D16113: [Cashtab] word-break fix for tokens with very long names.
May 6 2024, 00:49

May 5 2024

emack requested changes to D16113: [Cashtab] word-break fix for tokens with very long names.

text-overflow: ellipsis; would be a better option here i think

May 5 2024, 22:05

May 2 2024

emack added inline comments to D16088: [chronik-client] Support lokad id endpoints.
May 2 2024, 14:03

Apr 30 2024

emack accepted D16076: [Cashtab] Add support for Malaysian Ringgit.
Apr 30 2024, 13:45
emack requested changes to D16076: [Cashtab] Add support for Malaysian Ringgit.

Coingecko feed on google vs cashtab. Is this delta within an acceptable threshold?

Apr 30 2024, 04:04
emack accepted D16065: [Cashtab] Use latest chronik-client.

ok, but don't let Tobias see this

Apr 30 2024, 03:18

Apr 29 2024

emack requested changes to D16065: [Cashtab] Use latest chronik-client.

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Apr 29 2024, 14:34

Apr 27 2024

emack accepted D16062: [Cashtab] Remove settings page alerts about moved features.
Apr 27 2024, 23:03
emack accepted D16060: [Cashtab] Upgrade NFT Page and add support for sending NFTs.
Apr 27 2024, 22:53
emack requested changes to D16060: [Cashtab] Upgrade NFT Page and add support for sending NFTs.
Apr 27 2024, 15:11
emack accepted D16061: [Cashtab] Correctly render amount of received txs with no change.
Apr 27 2024, 14:28
emack accepted D16057: [Cashtab] Support min fee sends for holders of 1000 Cachet.
Apr 27 2024, 14:19
emack accepted D16056: [Cashtab] Patch tx history rendering of NFT Collection genesis txs.
Apr 27 2024, 13:55

Apr 26 2024

emack accepted D16054: [Cashtab + token-server] Bump icon upload size and validate icon size before token creation.
Apr 26 2024, 23:56

Apr 25 2024

emack accepted D16043: [Cashtab] Support minting NFTs.

LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )

Apr 25 2024, 13:31
emack requested changes to D16043: [Cashtab] Support minting NFTs.

After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.

Apr 25 2024, 11:52

Apr 24 2024

emack closed D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Apr 24 2024, 13:22
emack committed rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX (authored by emack).
[Cashtab Extension] Increase height to improve app->extension UX
Apr 24 2024, 13:22
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

version bump

Apr 24 2024, 13:16
emack added a comment to D16043: [Cashtab] Support minting NFTs.

Per tg chat, here's the trace:

image.png (183×337 px, 21 KB)

hex: 0200000002e6410089e84b4fe22d2baf00b29f1aaf2d45b56a84491fb946aa9fb737d9a2e4010000006b483045022100f1bba9bac4356882f91309fad8ecd7d5303317ad5f7c4345baeee89d6eea222302206f96083beda6b821bcbf164301b2fa390ff3104f1b69d63ce3201d54bc2b0a86412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff34f4135763d899ecaf4a74c349a30d266fd733112178fe1a580a752b22817fa3020000006b483045022100d1879f63ee2974f1edb56335bfd84a67425e1e5b0ca120da02596c31d225ec3102204c175b67bffdfddac5ff66f543fa4315688cf7e962d11c521500d41aa8253dd1412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff150000000000000000d96a04534c500001810453454e4420e4a2d937b79faa46b91f49846ab5452daf1a9fb200af2b2de24f4be8890041e608000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000005122020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288acb8120000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac00000000

Apr 24 2024, 13:13
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

Move off master branch

Apr 24 2024, 13:02
emack updated the summary of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Apr 24 2024, 12:29
emack requested review of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Apr 24 2024, 12:26
emack requested changes to D16043: [Cashtab] Support minting NFTs.

Minting inputs on a newly created fixed supply collection.

image.png (947×1 px, 320 KB)

Apr 24 2024, 11:32

Apr 21 2024

emack accepted D16038: [Cashtab] Stop notifying on every avalanche finalized block.
Apr 21 2024, 14:40
emack accepted D16037: [Cashtab] Improve OnBoarding component.
Apr 21 2024, 12:48

Apr 20 2024

emack accepted D16036: [Cashtab] Show whether token supply is fixed or variable in create token preview modal.
Apr 20 2024, 15:00
emack accepted D16035: [Cashtab] Improve scrolling and header minification.
Apr 20 2024, 12:06
emack accepted D16032: [Cashtab] Support for creating NFT Collections.
Apr 20 2024, 12:05
emack accepted D16033: [token-server] Support creating tokens with icons from locally run cashtab.

image.png (426×490 px, 418 KB)

Apr 20 2024, 07:57
emack accepted D16031: [Cashtab] Word-break for validation msgs.
Apr 20 2024, 07:54
emack requested changes to D16035: [Cashtab] Improve scrolling and header minification.

Tested fine, just a nit on code pattern

Apr 20 2024, 07:51
emack requested changes to D16032: [Cashtab] Support for creating NFT Collections.

The sha256 hash matches all ok.
Is it intended that the collection NFT is rendered in amongst the standard slp1 eTokens with no differentiation? Is this just a staging area until you do the next diff to implement NFTs? That carousel styling would be good, one for each type of token.

Apr 20 2024, 07:41

Apr 19 2024

emack accepted D16012: [Cashtab] Searchable, alphabetical token list.
Apr 19 2024, 08:42
emack accepted D16017: [Cashtab] Fix airdrop tx render issue.
Apr 19 2024, 01:41

Apr 18 2024

emack accepted D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

As per tg chat

Apr 18 2024, 13:09
emack requested changes to D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

image.png (450×987 px, 95 KB)

Apr 18 2024, 13:07
emack accepted D16013: [token-server] Use ecash-coinselect from npm.
Apr 18 2024, 12:41
emack accepted D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.

Accepted post TG chat

Apr 18 2024, 05:42
emack requested changes to D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.
Apr 18 2024, 03:08
emack accepted D16011: [Cashtab] Show cursor pointer for extension open in tab button.
Apr 18 2024, 02:34
emack accepted D16005: [Cashtab] Better validation for token document url.
Apr 18 2024, 02:22

Apr 17 2024

emack accepted D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending.
Apr 17 2024, 14:56
emack accepted D16000: [Cashtab] Better formdata organization in create token form.

accepted with minor nits

Apr 17 2024, 14:47
emack accepted D16003: [Cashtab] Faster transition for opening and closing hamburger menu.
Apr 17 2024, 14:35
emack accepted D16002: [Cashtab] Organize styles in own file for Token screen.
Apr 17 2024, 14:30
emack accepted D15999: [Cashtab] Better organization for create token form.
Apr 17 2024, 13:16
emack accepted D15998: [Cashtab] Do not render mint switch on token page unless user has mint baton.
Apr 17 2024, 13:13
emack accepted D15993: [Cashtab] Add functions to build and broadcast NFT1 parent fan-out txs.
Apr 17 2024, 13:02
emack requested changes to D15993: [Cashtab] Add functions to build and broadcast NFT1 parent fan-out txs.
Apr 17 2024, 07:09
emack accepted D15996: [explorer] Update README to chronik-native instance.
Apr 17 2024, 05:28
emack accepted D15995: [Cashtab] Better hamburger menu.
Apr 17 2024, 05:27
emack accepted D15992: [Cashtab] Change route and component for SendToken to Token.
Apr 17 2024, 01:58
emack accepted D15987: [Cashtab] Add animation for avalanche finalized txs.
Apr 17 2024, 01:48