minor nit
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 20 2024
Jul 18 2024
Jul 15 2024
The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.
- npm test
- click here, check blah...
Jul 13 2024
Version bump
Jul 12 2024
Jul 11 2024
Jul 10 2024
@bot cashtab-tests
Jul 9 2024
Jun 12 2024
Jun 8 2024
Jun 7 2024
Tested all ok but I think the icon should be available even in uncollapsed state, otherwise if the user/merchant needs to copy a large number of txs for book keeping then that extra click to reveal the copy icon adds up.
Jun 4 2024
The above build order should probably be in one of the 3 module's README, given how the dependencies are relative now.
cd modules/ecash-lib-wasm ./dockerbuild.sh cd ../ecash-lib npm run build cd ../../cashtab npm run extension
Yup it was this order of build that fixed the issue. Loaded extension manually and works fine.
Jun 1 2024
The local extension build fails as it can't find ecash-lib, even after I've npm ci'ed already. I assume this is likely to be a relative path issue?
May 30 2024
Clarified on tg, duplicated text found in https://e.cash/wealth-redefined
The reason why I removed the last sentence is because it will be retained in the "about" page
May 29 2024
May 27 2024
May 26 2024
Removed redundant utf8 param and added integration test for invalid paywall transaction.
May 25 2024
Updated paywall description to render an explorer link to the paywalled article
May 24 2024
May 21 2024
May 20 2024
May 8 2024
Debounces all ok on mobile and desktop 👍
We already have an implementation of this in the Alias codebase, what additional benefit do you get from using this library to achieve this?
May 7 2024
Is there anywhere I can read up on the concept of an SLP Mint Vault referenced in this diff?
Much better. Although I noticed it is scrolling even when there isn't content down below, however that's in prod too so not specific to this diff but nontheless I think previously we tried to stop that?
May 6 2024
May 5 2024
text-overflow: ellipsis; would be a better option here i think
May 2 2024
Apr 30 2024
Coingecko feed on google vs cashtab. Is this delta within an acceptable threshold?
ok, but don't let Tobias see this
Apr 29 2024
Upgrade chronik-client so we get timeFirstSeen as a number and not a string
Apr 27 2024
Apr 26 2024
Apr 25 2024
LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )
After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.
Apr 24 2024
version bump
Per tg chat, here's the trace:
hex: 0200000002e6410089e84b4fe22d2baf00b29f1aaf2d45b56a84491fb946aa9fb737d9a2e4010000006b483045022100f1bba9bac4356882f91309fad8ecd7d5303317ad5f7c4345baeee89d6eea222302206f96083beda6b821bcbf164301b2fa390ff3104f1b69d63ce3201d54bc2b0a86412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff34f4135763d899ecaf4a74c349a30d266fd733112178fe1a580a752b22817fa3020000006b483045022100d1879f63ee2974f1edb56335bfd84a67425e1e5b0ca120da02596c31d225ec3102204c175b67bffdfddac5ff66f543fa4315688cf7e962d11c521500d41aa8253dd1412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff150000000000000000d96a04534c500001810453454e4420e4a2d937b79faa46b91f49846ab5452daf1a9fb200af2b2de24f4be8890041e608000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000005122020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288acb8120000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac00000000
Move off master branch
Apr 21 2024
Apr 20 2024
Tested fine, just a nit on code pattern
The sha256 hash matches all ok.
Is it intended that the collection NFT is rendered in amongst the standard slp1 eTokens with no differentiation? Is this just a staging area until you do the next diff to implement NFTs? That carousel styling would be good, one for each type of token.
Apr 19 2024
Apr 18 2024
As per tg chat
The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:
Accepted post TG chat
Apr 17 2024
accepted with minor nits