Rename function argument to value and move internal bigint down with a different name.

The setup_scripts/chronik-client_websocket.py failure above seems unrelated to me. It still is a bit suspicious, as I haven't seen an unrelated chronik ws related failure in a while.

@bot chronik-client-integration-test

I'm wondering if the way each individual CBlockIndex is fetched with the cs_main lock could be an issue. I guess there could be more efficient ways to do it, but mostly I wonder if there is a risk of returning an inconsistent list of headers if a reorg happens between two locks.

sigh

rededuplicate boundary checks, keep them early in the function this time

The deduplication was correct, you just called the boundary check later in the code flow which changed the behavior.

This breaks some existing images. For example, the wallet animation in the wallets page is currently a "reverse" loop -- coins go in, out, in, etc. After this, they "reset" every time.

also fix one such usage in test_batch_nft1.rs

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41303 for the next 60 minutes.

@bot preview-e.cash

just some fanatic suggestions

revert deduplicate

yes it's run

Is this test run as part of ninja check-crates ?

This is weird. It looks intermittent

review

Added inline comments to pushNumberOp after making some variable names more legible. Represent test case numbers in hexadecimal.

Removed package-lock.json added by mistake.

rebase on as_ref fix

switch to BiMap

use plugin idx instead of string to identify plugins

Otherwise LGTM

back to your queue

nit: use another constant for the number of blocks, make it smaller because it does not change the validity of the test

add a comment about boundary check

review

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41745 for the next 60 minutes.

@bot preview-e.cash