Page MenuHomePhabricator
Feed Advanced Search

Oct 26 2024

PiRK accepted D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 18:11
PiRK accepted D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:07
PiRK updated the summary of D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:06
PiRK accepted D17010: [Cashtab] Patch misnamed mock.
Oct 26 2024, 07:46
PiRK accepted D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 26 2024, 07:44
PiRK accepted D17006: Bump our clang toolchain to version 16.
Oct 26 2024, 07:44

Oct 25 2024

PiRK abandoned D16301: [electrum] refactor ecc.py.

done (split in multiple diffs)

Oct 25 2024, 19:20
PiRK closed D16827: [chronik] store a scripthash -> script index.
Oct 25 2024, 08:59
PiRK committed rABC8cabfa5c8575: [chronik] store a scripthash -> script index (authored by PiRK).
[chronik] store a scripthash -> script index
Oct 25 2024, 08:59
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

comment nit

Oct 25 2024, 08:58
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

fix a warning

Oct 25 2024, 08:16
PiRK added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 25 2024, 07:45
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

improve behavior when cancelling a reindexing: remove alarming log, wipe the index and don't set the metadata flag to true when shutdown is requested during the process

Oct 25 2024, 07:40
PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 25 2024, 06:56

Oct 24 2024

PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

as_member_ref -> as_ref, factor repeated code into a member_ser_from_member method

Oct 24 2024, 15:56
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

add comments about the double switch Some(cf_member_hash) and mem_data.is_member_hash_index_enabled
mention in the summary that the mempool indexing is not part of this diff

Oct 24 2024, 15:34
PiRK accepted D16985: [CI] Remove PPA package for Ubuntu 20.04 Focal.
Oct 24 2024, 13:41
PiRK accepted D16978: [CI] Deploy nodejs on Debian Bookworm.
Oct 24 2024, 13:32
PiRK accepted D16976: [faucet] Allow to retry upon request failure.
Oct 24 2024, 13:31
PiRK accepted D16984: [secp256k1] Fix the Cirrus build.
Oct 24 2024, 13:30
PiRK accepted D16979: [faucet] Add a docker config for the faucet.
Oct 24 2024, 13:00
PiRK accepted D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 12:59
PiRK added inline comments to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 24 2024, 10:55
PiRK planned changes to D16827: [chronik] store a scripthash -> script index.

I still need to figure out the mempool thing and maybe rust tests

Oct 24 2024, 10:54
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

rebase, feedback

Oct 24 2024, 10:52
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

feedback:

  • allow shutdown during scripthash reindexing
  • rename scripthash -> member_hash in the group_history.rs context
  • let the hash member method deal with endianness to minimize risks of getting in wrong in callsite (hash_member() -> Sha256 -> ser_hash_mebmer -> [u8; 32])
  • &[0xff; 32]
Oct 24 2024, 09:42
PiRK added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 09:08

Oct 23 2024

PiRK accepted D16962: Add a release note for the chronik fixes.
Oct 23 2024, 15:58
PiRK accepted D16964: [depends] Don't build openssl with socket support outside of linux.
Oct 23 2024, 13:16
PiRK accepted D16954: Build CPython in depends (Linux only).

It is always possible to add more libs later if needed

Oct 23 2024, 06:53

Oct 22 2024

PiRK published D16827: [chronik] store a scripthash -> script index for review.
Oct 22 2024, 18:05
PiRK accepted D16955: [guix] Build chronik plugin on linux.
Oct 22 2024, 18:00
PiRK added a comment to D16954: Build CPython in depends (Linux only).

Looks good. I'm not really on top of chronik plugins yet so not sure about the needed packages in Setup.local.

Oct 22 2024, 17:51
PiRK updated the summary of D16937: [chronik] add scripthash option to the various script endpoints.
Oct 22 2024, 17:43
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

the bytes dependency for chronik-http is no longer needed

Oct 22 2024, 15:17
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

add more tests, more endpoints (unconfirmed_txs, history)

Oct 22 2024, 15:12
PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 22 2024, 08:33
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

fix style warnings, better handle invalid scripthash payloads

Oct 22 2024, 08:23

Oct 21 2024

PiRK accepted D16950: [Cashtab] Add max qty validation to isValidTokenSendOrBurnAmount.
Oct 21 2024, 19:47
PiRK accepted D16949: [Cashtab] Rename getMaxMintAmount to getMaxDecimalizedSlpQty.
Oct 21 2024, 19:13
PiRK accepted D16947: [cmake] Remove redundant find_package(Python).
Oct 21 2024, 19:11
PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.

still a WIP

Oct 21 2024, 19:09
PiRK accepted D16946: Bump CMake minimum version to 3.18.
Oct 21 2024, 16:08
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

fix stuff

Oct 21 2024, 15:26
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

use an enum, move code to query/group_history

Oct 21 2024, 14:38
PiRK added inline comments to D16938: [Chronik] Fix incorrectly compressed P2PK scripts.
Oct 21 2024, 12:05
PiRK accepted D16938: [Chronik] Fix incorrectly compressed P2PK scripts.
Oct 21 2024, 08:51

Oct 20 2024

PiRK accepted D16941: [Chronik] Clear OP_RETURN scripts from script index, enable DB upgrade to version 13.
Oct 20 2024, 08:17
PiRK added inline comments to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 20 2024, 07:11

Oct 19 2024

PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.

that was supposed to be published as a draft

Oct 19 2024, 15:49
PiRK requested review of D16937: [chronik] add scripthash option to the various script endpoints.
Oct 19 2024, 15:48

Oct 18 2024

PiRK accepted D16930: [token-server] Bump claim xec rate limit.
Oct 18 2024, 12:47
PiRK accepted D16925: [Cashtab] New formatting method for getting decimals for very small xec values.
Oct 18 2024, 12:46
PiRK requested changes to D16925: [Cashtab] New formatting method for getting decimals for very small xec values.

There is a test that does not do what it claims to do.
Otherwise looks good.

Oct 18 2024, 06:32
PiRK accepted D16922: [Cashtab] Fix hover effect for svg buttons.
Oct 18 2024, 06:31
PiRK added inline comments to D16925: [Cashtab] New formatting method for getting decimals for very small xec values.
Oct 18 2024, 06:30
PiRK accepted D16924: [Cashtab] Separate scroll styling for portability.
Oct 18 2024, 06:25
PiRK accepted D16921: [Cashtab] Add horizontal padding to buttons.
Oct 18 2024, 06:22
PiRK accepted D16919: [ecash-agora] syntax replace == with ===.
Oct 18 2024, 06:21

Oct 17 2024

PiRK accepted D16917: [Chronik] Don't index OP_RETURN scripts anymore.
Oct 17 2024, 07:53

Oct 16 2024

PiRK accepted D16915: [CI] Remove 32 bits Linux builds.
Oct 16 2024, 17:22

Oct 15 2024

PiRK closed D16908: [seeder] Fix such that seeder node awaits both headers and addr messages.
Oct 15 2024, 20:08
PiRK committed rABC9d7c695bb4ba: [seeder] Fix such that seeder node awaits both headers and addr messages (authored by PiRK).
[seeder] Fix such that seeder node awaits both headers and addr messages
Oct 15 2024, 20:08
PiRK closed D16500: [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 20:08
PiRK committed rABCdf673a6df8aa: [seeder] Mark nodes as unreliable until checkpoint verified (authored by PiRK).
[seeder] Mark nodes as unreliable until checkpoint verified
Oct 15 2024, 20:08
PiRK updated the diff for D16908: [seeder] Fix such that seeder node awaits both headers and addr messages.

remove useless return, fix comment nit, use MainNet testing setup for new test (needed after changing HasCheckPoint in parent diff)

Oct 15 2024, 14:24
PiRK updated the diff for D16500: [seeder] Mark nodes as unreliable until checkpoint verified.

use GetRequireHeight in HasCheckpoint

Oct 15 2024, 14:18
PiRK updated the diff for D16500: [seeder] Mark nodes as unreliable until checkpoint verified.

check last checkpoint height to decide whether checkpoints should be validated
This requires a unit test to now use the MainNet params.

Oct 15 2024, 14:16
PiRK added inline comments to D16500: [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 07:55
PiRK closed D16899: [chronik] fix script compression.
Oct 15 2024, 07:47
PiRK committed rABC4c73e2329958: [chronik] fix script compression (authored by PiRK).
[chronik] fix script compression
Oct 15 2024, 07:47
PiRK updated the diff for D16899: [chronik] fix script compression.

-,

Oct 15 2024, 06:49
PiRK published D16908: [seeder] Fix such that seeder node awaits both headers and addr messages for review.
Oct 15 2024, 05:09
PiRK retitled D16500: [seeder] Mark nodes as unreliable until checkpoint verified from Seeder: Mark nodes as unreliable until checkpoint verified to [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 05:08
PiRK published D16500: [seeder] Mark nodes as unreliable until checkpoint verified for review.
Oct 15 2024, 05:08
PiRK closed D16499: [seeder] Make unreliable node reasons clear and consistent.
Oct 15 2024, 05:06
PiRK closed D16905: [seeder] Remove variable that is never read.
Oct 15 2024, 05:06
PiRK committed rABC2c02a0dcb3a9: [seeder] Make unreliable node reasons clear and consistent (authored by PiRK).
[seeder] Make unreliable node reasons clear and consistent
Oct 15 2024, 05:06
PiRK committed rABCa0f49bf60e9e: [seeder] Remove variable that is never read (authored by PiRK).
[seeder] Remove variable that is never read
Oct 15 2024, 05:06
PiRK closed D16904: [seeder] Get rid of pointless `wait` variable and params.
Oct 15 2024, 05:06
PiRK committed rABC06b9d443c921: [seeder] Get rid of pointless `wait` variable and params (authored by PiRK).
[seeder] Get rid of pointless `wait` variable and params
Oct 15 2024, 05:06

Oct 14 2024

PiRK updated the diff for D16499: [seeder] Make unreliable node reasons clear and consistent.

rebase

Oct 14 2024, 18:49
PiRK accepted D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 18:47
PiRK requested review of D16905: [seeder] Remove variable that is never read.
Oct 14 2024, 15:29
PiRK requested review of D16904: [seeder] Get rid of pointless `wait` variable and params.
Oct 14 2024, 14:58
PiRK committed rABC8e0aed83034d: add missing cstdint include in iguana_formatter.h (authored by PiRK).
add missing cstdint include in iguana_formatter.h
Oct 14 2024, 09:16
PiRK closed D16897: add missing cstdint include in iguana_formatter.h.
Oct 14 2024, 09:16

Oct 12 2024

PiRK added inline comments to D16899: [chronik] fix script compression.
Oct 12 2024, 12:43
PiRK updated the summary of D16899: [chronik] fix script compression.
Oct 12 2024, 12:39
PiRK requested review of D16899: [chronik] fix script compression.
Oct 12 2024, 12:38
PiRK requested review of D16897: add missing cstdint include in iguana_formatter.h.
Oct 12 2024, 09:28

Oct 11 2024

PiRK accepted D16893: Bump version to 0.30.2.
Oct 11 2024, 09:28
PiRK planned changes to D16881: Improve performance of p2p inv to send queues.

this need some work to raise other limits first. Clipping broadcast_max at 1000 makes the situation actually worse than our current limit (INVENTORY_BROADCAST_MAX_PER_MB * 32 = 1120)

Oct 11 2024, 08:42
PiRK updated the diff for D16881: Improve performance of p2p inv to send queues.

fix the while condition, add a ceiling to the max value (1000)

Oct 11 2024, 08:09
PiRK accepted D16889: [chronik] Add a test for invalidated blocks on a parked chain.
Oct 11 2024, 06:00

Oct 10 2024

PiRK closed D16883: [electrum] rename migrate_data.py to update.py and fix module docstring.
Oct 10 2024, 16:16
PiRK committed rABC81422f655e94: [electrum] rename migrate_data.py to update.py and fix module docstring (authored by PiRK).
[electrum] rename migrate_data.py to update.py and fix module docstring
Oct 10 2024, 16:16
PiRK closed D16875: [electrum] update block explorers.
Oct 10 2024, 16:16
PiRK committed rABC2073152fee90: [electrum] update block explorers (authored by PiRK).
[electrum] update block explorers
Oct 10 2024, 16:16
PiRK accepted D16884: [explorer] Change the chonik backend.
Oct 10 2024, 14:23