Page MenuHomePhabricator
Feed All Stories

Jan 15 2025

roqqit added inline comments to D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 17:26
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 17:20
roqqit requested review of D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 15 2025, 17:19
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toScriptHex method to Script class to [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 13:38
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toHex it is

Jan 15 2025, 13:37
teamcity added a comment to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:21
teamcity added a comment to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:20
teamcity added a comment to D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 11:15
teamcity added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:12
teamcity added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:11
PiRK planned changes to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

needs a rebase

Jan 15 2025, 11:11
PiRK planned changes to D17536: Documentation improvements for assumeutxo.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:10
PiRK added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17533: Move block-storage-related logic to ChainstateManager.

lock issue detected by clang

Jan 15 2025, 11:10
teamcity added a comment to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 11:08
teamcity added a comment to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 11:06
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:05
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:04
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:01
teamcity updated the summary of D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:00
PiRK requested review of D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:00
hazzarust closed D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 15 2025, 11:00
hazzarust committed rABCf7d1497b7029: [Chronik] Add chronik_info method into lib.rs (authored by hazzarust).
[Chronik] Add chronik_info method into lib.rs
Jan 15 2025, 11:00
teamcity updated the summary of D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 10:57
PiRK requested review of D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 10:57
PiRK added inline comments to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:56
PiRK requested review of D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 10:54
teamcity updated the summary of D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:53
PiRK requested review of D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:53
teamcity updated the summary of D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 10:51
PiRK requested review of D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 10:51
teamcity updated the summary of D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Jan 15 2025, 10:50
PiRK requested review of D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Jan 15 2025, 10:50
PiRK updated the diff for D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.

rebase, remove now useless hack to skip checkblockindex from D14653

Jan 15 2025, 10:48
PiRK accepted D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 09:21
Fabien accepted D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 09:20
PiRK requested changes to D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 09:18
Fabien accepted D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 09:18
PiRK accepted D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 09:16
Fabien requested changes to D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.

Not really related to the changes but since you are touching the code it's best to fix it

Jan 15 2025, 09:15
Fabien requested changes to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 08:59
Fabien added a comment to D17527: [ecash-lib] Add toHex method to Script class.

I don't want to start bike shedding but this is the worst possible name. You can convert an address to script hex, that makes sense. But a script to script hex makes zero sense.
I also don't see how you can be confused with the toHex() function which is not a script method. That's what namespace is about.

Jan 15 2025, 08:59
teamcity added a comment to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 00:45
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

update test name

Jan 15 2025, 00:41
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toString method to Script class to [ecash-lib] Add toScriptHex method to Script class.
Jan 15 2025, 00:40
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toString becomes toScriptHex

Jan 15 2025, 00:39
bytesofman added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 00:39
roqqit updated the summary of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:31
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.

Add back accidentally deleted comment

Jan 15 2025, 00:13
teamcity updated the summary of D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 00:11
roqqit requested review of D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 00:11
teamcity updated the summary of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:07
roqqit requested review of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:07
teamcity updated the summary of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 00:01
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 00:01

Jan 14 2025

Fabien accepted D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 22:03
hazzarust retitled D17528: [Chronik] Add chronik_info method into lib.rs from [Chronik] Added chronik_info method into lib.rs to retrieve ChronikInfo struct and thus the version to [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 21:37
hazzarust updated the diff for D17528: [Chronik] Add chronik_info method into lib.rs.

Added the regex test for version returned from ChronikInfo

Jan 14 2025, 21:26
Fabien requested changes to D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 21:00
hazzarust updated the diff for D17528: [Chronik] Add chronik_info method into lib.rs.

Added assert_eq!() test for chronik version returned

Jan 14 2025, 20:56
Fabien added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:53
Fabien added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:52
Fabien requested changes to D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 20:51
tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:50
Fabien added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:48
hazzarust requested review of D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 20:48
bytesofman published D17527: [ecash-lib] Add toHex method to Script class for review.
Jan 14 2025, 20:12
Fabien closed D17526: [website] Fix the macos release download link.
Jan 14 2025, 14:41
Fabien committed rABCWEB707fd2a01ca8: [website] Fix the macos release download link (authored by Fabien).
[website] Fix the macos release download link
Jan 14 2025, 14:41
PiRK accepted D17526: [website] Fix the macos release download link.
Jan 14 2025, 14:40
Fabien requested review of D17526: [website] Fix the macos release download link.
Jan 14 2025, 14:23
PiRK closed D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Jan 14 2025, 12:44
PiRK committed rABCa19427fa9855: [chronik] add blockchain.transaction.broadcast electrum method (authored by PiRK).
[chronik] add blockchain.transaction.broadcast electrum method
Jan 14 2025, 12:44
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

rebase and add a syncwithvalidationinterfacequeue to the test

Jan 14 2025, 08:38

Jan 13 2025

teamcity closed T3722: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jan 13 2025, 23:32
teamcity triaged T3722: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jan 13 2025, 22:57
bytesofman closed D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.
Jan 13 2025, 22:50
bytesofman committed rABC77288ad40031: [ecash-agora] Do not allow creation of unacceptable agora partials (authored by bytesofman).
[ecash-agora] Do not allow creation of unacceptable agora partials
Jan 13 2025, 22:50
bytesofman updated the diff for D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.

version bump (patch)

Jan 13 2025, 22:16
bytesofman updated the diff for D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.

rebase and confirm no git issue (dropped an earlier commit)

Jan 13 2025, 22:14
bytesofman closed D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price).
Jan 13 2025, 22:08
bytesofman committed rABC1659e6453360: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and… (authored by bytesofman).
[ecash-agora] Upgrade historicOffers to return token amounts purchased (and…
Jan 13 2025, 22:08
tobias_ruck accepted D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.
Jan 13 2025, 22:01
roqqit closed D17525: [avalanche] Set vote status for highest ranking contender.
Jan 13 2025, 21:56
roqqit committed rABC1c0e73e93ef7: [avalanche] Set vote status for highest ranking contender (authored by roqqit).
[avalanche] Set vote status for highest ranking contender
Jan 13 2025, 21:56
roqqit closed D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Jan 13 2025, 21:55
roqqit committed rABCbadfc35a942d: [avalanche] Simplify lock into one-liner in processor_tests (authored by roqqit).
[avalanche] Simplify lock into one-liner in processor_tests
Jan 13 2025, 21:55
bytesofman updated the diff for D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price).

improve names and doc for new interface, update tests

Jan 13 2025, 21:50
Fabien accepted D17525: [avalanche] Set vote status for highest ranking contender.
Jan 13 2025, 21:40
tobias_ruck added inline comments to D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price).
Jan 13 2025, 21:40
Fabien accepted D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Jan 13 2025, 21:07
bytesofman closed D17519: [Cashtab] Implement websocket in OrderBook.
Jan 13 2025, 21:04
bytesofman committed rABC5bc41ee4ec03: [Cashtab] Implement websocket in OrderBook (authored by bytesofman).
[Cashtab] Implement websocket in OrderBook
Jan 13 2025, 21:04
bytesofman updated the diff for D17519: [Cashtab] Implement websocket in OrderBook.

remove unrelated line break, preserve offer refresh if ws is null

Jan 13 2025, 20:38
bytesofman updated the diff for D17519: [Cashtab] Implement websocket in OrderBook.

minor version bump, some code tweaks from additional testing, test site redeployed with this version with debug logs

Jan 13 2025, 20:28
roqqit requested review of D17525: [avalanche] Set vote status for highest ranking contender.
Jan 13 2025, 19:59
roqqit requested review of D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Jan 13 2025, 19:49
PiRK closed D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method.
Jan 13 2025, 19:19