Feed All Stories
Jan 17 2025
Jan 17 2025
PiRK committed rABCa5d25d3b48f3: Move CheckBlockIndex() from Chainstate to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move CheckBlockIndex() from Chainstate to ChainstateManager
PiRK committed rABC781f67df62a8: Documentation improvements for assumeutxo (authored by Ryan Ofsky <ryan@ofsky.org>).
Documentation improvements for assumeutxo
PiRK committed rABCce02141a9db8: Fix initialization of setBlockIndexCandidates when working with multiple… (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Fix initialization of setBlockIndexCandidates when working with multiple…
PiRK committed rABCc3eb66ed6134: Tighten requirements for adding elements to setBlockIndexCandidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Tighten requirements for adding elements to setBlockIndexCandidates
PiRK committed rABC2edc904cea06: Move block-storage-related logic to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move block-storage-related logic to ChainstateManager
PiRK committed rABCe476633f2c51: Add wrapper for adding entries to a chainstate's block index candidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Add wrapper for adding entries to a chainstate's block index candidates
PiRK committed rABCca86cbd58f3e: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot
PiRK committed rABC5ad8a704fdcb: Move block-arrival information / preciousblock counters to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move block-arrival information / preciousblock counters to ChainstateManager
PiRK committed rABCcfc92ee56946: Explicitly track maximum block height stored in undo files (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Explicitly track maximum block height stored in undo files
bytesofman published D17549: [Cashtab] Patch render logic for spinner for review.
bytesofman updated the test plan for D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
bytesofman published D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets for review.
bytesofman published D17551: [Cashtab] Do not double call updateCashtabState on wallet change for review.
bytesofman published D17550: [Cashtab] Convert WalletLabel to ts for review.
Jan 16 2025
Jan 16 2025
roqqit committed rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime (authored by roqqit).
[test] Make test_getpeerinfo more robust by using mocktime
bytesofman committed rABC779edc7f5c42: [Cashtab] Prevent double notifications on send xec txs while preserving testing… (authored by bytesofman).
[Cashtab] Prevent double notifications on send xec txs while preserving testing…
Fabien committed rABC2c1219ed56c6: [electrum] Fix the homescreen change with all devices (authored by Fabien).
[electrum] Fix the homescreen change with all devices
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Remove errant newline
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Use assert_equal
Fabien updated the diff for D17546: [electrum] Fix the homescreen change with all devices.
Less code duplication
Fabien requested review of D17546: [electrum] Fix the homescreen change with all devices.
bytesofman committed rABC467afd4d59d5: [Cashtab] Patch bug in building token change outputs (authored by bytesofman).
[Cashtab] Patch bug in building token change outputs
bytesofman published D17545: [Cashtab] Patch bug in building token change outputs for review.
bytesofman committed rABC0ac291483c70: [mock-chronik-client] Improve path defs for typescript build (authored by bytesofman).
[mock-chronik-client] Improve path defs for typescript build
bytesofman committed rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file (authored by bytesofman).
[mock-chronik-client] Clean up test mocks file
PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.
feedback
bytesofman committed rABCbb9172b62a96: [Cashtab] Show token qty and cumulative qty in any given agora offer in a… (authored by bytesofman).
[Cashtab] Show token qty and cumulative qty in any given agora offer in a…
bytesofman added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?
emack added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?
emack accepted D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Minor nit but tested all ok. Can confirm the transparency is not an issue on mobile screenshots, so must be Brave specific.
bytesofman published D17543: [mock-chronik-client] Clean up test mocks file for review.
bytesofman published D17542: [mock-chronik-client] Improve path defs for typescript build for review.
Jan 15 2025
Jan 15 2025
bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
bytesofman retitled D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip from [Cashtab] Show token qty in any given agora offer in a tooltip to [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
bytesofman updated the diff for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
add cumulative, make sure tooltips are always on top
roqqit committed rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
[test] Fix intermittent timeouts in various functional tests
roqqit committed rABC4b8c65801635: test: Fail if connect_nodes fails (authored by laanwj <126646+laanwj@users.noreply.github.com>).
test: Fail if connect_nodes fails
roqqit committed rABCc801d8fc621a: [test] Cleanup unnecessary sync_all in rpc_net.py (authored by roqqit).
[test] Cleanup unnecessary sync_all in rpc_net.py
roqqit committed rABC7878d95a0db2: [test] clarify rpc_net & p2p_disconnect_ban functional tests (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[test] clarify rpc_net & p2p_disconnect_ban functional tests
Fabien added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
This is a rare case where I don't think it's worth doing 2 steps. It's easy enough to get the cumulative value (you can use D17449 if you want to) that it doesn't desserve a half step
Fabien requested changes to D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Fabien requested changes to D17533: Move block-storage-related logic to ChainstateManager.
tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
bytesofman committed rABCe348c74a4fdd: [ecash-lib] Add toHex method to Script class (authored by bytesofman).
[ecash-lib] Add toHex method to Script class
teamcity updated the summary of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
PiRK requested review of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
PiRK updated the diff for D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
rebase
PiRK updated the diff for D17536: Documentation improvements for assumeutxo.
rebase
PiRK updated the diff for D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
rebase
PiRK updated the diff for D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
rebase
PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.
remove wrong negative lock annotation
teamcity updated the summary of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
roqqit requested review of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.
Fix wait_until_helper -> self.wait_until