Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Feb 22 2025

PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

fix comment layout

Feb 22 2025, 09:21

Feb 21 2025

PiRK requested review of D17686: [chronik] add Electrum RPC server.donation_address.
Feb 21 2025, 16:57
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Still lgtm

Feb 21 2025, 14:20
PiRK accepted D17684: [chronik] Fix the chronik_plugins test.
Feb 21 2025, 14:05
PiRK accepted D17682: Fix nullptr clientModel access during shutdown.
Feb 21 2025, 13:42
PiRK closed D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Feb 21 2025, 10:35
PiRK committed rABCb760220009df: [chronik] make the maximum history length for electrum RPCs an init param (authored by PiRK).
[chronik] make the maximum history length for electrum RPCs an init param
Feb 21 2025, 10:35

Feb 20 2025

PiRK retitled D17681: [chronik] make the maximum history length for electrum RPCs an init param from [chronik] make the maximum history length an init param to [chronik] make the maximum history length for electrum RPCs an init param.
Feb 20 2025, 19:36
PiRK requested review of D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Feb 20 2025, 19:21
PiRK closed D17676: [chronik] implement server.version electrum method.
Feb 20 2025, 07:38
PiRK committed rABC91ef9971ad45: [chronik] implement server.version electrum method (authored by PiRK).
[chronik] implement server.version electrum method
Feb 20 2025, 07:38
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 20 2025, 07:24

Feb 19 2025

PiRK accepted D17677: Improve reliability of abc_rpc_getavalancheproofs.
Feb 19 2025, 11:50
PiRK accepted D17675: [chronik] Consistently sync the validation queue in functional tests.
Feb 19 2025, 11:49
PiRK updated the diff for D17676: [chronik] implement server.version electrum method.

remove done TODO

Feb 19 2025, 09:35
PiRK added inline comments to D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:34
PiRK updated the summary of D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:33
PiRK requested review of D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:33

Feb 18 2025

PiRK accepted D17674: [avalanche] Deprecate the node availability score in the peerinfo RPC.
Feb 18 2025, 17:12
PiRK committed rABC9205e1004401: test: Add explicit onion bind to p2p_permissions (authored by Ava Chow <github@achow101.com>).
test: Add explicit onion bind to p2p_permissions
Feb 18 2025, 14:46
PiRK closed D17673: test: Add explicit onion bind to p2p_permissions.
Feb 18 2025, 14:46
PiRK requested review of D17673: test: Add explicit onion bind to p2p_permissions.
Feb 18 2025, 13:19
PiRK closed D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Feb 18 2025, 12:12
PiRK committed rABCe09df7e9e3ab: [chronik] Implement blockchain.scripthash.listunspent electrum method (authored by PiRK).
[chronik] Implement blockchain.scripthash.listunspent electrum method
Feb 18 2025, 12:12
PiRK closed D17670: [electrum] support newer protobuf library versions.
Feb 18 2025, 12:12
PiRK committed rABC36570956a320: [electrum] support newer protobuf library versions (authored by PiRK).
[electrum] support newer protobuf library versions
Feb 18 2025, 12:12
PiRK accepted D17671: Re-enable the getavaaddr_interval_test.

let's see if it pops up on CI again

Feb 18 2025, 09:41
PiRK requested review of D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Feb 18 2025, 09:22

Feb 17 2025

PiRK added a comment to D17670: [electrum] support newer protobuf library versions.

This was the error, fyi

Traceback (most recent call last):
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
    if self.run_round(covert):
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
    if self.run_round(covert):
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
    inpcomp = validate_proof_internal(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
    msg = proto_strict_parse(pb.Proof(), proofblob)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
    check(not msg.UnknownFields(), "has extra fields")
              ^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
    inpcomp = validate_proof_internal(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
    msg = proto_strict_parse(pb.Proof(), proofblob)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessor
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
    check(not msg.UnknownFields(), "has extra fields")
              ^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessor
Feb 17 2025, 15:14
PiRK requested review of D17670: [electrum] support newer protobuf library versions.
Feb 17 2025, 15:13
PiRK accepted D17668: Bump version to 0.30.12.
Feb 17 2025, 14:44
PiRK accepted D17669: [avalanche] Deprecate the peer availability score.
Feb 17 2025, 14:43

Feb 16 2025

PiRK requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

I was wrong in my previous comment, changing the name of fields in protobuf files does not break compatibility for clients of Chronik.

Feb 16 2025, 08:11
PiRK closed D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Feb 16 2025, 08:07
PiRK committed rABC0372571b7f77: [chronik] implement electrum RPC method blockchain.scripthash.get_history (authored by PiRK).
[chronik] implement electrum RPC method blockchain.scripthash.get_history
Feb 16 2025, 08:07

Feb 15 2025

PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review up to and including ecash-agora (just a comment nit)

Feb 15 2025, 16:34
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review (everything cashtab)

Feb 15 2025, 14:40
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review up to and including cashtab/src/airdrop/index.ts

Feb 15 2025, 10:25
PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.

remove debugging print

Feb 15 2025, 07:55

Feb 14 2025

PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.

clippy

Feb 14 2025, 11:14
PiRK requested review of D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Feb 14 2025, 09:02

Feb 13 2025

PiRK accepted D17662: Make it possible to disable Tor binds and abort startup on bind failure.
Feb 13 2025, 11:24
PiRK accepted D17663: Bump the block sync timeout in p2p_ibd_stalling.
Feb 13 2025, 11:13
PiRK accepted D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 09:59
PiRK accepted D17661: Better port collision management for the functional tests.
Feb 13 2025, 09:44
PiRK accepted D17661: Better port collision management for the functional tests.
Feb 13 2025, 09:19
PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:59
PiRK requested changes to D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:56
PiRK accepted D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:50

Feb 12 2025

PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 12 2025, 10:39
PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 12 2025, 10:36

Feb 11 2025

PiRK closed D17646: wallet: avoid rescans if under the snapshot.
Feb 11 2025, 14:43
PiRK committed rABC2069f3c76279: wallet: avoid rescans if under the snapshot (authored by James O'Beirne <james.obeirne@gmail.com>).
wallet: avoid rescans if under the snapshot
Feb 11 2025, 14:43
PiRK added inline comments to D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Feb 11 2025, 14:42
PiRK accepted D17657: Bump version to 0.30.11.
Feb 11 2025, 14:34
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase again

Feb 11 2025, 14:04
PiRK accepted D17656: Temporarly disable the getavaaddr_interval_test.
Feb 11 2025, 12:33
PiRK closed D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Feb 11 2025, 11:28
PiRK committed rABC6db422501d60: [chronik] implement the blockchain.scripthash.get_balance Electrum method (authored by PiRK).
[chronik] implement the blockchain.scripthash.get_balance Electrum method
Feb 11 2025, 11:28
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase, nit

Feb 11 2025, 10:14
PiRK accepted D17655: test: improve robustness of connect_nodes().
Feb 11 2025, 09:42
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase. I'm convinced the feature_assumevalid.py failure is unrelated to this diff

Feb 11 2025, 08:34
PiRK closed D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 11 2025, 08:31
PiRK committed rABCdb526ab596e1: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to… (authored by Ryan Ofsky <ryan@ofsky.org>).
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to…
Feb 11 2025, 08:31
PiRK closed D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 11 2025, 07:07
PiRK committed rABC1b64fae67afe: [electrum] fix output parsing when pay-to field is empty (authored by SomberNight <somber.night@protonmail.com>).
[electrum] fix output parsing when pay-to field is empty
Feb 11 2025, 07:07

Feb 9 2025

PiRK closed D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Feb 9 2025, 13:41
PiRK committed rABC8fc3de71d547: test: fix test failures in test/functional/p2p_timeouts.py (authored by Jon Atack <jon@atack.com>).
test: fix test failures in test/functional/p2p_timeouts.py
Feb 9 2025, 13:41
PiRK accepted D17654: Remove useless timeouts in p2p_timeouts.
Feb 9 2025, 13:39

Feb 8 2025

PiRK requested review of D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Feb 8 2025, 17:01
PiRK updated the test plan for D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 8 2025, 16:48
PiRK planned changes to D17646: wallet: avoid rescans if under the snapshot.

need to investigate that CI second failure (the first one is clearly unrelated)

Feb 8 2025, 16:46
PiRK requested review of D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 8 2025, 16:39
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase

Feb 8 2025, 10:33
PiRK closed D17645: wallet: make chain optional for CWallet::Create.
Feb 8 2025, 10:32
PiRK committed rABC95c17f9917b3: wallet: make chain optional for CWallet::Create (authored by Ivan Metlushko <metlushko@gmail.com>).
wallet: make chain optional for CWallet::Create
Feb 8 2025, 10:32
PiRK closed D17644: CWallet::Create move chain init message up into calling code.
Feb 8 2025, 10:32
PiRK committed rABCf8e022ee1291: CWallet::Create move chain init message up into calling code (authored by Ivan Metlushko <metlushko@gmail.com>).
CWallet::Create move chain init message up into calling code
Feb 8 2025, 10:32
PiRK closed D17643: refactor: Add CWallet:::AttachChain method.
Feb 8 2025, 10:32
PiRK committed rABC4cab5ee30993: refactor: Add CWallet:::AttachChain method (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: Add CWallet:::AttachChain method
Feb 8 2025, 10:32
PiRK closed D17642: refactor: move first run detection to client code.
Feb 8 2025, 10:31
PiRK committed rABCbfa2db91321b: refactor: move first run detection to client code (authored by Ivan Metlushko <metlushko@gmail.com>).
refactor: move first run detection to client code
Feb 8 2025, 10:31

Feb 7 2025

PiRK added inline comments to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 7 2025, 11:13

Feb 6 2025

PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

squash with 26282 (more helpful error message)

Feb 6 2025, 15:19
PiRK requested review of D17646: wallet: avoid rescans if under the snapshot.
Feb 6 2025, 15:11
PiRK requested review of D17645: wallet: make chain optional for CWallet::Create.
Feb 6 2025, 15:10
PiRK requested review of D17644: CWallet::Create move chain init message up into calling code.
Feb 6 2025, 15:09
PiRK requested review of D17643: refactor: Add CWallet:::AttachChain method.
Feb 6 2025, 15:08
PiRK requested review of D17642: refactor: move first run detection to client code.
Feb 6 2025, 15:07
PiRK updated the summary of D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 6 2025, 09:39
PiRK closed D17634: chainparams: add blockhash to AssumeutxoData.
Feb 6 2025, 07:40
PiRK committed rABC1d28ffc21aad: chainparams: add blockhash to AssumeutxoData (authored by James O'Beirne <james.obeirne@pm.me>).
chainparams: add blockhash to AssumeutxoData
Feb 6 2025, 07:40
PiRK closed D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 6 2025, 07:40
PiRK committed rABC48785be9d2f7: assumeutxo: remove snapshot during -reindex{-chainstate} (authored by James O'Beirne <james.obeirne@pm.me>).
assumeutxo: remove snapshot during -reindex{-chainstate}
Feb 6 2025, 07:40
PiRK closed D17632: net_processing: Request assumeutxo background chain blocks.
Feb 6 2025, 07:40
PiRK committed rABCca3c72fce46d: net_processing: Request assumeutxo background chain blocks (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
net_processing: Request assumeutxo background chain blocks
Feb 6 2025, 07:40
PiRK committed rABC07763f6aa047: [net processing] pass a Peer to FindNextBlocksToDownload (authored by PiRK).
[net processing] pass a Peer to FindNextBlocksToDownload
Feb 6 2025, 07:40
PiRK closed D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 6 2025, 07:40

Feb 5 2025

PiRK updated the summary of D17634: chainparams: add blockhash to AssumeutxoData.
Feb 5 2025, 18:56

Feb 4 2025

PiRK requested review of D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 4 2025, 16:58
First
Prev
Next