Page MenuHomePhabricator
Feed All Stories

Feb 26 2025

Fabien accepted D17686: [chronik] add Electrum RPC server.donation_address.
Feb 26 2025, 19:44
bytesofman published D17708: [Cashtab] Update token scam prevention list for review.
Feb 26 2025, 18:31
bytesofman published D17709: [Cashtab] Parse firma yield txs for review.
Feb 26 2025, 18:30
bytesofman published D17701: [Cashtab] Support one-click redemptions for review.
Feb 26 2025, 17:08
PiRK added a comment to D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.

I'll keep looking what's wrong with feature_assumevalid, but it is not related to this diff.

Feb 26 2025, 16:59
PiRK closed D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 16:54
PiRK closed D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 16:54
PiRK committed rABCa23a2ae0eda8: index: Move last_locator_write_time and logging to end of threadsync loop (authored by Fabian Jahr <fjahr@protonmail.com>).
index: Move last_locator_write_time and logging to end of threadsync loop
Feb 26 2025, 16:54
PiRK committed rABC8e4b9a1ff950: doc: BaseIndex sync behavior with empty datadir (authored by James O'Beirne <james.obeirne@pm.me>).
doc: BaseIndex sync behavior with empty datadir
Feb 26 2025, 16:54
PiRK committed rABCef3b321b2815: index: Don't commit a best block before indexing it during sync (authored by Martin Zumsande <mzumsande@gmail.com>).
index: Don't commit a best block before indexing it during sync
Feb 26 2025, 16:54
PiRK closed D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 16:54
roqqit accepted D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 16:43
roqqit accepted D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 16:40
roqqit accepted D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 16:39
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

use the constant in strings

Feb 26 2025, 15:57
teamcity added a comment to D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 26 2025, 15:54
teamcity updated the summary of D17707: refactor: use std::string for index names.
Feb 26 2025, 15:47
PiRK requested review of D17707: refactor: use std::string for index names.
Feb 26 2025, 15:47
teamcity updated the summary of D17706: refactor: use std::string for thread names.
Feb 26 2025, 15:46
PiRK requested review of D17706: refactor: use std::string for thread names.
Feb 26 2025, 15:45
teamcity updated the summary of D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 26 2025, 15:44
PiRK requested review of D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 26 2025, 15:44
teamcity updated the summary of D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 15:32
PiRK requested review of D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 15:32
PiRK updated the summary of D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 15:32
teamcity updated the summary of D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 15:32
PiRK requested review of D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 15:31
teamcity updated the summary of D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 15:30
PiRK requested review of D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 15:30
bytesofman abandoned D17328: [token-server] Bump free xec from 42 to 88.

i think will just forget about this for now. we have good demand for the 42-xec reward and no one has complained about it being insufficient.

Feb 26 2025, 15:08
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

patch implementation of reduce in cashtab transactions (do not mix bigint and number)

Feb 26 2025, 13:29
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 26 2025, 13:23
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.
Feb 26 2025, 12:59
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, bigint in reduce, bigint math for token rewards in herald, camelCase patches in ecash-agora, var name patches in cashtab constants, hex instead of decimal for hex-defined constants

Feb 26 2025, 12:57
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 26 2025, 12:52
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

make max length a constexpr

Feb 26 2025, 10:52
PiRK updated the summary of D17686: [chronik] add Electrum RPC server.donation_address.
Feb 26 2025, 10:40
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.
Feb 26 2025, 10:30
Fabien requested changes to D17700: [avalanche] Process responses to stake contender polls.
Feb 26 2025, 10:23
tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 26 2025, 09:52
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

chech the donation address length

Feb 26 2025, 09:10
teamcity awarded D17700: [avalanche] Process responses to stake contender polls a Haypence token.
Feb 26 2025, 09:08
Fabien added a comment to D17700: [avalanche] Process responses to stake contender polls.

@bot build-tsan

Feb 26 2025, 09:08

Feb 25 2025

roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

bump -avastalevotethreshold a bit because some rounds get voted while finalizing the first block

Feb 25 2025, 23:49
teamcity added a comment to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 22:14
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

add test cases for all invalidated and all stalled contenders

Feb 25 2025, 22:04
teamcity added a comment to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 21:38
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 21:30
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

fixing locking issues

Feb 25 2025, 21:30
teamcity added a comment to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 20:31
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.

Early feedback indicates some stuff is missing:

  1. Comment on the outcomes of a stale vote.
  2. Test case if all contenders are rejected.
  3. Test case if all contenders are stalled.
Feb 25 2025, 20:30
teamcity added a comment to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 20:30
roqqit closed D17699: [avalanche] Clarify and simplify checking polled contenders.
Feb 25 2025, 20:23
roqqit committed rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders (authored by roqqit).
[avalanche] Clarify and simplify checking polled contenders
Feb 25 2025, 20:23
roqqit requested review of D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 20:20
Fabien accepted D17699: [avalanche] Clarify and simplify checking polled contenders.
Feb 25 2025, 20:16
Fabien accepted D17697: [Cashtab] Make sure whitelisted agora tokens load cache first.
Feb 25 2025, 20:15
Fabien closed D17698: Avoid inflight polls in getavaaddr_interval_test.
Feb 25 2025, 20:13
Fabien committed rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test (authored by Fabien).
Avoid inflight polls in getavaaddr_interval_test
Feb 25 2025, 20:13
roqqit requested review of D17699: [avalanche] Clarify and simplify checking polled contenders.
Feb 25 2025, 20:09
teamcity closed T3759: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Feb 25 2025, 16:32
roqqit accepted D17698: Avoid inflight polls in getavaaddr_interval_test.
Feb 25 2025, 16:31
roqqit closed D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 16:29
roqqit committed rABCdc86c1e90e2a: [avalanche] Make contender test more comprehensive (authored by roqqit).
[avalanche] Make contender test more comprehensive
Feb 25 2025, 16:29
roqqit closed D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 16:28
roqqit committed rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test (authored by roqqit).
[avalanche] Make payout scripts unique in contenders test
Feb 25 2025, 16:28
roqqit closed D17693: [avalanche] Cleanup payout address optionality.
Feb 25 2025, 16:24
roqqit committed rABCba6cbc602b92: [avalanche] Cleanup payout address optionality (authored by roqqit).
[avalanche] Cleanup payout address optionality
Feb 25 2025, 16:24
roqqit closed D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 16:22
roqqit committed rABC052eab4970d3: test: Ignore UTF-8 errors in assert_debug_log (authored by fanquake <fanquake@gmail.com>).
test: Ignore UTF-8 errors in assert_debug_log
Feb 25 2025, 16:22
Fabien requested review of D17698: Avoid inflight polls in getavaaddr_interval_test.
Feb 25 2025, 15:18
bytesofman published D17697: [Cashtab] Make sure whitelisted agora tokens load cache first for review.
Feb 25 2025, 14:05
teamcity awarded D17659: [WIP] CI investigation a Love token.
Feb 25 2025, 13:38
teamcity awarded D17659: [WIP] CI investigation a Like token.
Feb 25 2025, 13:38
teamcity awarded D17659: [WIP] CI investigation a Love token.
Feb 25 2025, 12:11
teamcity triaged T3759: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Feb 25 2025, 11:43
PiRK committed rABC40402b2ac954: wallet: Ignore chainStateFlushed notifications while attaching chain (authored by Martin Zumsande <mzumsande@gmail.com>).
wallet: Ignore chainStateFlushed notifications while attaching chain
Feb 25 2025, 11:32
PiRK closed D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Feb 25 2025, 11:32
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.

remove first comment which would mess with formatting if left inline and is already explained by the previous block of comments
add a comment as suggested to first call m_attaching_chain = false

Feb 25 2025, 10:37
Fabien accepted D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Feb 25 2025, 10:02
Fabien accepted D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 25 2025, 09:53
Fabien accepted D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 09:52
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.

rebase

Feb 25 2025, 08:34
PiRK accepted D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 08:32
PiRK closed D17688: doc: Improve ZMQ documentation.
Feb 25 2025, 08:31
PiRK committed rABCc52393d22e61: doc: Improve ZMQ documentation (authored by node01 <mbildwic@protonmail.com>).
doc: Improve ZMQ documentation
Feb 25 2025, 08:31
PiRK accepted D17693: [avalanche] Cleanup payout address optionality.
Feb 25 2025, 08:23
PiRK accepted D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 08:22
PiRK closed D17691: test: refactor: use `create_block` parameters.
Feb 25 2025, 08:12
PiRK committed rABCf4d4a586a65b: test: refactor: use `create_block` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: refactor: use `create_block` parameters
Feb 25 2025, 08:12
teamcity added a comment to D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 04:46
roqqit updated the diff for D17696: [avalanche] Make contender test more comprehensive.

rebase

Feb 25 2025, 04:23
roqqit updated the diff for D17695: [avalanche] Make payout scripts unique in contenders test.

skip if wallet isn't available

Feb 25 2025, 04:21
teamcity added a comment to D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 04:20
roqqit requested review of D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 04:16
teamcity added a comment to D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 04:10
roqqit requested review of D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 04:06
teamcity updated the summary of D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 00:02
roqqit requested review of D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 00:02

Feb 24 2025

hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Updated comment

Feb 24 2025, 22:02