Page MenuHomePhabricator
Feed All Stories

Feb 28 2025

bytesofman updated the diff for D17697: [Cashtab] Make sure whitelisted agora tokens load cache first.

rebase

Feb 28 2025, 11:59
bytesofman closed D17678: [Cashtab] Improve test match syntax for token actions.
Feb 28 2025, 11:58
bytesofman committed rABC72fc783ecf32: [Cashtab] Improve test match syntax for token actions (authored by bytesofman).
[Cashtab] Improve test match syntax for token actions
Feb 28 2025, 11:58
bytesofman closed D17719: [monorepo] Add --locked flag to Dockerfiles.
Feb 28 2025, 11:43
bytesofman committed rABCbb6448d072d4: [monorepo] Add --locked flag to Dockerfiles (authored by bytesofman).
[monorepo] Add --locked flag to Dockerfiles
Feb 28 2025, 11:43
Fabien accepted D17719: [monorepo] Add --locked flag to Dockerfiles.
Feb 28 2025, 11:30
Fabien published D17717: [avalanche] Also finalize the ancestors of a transaction for review.
Feb 28 2025, 11:28
bytesofman published D17719: [monorepo] Add --locked flag to Dockerfiles for review.
Feb 28 2025, 11:27
bytesofman closed D17718: [faucet] Add locked to dockerfile.
Feb 28 2025, 11:21
bytesofman committed rABC86501ddaab32: [faucet] Add locked to dockerfile (authored by bytesofman).
[faucet] Add locked to dockerfile
Feb 28 2025, 11:21
Fabien accepted D17718: [faucet] Add locked to dockerfile.
Feb 28 2025, 11:19
bytesofman published D17718: [faucet] Add locked to dockerfile for review.
Feb 28 2025, 11:19
bytesofman closed D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 28 2025, 10:53
bytesofman committed rABCe4dffd6ed660: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token… (authored by bytesofman).
[chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token…
Feb 28 2025, 10:53
Fabien accepted D17714: index: fix reindex-chainstate with active indexes.
Feb 28 2025, 09:43
Fabien requested changes to D17700: [avalanche] Process responses to stake contender polls.
Feb 28 2025, 09:39
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.

use -noparkdeepreorg and mine 5 blocks

Feb 28 2025, 07:47

Feb 27 2025

emack added a comment to D17701: [Cashtab] Support one-click redemptions.

v3.14.0 on the netlify instance after multiple refreshes

Feb 27 2025, 23:00
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

only call slpSend with bigints

Feb 27 2025, 22:37
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 27 2025, 22:24
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, name/type/spacing nit updates per comments

Feb 27 2025, 22:02
tobias_ruck accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 27 2025, 21:52
Mengerian closed D17715: [e.cash] Tweak Build page wordings.
Feb 27 2025, 21:39
Mengerian committed rABC2cf7b56c1159: [e.cash] Tweak Build page wordings (authored by Mengerian).
[e.cash] Tweak Build page wordings
Feb 27 2025, 21:39
roqqit abandoned D17582: [avalanche] Add an invalidation latch to contender cache.

no longer needed since D17710

Feb 27 2025, 21:27
roqqit closed D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 21:25
roqqit committed rABCdc136cfed9c4: [avalanche] Simplify contenders by treating rejection and invalidation the same (authored by roqqit).
[avalanche] Simplify contenders by treating rejection and invalidation the same
Feb 27 2025, 21:25
roqqit updated the summary of D17700: [avalanche] Process responses to stake contender polls.
Feb 27 2025, 21:24
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.
  • rebase on D17710
  • fixed some checks in the functional test not checking what we think they're checking (sort() returns nothing)
  • added a version of setStakingRewardWinners that preserves proofids and does not attempt to re-update the cache
Feb 27 2025, 21:23
Fabien accepted D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 21:20
roqqit updated the diff for D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.

re-add and fixup test case for invalidation after finalization

Feb 27 2025, 21:20
Fabien accepted D17715: [e.cash] Tweak Build page wordings.
Feb 27 2025, 20:38
Fabien requested changes to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 20:38
Fabien requested changes to D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 20:25
Mengerian requested review of D17715: [e.cash] Tweak Build page wordings.
Feb 27 2025, 19:42
hazzarust abandoned D17272: [CHRONIK][WEB][MODULES] Updated every out of date dependency in Cargo.toml that does not require code change.
Feb 27 2025, 19:23
roqqit requested review of D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 18:29
Mengerian closed D17712: [e.cash] Update copy on Build page.
Feb 27 2025, 17:10
Mengerian committed rABC263f713c3c3e: [e.cash] Update copy on Build page (authored by Mengerian).
[e.cash] Update copy on Build page
Feb 27 2025, 17:10
Mengerian updated the diff for D17712: [e.cash] Update copy on Build page.

Tighten up wording per review comments

Feb 27 2025, 17:00
roqqit closed D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Feb 27 2025, 16:47
roqqit committed rABCb0cae7ddadea: [avalanche] Return proofids in addition to payout scripts in getWinners (authored by roqqit).
[avalanche] Return proofids in addition to payout scripts in getWinners
Feb 27 2025, 16:47
PiRK added inline comments to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 16:04
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.

fix clang-tidy style error, fix test flakiness (mine enough new block to trigger automatic unparking on the other node, 5 was not enough)

Feb 27 2025, 15:58
teamcity added a comment to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:24
teamcity added a comment to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:17
PiRK planned changes to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:17
teamcity added a comment to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:15
teamcity updated the summary of D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:10
PiRK requested review of D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:10
bytesofman added inline comments to D17701: [Cashtab] Support one-click redemptions.
Feb 27 2025, 14:05
bytesofman added a comment to D17701: [Cashtab] Support one-click redemptions.

Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.

Feb 27 2025, 14:04
bytesofman updated the diff for D17701: [Cashtab] Support one-click redemptions.

Show "you receive" amount for FIRMA redemptions

Feb 27 2025, 14:03
hazzarust committed rABC344ee6e4aeb3: [chronik] Add an integration test for the blockchain_info endpoint in… (authored by hazzarust).
[chronik] Add an integration test for the blockchain_info endpoint in…
Feb 27 2025, 13:08
hazzarust closed D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 27 2025, 13:08
hazzarust committed rABC0f4a80e06575: [chronik] Add an integration test for the chronik_info endpoint in bitcoinsuite… (authored by hazzarust).
[chronik] Add an integration test for the chronik_info endpoint in bitcoinsuite…
Feb 27 2025, 13:07
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

rebase

Feb 27 2025, 12:54
emack added a comment to D17701: [Cashtab] Support one-click redemptions.

Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.

Feb 27 2025, 11:39
Fabien closed D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:25
Fabien committed rABCba974a9c5381: Prevent occasional timeout in feature_assumevalid (authored by Fabien).
Prevent occasional timeout in feature_assumevalid
Feb 27 2025, 10:25
PiRK closed D17706: refactor: use std::string for thread names.
Feb 27 2025, 10:21
PiRK committed rABC2d464809a97d: refactor: use std::string for thread names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for thread names
Feb 27 2025, 10:21
PiRK committed rABC3926deb8fa05: refactor: use std::string for index names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for index names
Feb 27 2025, 10:21
PiRK closed D17707: refactor: use std::string for index names.
Feb 27 2025, 10:21
PiRK closed D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 27 2025, 10:21
PiRK committed rABC94e4f949ce51: indexes, refactor: Pass Chain interface instead of CChainState class to indexes (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Pass Chain interface instead of CChainState class to indexes
Feb 27 2025, 10:21
teamcity added a comment to D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:16
Fabien updated the diff for D17713: Prevent occasional timeout in feature_assumevalid.

Remove stupid timeout

Feb 27 2025, 10:15
PiRK accepted D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:15
teamcity added a comment to D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:14
Fabien updated the diff for D17713: Prevent occasional timeout in feature_assumevalid.

Remove debug statements

Feb 27 2025, 10:07
Fabien planned changes to D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:05
Fabien requested review of D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:05
Fabien accepted D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Feb 27 2025, 08:22
Fabien requested changes to D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 27 2025, 08:19
Fabien accepted D17706: refactor: use std::string for thread names.
Feb 27 2025, 08:15
teamcity added a comment to D17706: refactor: use std::string for thread names.
Feb 27 2025, 07:34
PiRK closed D17686: [chronik] add Electrum RPC server.donation_address.
Feb 27 2025, 07:28
PiRK committed rABC1e96a8544247: [chronik] add Electrum RPC server.donation_address (authored by PiRK).
[chronik] add Electrum RPC server.donation_address
Feb 27 2025, 07:28
PiRK updated the diff for D17706: refactor: use std::string for thread names.

remove unused include

Feb 27 2025, 07:23
PiRK updated the diff for D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.

remove unnecessary forward declaration

Feb 27 2025, 07:22
bytesofman accepted D17712: [e.cash] Update copy on Build page.

some suggestions trying to tighten up the copy, go with whatever you think is best. I don't think anyone reads something longer than a full sentence on the internet anymore. But we really only need a handful of people who "get it" to see this stuff, so I don't think we need to worry about general consumption too much here.

Feb 27 2025, 04:07
teamcity added a comment to D17712: [e.cash] Update copy on Build page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41502 for the next 60 minutes.

Feb 27 2025, 03:59
teamcity awarded D17712: [e.cash] Update copy on Build page a Doubloon token.
Feb 27 2025, 03:58
bytesofman added a comment to D17712: [e.cash] Update copy on Build page.

@bot preview-e.cash

Feb 27 2025, 03:58
teamcity added a comment to D17712: [e.cash] Update copy on Build page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41146 for the next 60 minutes.

Feb 27 2025, 01:11
teamcity awarded D17712: [e.cash] Update copy on Build page a Piece of Eight token.
Feb 27 2025, 01:10
bytesofman added a comment to D17712: [e.cash] Update copy on Build page.

@bot preview-e.cash

Feb 27 2025, 01:10
Mengerian published D17712: [e.cash] Update copy on Build page for review.
Feb 27 2025, 01:09
teamcity awarded D17712: [e.cash] Update copy on Build page a Haypence token.
Feb 27 2025, 00:40

Feb 26 2025

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update proto script, patch lingering "value:" keys in READMEs, downstream impacts of proto script update (other bigints, type handling)

Feb 26 2025, 22:54
roqqit requested review of D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Feb 26 2025, 22:51
roqqit requested review of D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 26 2025, 22:34
tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 26 2025, 20:57
Fabien accepted D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 26 2025, 20:34
Fabien accepted D17709: [Cashtab] Parse firma yield txs.
Feb 26 2025, 20:20
Fabien accepted D17708: [Cashtab] Update token scam prevention list.
Feb 26 2025, 20:16
Fabien accepted D17707: refactor: use std::string for index names.
Feb 26 2025, 20:16
Fabien requested changes to D17706: refactor: use std::string for thread names.
Feb 26 2025, 20:13
Fabien added a comment to D17701: [Cashtab] Support one-click redemptions.

Since the button will only work based on the external api, it's better to not show the button if the api is unavailable for some reason.
I suggest you do this:

  1. Attempt to retrieve the price from that endpoint
  2. If not successful, don't show the button. Otherwise show the button with the actual price, like "Redeem FIRMA for 1234 XEC"
  3. Not sure if it's worth refreshing periodically (in the even the price changes quickly)
Feb 26 2025, 20:10