Page MenuHomePhabricator
Feed Advanced Search

Jul 5 2025

PiRK updated the diff for D18324: [electrum] refactor: move Send tab to its own module.

rebase, addressed feedback in parent diffs, fixed more instances of amount_e being accessed in main_window

Jul 5 2025, 14:16
PiRK updated the summary of D18331: [electrum] fix update of amounts when changing unit.
Jul 5 2025, 13:12
PiRK requested review of D18331: [electrum] fix update of amounts when changing unit.
Jul 5 2025, 13:12
PiRK requested review of D18330: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate.
Jul 5 2025, 12:38
PiRK requested review of D18329: [electrum] remove shortcut reference to InvoiceStore in MainWindow.
Jul 5 2025, 12:01
PiRK closed D18325: [electrum] move format_fee_rate to amount.py.
Jul 5 2025, 10:04
PiRK committed rABCc1e03d985e4d: [electrum] move format_fee_rate to amount.py (authored by PiRK).
[electrum] move format_fee_rate to amount.py
Jul 5 2025, 10:04
PiRK accepted D18327: [Cashtab] Convert Collection tests to ts.
Jul 5 2025, 10:04
PiRK accepted D18326: [avalanche] Templatize the AvalancheTestingSetup.
Jul 5 2025, 10:03

Jul 4 2025

PiRK updated the diff for D18325: [electrum] move format_fee_rate to amount.py.

remove uneeded import

Jul 4 2025, 09:56
PiRK requested review of D18325: [electrum] move format_fee_rate to amount.py.
Jul 4 2025, 09:54
PiRK committed rABC3295e196b74a: [electrum] remove more dynamic fee related dead code (authored by PiRK).
[electrum] remove more dynamic fee related dead code
Jul 4 2025, 09:43
PiRK closed D18319: [electrum] remove more dynamic fee related dead code.
Jul 4 2025, 09:43
PiRK updated the test plan for D18324: [electrum] refactor: move Send tab to its own module.
Jul 4 2025, 07:13
PiRK published D18324: [electrum] refactor: move Send tab to its own module for review.
Jul 4 2025, 07:11

Jul 3 2025

PiRK closed D18317: [electrum] move format_amount* functions from main_window to amount.py.
Jul 3 2025, 21:05
PiRK committed rABCfede0f2728a6: [electrum] move format_amount* functions from main_window to amount.py (authored by PiRK).
[electrum] move format_amount* functions from main_window to amount.py
Jul 3 2025, 21:05
PiRK closed D18316: [electrum] move-only: move amount formatting functions from util to amount.py.
Jul 3 2025, 21:05
PiRK committed rABC372b032bfb11: [electrum] move-only: move amount formatting functions from util to amount.py (authored by PiRK).
[electrum] move-only: move amount formatting functions from util to amount.py
Jul 3 2025, 21:05
PiRK updated the summary of D18319: [electrum] remove more dynamic fee related dead code.
Jul 3 2025, 14:31
PiRK updated the diff for D18316: [electrum] move-only: move amount formatting functions from util to amount.py.

import the correct _ (the other one is going away in D18319)

Jul 3 2025, 14:30
PiRK requested review of D18319: [electrum] remove more dynamic fee related dead code.
Jul 3 2025, 14:26
PiRK added inline comments to D18316: [electrum] move-only: move amount formatting functions from util to amount.py.
Jul 3 2025, 14:01
PiRK updated the diff for D18317: [electrum] move format_amount* functions from main_window to amount.py.

fix more occurences of subwidgets calling the main_window to format amounts

Jul 3 2025, 11:57
PiRK planned changes to D18317: [electrum] move format_amount* functions from main_window to amount.py.

i'm missing someting in transaction_dialog

Jul 3 2025, 11:36
PiRK requested review of D18317: [electrum] move format_amount* functions from main_window to amount.py.
Jul 3 2025, 11:33
PiRK requested review of D18316: [electrum] move-only: move amount formatting functions from util to amount.py.
Jul 3 2025, 11:30
PiRK closed D18315: [electrum] remove a few unused instance attributes for menus and actions.
Jul 3 2025, 09:46
PiRK committed rABCb9f45c11da7c: [electrum] remove a few unused instance attributes for menus and actions (authored by PiRK).
[electrum] remove a few unused instance attributes for menus and actions
Jul 3 2025, 09:46
PiRK closed D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 3 2025, 09:46
PiRK committed rABC4057da0bea9d: [electrum] Qt6 transition, step 2: minimal changes to make the app start with… (authored by PiRK).
[electrum] Qt6 transition, step 2: minimal changes to make the app start with…
Jul 3 2025, 09:46
PiRK accepted D18312: test: Move P2SH_OP_TRUE to shared test library.
Jul 3 2025, 06:39

Jul 2 2025

PiRK requested review of D18315: [electrum] remove a few unused instance attributes for menus and actions.
Jul 2 2025, 20:34
PiRK updated the diff for D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.

apply feedback

Jul 2 2025, 20:20
PiRK added inline comments to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 2 2025, 20:18
PiRK accepted D18314: bench: BlockAssembler on a mempool with packages.
Jul 2 2025, 20:04
PiRK accepted D18313: test: Misc refactor to get rid of &foo[0] raw pointers.
Jul 2 2025, 19:52
PiRK requested changes to D18312: test: Move P2SH_OP_TRUE to shared test library.
Jul 2 2025, 19:48
PiRK added inline comments to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 2 2025, 12:34
PiRK updated the diff for D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.

fix camera (tested by succesfully scanning a CashTab QRCode via a webcam)

Jul 2 2025, 12:21
PiRK updated the summary of D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 2 2025, 12:03
PiRK closed D18309: qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads.
Jul 2 2025, 11:59
PiRK committed rABCaa1da7a665b8: qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads (authored by SomberNight <somber.night@protonmail.com>).
qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads
Jul 2 2025, 11:59
PiRK accepted D18310: [avalanche] Test: move the AvalancheTestingSetup to the common test header.
Jul 2 2025, 11:59
PiRK planned changes to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 2 2025, 11:52
PiRK added a comment to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.

I didn't properly test the scanning of QR codes via the webcam with Qt6, there is still some work left on that front

Jul 2 2025, 11:52
PiRK accepted D18308: [tests] Use ConnmanTestMsg when possible.
Jul 2 2025, 11:48
PiRK requested review of D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
Jul 2 2025, 11:47
PiRK requested review of D18309: qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads.
Jul 2 2025, 09:20
PiRK closed D18306: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy.
Jul 2 2025, 06:18
PiRK committed rABC2eb505151119: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy (authored by PiRK).
[electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy
Jul 2 2025, 06:18

Jul 1 2025

PiRK updated the summary of D18306: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy.
Jul 1 2025, 08:25
PiRK added inline comments to D18306: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy.
Jul 1 2025, 08:23
PiRK requested review of D18306: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy.
Jul 1 2025, 08:17

Jun 30 2025

PiRK accepted D18304: [chronik] Electrum: Add ws and wss transports.
Jun 30 2025, 17:31
PiRK accepted D18303: [Cashtab] Support address sharing for we web wallet.
Jun 30 2025, 13:55
PiRK closed D18293: [electrum] provide a test framework for Electrum ABC functional tests.
Jun 30 2025, 09:55
PiRK committed rABC7296bc8788b8: [electrum] provide a test framework for Electrum ABC functional tests (authored by PiRK).
[electrum] provide a test framework for Electrum ABC functional tests
Jun 30 2025, 09:55
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Mountain of Wealth token.
Jun 30 2025, 08:45

Jun 29 2025

teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Doubloon token.
Jun 29 2025, 13:46
PiRK added a comment to D18293: [electrum] provide a test framework for Electrum ABC functional tests.

@bot electrum-functional-tests

Jun 29 2025, 13:46
PiRK updated the diff for D18293: [electrum] provide a test framework for Electrum ABC functional tests.

print error to stderr
In the future it would be an improvement to use a proper logger.

Jun 29 2025, 13:44
PiRK updated the summary of D18293: [electrum] provide a test framework for Electrum ABC functional tests.
Jun 29 2025, 13:28
PiRK closed D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 29 2025, 13:27
PiRK committed rABCa8368330e72b: [electrum] exclude the regtest directory from the unit test discovery (authored by PiRK).
[electrum] exclude the regtest directory from the unit test discovery
Jun 29 2025, 13:27

Jun 27 2025

PiRK published D18293: [electrum] provide a test framework for Electrum ABC functional tests for review.
Jun 27 2025, 19:10
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Piece of Eight token.
Jun 27 2025, 18:33
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Haypence token.
Jun 27 2025, 18:10
PiRK accepted D18297: [chronik] Electrum: Implement peer validation.
Jun 27 2025, 13:55
PiRK accepted D18300: Bump version to 0.31.8.
Jun 27 2025, 13:46
PiRK accepted D18299: [CI] Update the arcanist mirror.
Jun 27 2025, 13:05
PiRK accepted D18298: [chronik] Electrum: Fix misnamed ssl_port field.
Jun 27 2025, 10:15

Jun 26 2025

PiRK added inline comments to D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 26 2025, 14:41
PiRK added inline comments to D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 26 2025, 13:15
PiRK updated the summary of D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 26 2025, 13:10
PiRK updated the diff for D18295: [electrum] exclude the regtest directory from the unit test discovery.

remove irrelevant commments from a previous iteration

Jun 26 2025, 12:01
PiRK requested review of D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 26 2025, 12:00

Jun 25 2025

PiRK accepted D18292: [chronik] Electrum: Add more verbose fields to transaction.get.
Jun 25 2025, 14:57
PiRK accepted D18291: [chronik] Electrum: fix headers notifications under deep reorgs.
Jun 25 2025, 12:02

Jun 24 2025

PiRK accepted D18286: [chronik] Electrum: send the tip header upon block disconnection.
Jun 24 2025, 13:53
PiRK added inline comments to D18286: [chronik] Electrum: send the tip header upon block disconnection.
Jun 24 2025, 13:51
PiRK accepted D18282: [chronik] Allow to bypass reading the spent_by info for txs outputs.
Jun 24 2025, 13:39
PiRK accepted D18283: Bump version to 0.31.7.
Jun 24 2025, 13:36

Jun 23 2025

PiRK accepted D18281: Skip creating parent directories when accessing a file in read-only mode from filesystem.
Jun 23 2025, 14:30
teamcity awarded D17305: [electrum] try to use modern docker compose command a Mountain of Wealth token.
Jun 23 2025, 12:40

Jun 20 2025

PiRK accepted D18280: [chronik] Electrum: faster status computation.
Jun 20 2025, 20:28
PiRK closed D18276: logging: Replace uses of LogPrintfCategory.
Jun 20 2025, 08:42
PiRK committed rABC59844d444b37: logging: Replace uses of LogPrintfCategory (authored by PiRK).
logging: Replace uses of LogPrintfCategory
Jun 20 2025, 08:42
PiRK closed D18275: logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace.
Jun 20 2025, 08:42
PiRK closed D18274: logging: add -loglevelalways=1 option.
Jun 20 2025, 08:42
PiRK committed rABC8bfb3c69708c: logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace (authored by Anthony Towns <aj@erisian.com.au>).
logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace
Jun 20 2025, 08:42
PiRK committed rABC17e3f6172685: logging: add -loglevelalways=1 option (authored by Anthony Towns <aj@erisian.com.au>).
logging: add -loglevelalways=1 option
Jun 20 2025, 08:42
PiRK closed D18273: logging: treat BCLog::ALL like BCLog::NONE.
Jun 20 2025, 08:42
PiRK committed rABC77368aacdc15: logging: treat BCLog::ALL like BCLog::NONE (authored by Anthony Towns <aj@erisian.com.au>).
logging: treat BCLog::ALL like BCLog::NONE
Jun 20 2025, 08:41
PiRK closed D18272: logging: Drop BCLog::Level::None.
Jun 20 2025, 08:41
PiRK committed rABCfeb3b5d4eede: logging: Drop BCLog::Level::None (authored by Anthony Towns <aj@erisian.com.au>).
logging: Drop BCLog::Level::None
Jun 20 2025, 08:41
PiRK closed D18271: logging: Log Info messages unconditionally.
Jun 20 2025, 08:41
PiRK committed rABC9069de4e2080: logging: Log Info messages unconditionally (authored by Anthony Towns <aj@erisian.com.au>).
logging: Log Info messages unconditionally
Jun 20 2025, 08:41
PiRK committed rABC2f0e990a9d70: logging: make [cat:debug] and [info] implicit (authored by Anthony Towns <aj@erisian.com.au>).
logging: make [cat:debug] and [info] implicit
Jun 20 2025, 08:41
PiRK closed D18270: logging: make [cat:debug] and [info] implicit.
Jun 20 2025, 08:41