Page MenuHomePhabricator
Feed Advanced Search

Jun 4 2019

deadalnix committed rABCc9dc032fea8e: Move WalletRescanner to match Bitcoin Core codebase (authored by deadalnix).
Move WalletRescanner to match Bitcoin Core codebase
Jun 4 2019, 00:32
deadalnix closed D3191: Move WalletRescanner to match Bitcoin Core codebase.
Jun 4 2019, 00:32

Jun 3 2019

deadalnix created D3191: Move WalletRescanner to match Bitcoin Core codebase.
Jun 3 2019, 22:11
D3190: Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads now requires changes to proceed.
Jun 3 2019, 21:41
deadalnix committed rABCdb30cacb5eab: Remove billable size from CTransaction (authored by deadalnix).
Remove billable size from CTransaction
Jun 3 2019, 21:35
deadalnix closed D3189: Remove billable size from CTransaction.
Jun 3 2019, 21:34
deadalnix committed rABC57ecadc9cdb0: Remove billable size from the mempool (authored by deadalnix).
Remove billable size from the mempool
Jun 3 2019, 21:11
deadalnix closed D3188: Remove billable size from the mempool.
Jun 3 2019, 21:11
deadalnix committed rABCff0c9a7556fd: Do not update billable size in descendents (authored by deadalnix).
Do not update billable size in descendents
Jun 3 2019, 21:09
deadalnix closed D3185: Do not update billable size in descendents.
Jun 3 2019, 21:09
deadalnix committed rABCb21803c16d42: Do not update billable size in ancestors (authored by deadalnix).
Do not update billable size in ancestors
Jun 3 2019, 21:05
deadalnix closed D3184: Do not update billable size in ancestors.
Jun 3 2019, 21:05
deadalnix committed rABCcb2cdf6c0670: Remove billable size from mining (authored by deadalnix).
Remove billable size from mining
Jun 3 2019, 21:05
deadalnix closed D3183: Remove billable size from mining.
Jun 3 2019, 21:04
deadalnix created D3189: Remove billable size from CTransaction.
Jun 3 2019, 19:28
deadalnix created D3188: Remove billable size from the mempool.
Jun 3 2019, 19:22
deadalnix committed rABC87136e28b370: Reintroduce the concept of virtual size from core (authored by deadalnix).
Reintroduce the concept of virtual size from core
Jun 3 2019, 19:13
deadalnix closed D3180: Reintroduce the concept of virtual size from core.
Jun 3 2019, 19:13
deadalnix committed rABC033860b2dc60: Deprecate parts of validateaddress and introduce getaddressinfo (authored by Andrew Chow <achow101-github@achow101.com>).
Deprecate parts of validateaddress and introduce getaddressinfo
Jun 3 2019, 19:09
deadalnix closed D3147: Deprecate parts of validateaddress and introduce getaddressinfo.
Jun 3 2019, 19:09
deadalnix added a comment to D3180: Reintroduce the concept of virtual size from core.

nWeight => nSize

Jun 3 2019, 19:06
deadalnix added a comment to D3147: Deprecate parts of validateaddress and introduce getaddressinfo.

Rebase and update version number

Jun 3 2019, 18:57
D3187: Fix Gitian instructions to setup LXC container networking on Debian is now accepted and ready to land.

I trust this works.

Jun 3 2019, 18:46
deadalnix created D3185: Do not update billable size in descendents.
Jun 3 2019, 16:30
deadalnix created D3184: Do not update billable size in ancestors.
Jun 3 2019, 16:28
deadalnix created D3183: Remove billable size from mining.
Jun 3 2019, 15:56
deadalnix created D3180: Reintroduce the concept of virtual size from core.
Jun 3 2019, 13:37
D3179: Improve ZMQ functional test is now accepted and ready to land.
Jun 3 2019, 12:38
deadalnix committed rABC0dc28f1dc540: Remove redundant pwallet nullptr check (authored by Matt Corallo <git@bluematt.me>).
Remove redundant pwallet nullptr check
Jun 3 2019, 12:37
deadalnix closed D3177: Remove redundant pwallet nullptr check.
Jun 3 2019, 12:37
deadalnix committed rABC27cd5519cb9c: Add missing locks and locking annotations for CAddrMan (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add missing locks and locking annotations for CAddrMan
Jun 3 2019, 12:34
deadalnix closed D3178: Add missing locks and locking annotations for CAddrMan.
Jun 3 2019, 12:34

Jun 2 2019

D3065: Remove segwit recovery activation now requires changes to proceed.
Jun 2 2019, 23:32
deadalnix accepted D3146: Limit variable scope.
Jun 2 2019, 23:27
deadalnix created D3178: Add missing locks and locking annotations for CAddrMan.
Jun 2 2019, 22:50
deadalnix committed rABC721227f91cc0: [rpc] Move DescribeAddressVisitor to rpc/util (authored by John Newbery <john@johnnewbery.com>).
[rpc] Move DescribeAddressVisitor to rpc/util
Jun 2 2019, 22:38
deadalnix closed D3139: [rpc] Move DescribeAddressVisitor to rpc/util.
Jun 2 2019, 22:38
deadalnix committed rABCf7303442ac75: [rpc] split wallet and non-wallet parts of DescribeAddressVisitor (authored by John Newbery <john@johnnewbery.com>).
[rpc] split wallet and non-wallet parts of DescribeAddressVisitor
Jun 2 2019, 22:35
deadalnix closed D3138: [rpc] split wallet and non-wallet parts of DescribeAddressVisitor.
Jun 2 2019, 22:35
deadalnix committed rABCbf7fc5c03679: (finally) remove getinfo in favor of more module-specific infos (authored by Matt Corallo <git@bluematt.me>).
(finally) remove getinfo in favor of more module-specific infos
Jun 2 2019, 22:33
deadalnix closed D3120: (finally) remove getinfo in favor of more module-specific infos.
Jun 2 2019, 22:33
deadalnix added a comment to D3120: (finally) remove getinfo in favor of more module-specific infos.

Rbase and add release notes.

Jun 2 2019, 13:04
deadalnix created D3177: Remove redundant pwallet nullptr check.
Jun 2 2019, 12:44

Jun 1 2019

deadalnix committed rABC3e582969e5b9: Fix wallet RPC race by waiting for callbacks in sendrawtransaction (authored by Matt Corallo <git@bluematt.me>).
Fix wallet RPC race by waiting for callbacks in sendrawtransaction
Jun 1 2019, 15:48
deadalnix closed D3165: Fix wallet RPC race by waiting for callbacks in sendrawtransaction.
Jun 1 2019, 15:48
deadalnix committed rABCb728870a8d8c: Also call other wallet notify callbacks in scheduler thread (authored by Matt Corallo <git@bluematt.me>).
Also call other wallet notify callbacks in scheduler thread
Jun 1 2019, 14:25
deadalnix closed D3156: Also call other wallet notify callbacks in scheduler thread.
Jun 1 2019, 14:25
deadalnix committed rABCc2d3aa1d5819: Add tests to SingleThreadedSchedulerClient() and document the memory model (authored by Jesse Cohen <jc@jc.lol>).
Add tests to SingleThreadedSchedulerClient() and document the memory model
Jun 1 2019, 13:57
deadalnix closed D3169: Add tests to SingleThreadedSchedulerClient() and document the memory model.
Jun 1 2019, 13:56
deadalnix committed rABC7aa201bef607: Various improvements to the scheduler (authored by deadalnix).
Various improvements to the scheduler
Jun 1 2019, 13:38
deadalnix closed D3167: Various improvements to the scheduler.
Jun 1 2019, 13:38
deadalnix closed D3168: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending.
Jun 1 2019, 13:32
deadalnix committed rABC3ae0985d7efb: scheduler: Add Clang thread safety annotations for variables guarded by… (authored by practicalswift <practicalswift@users.noreply.github.com>).
scheduler: Add Clang thread safety annotations for variables guarded by…
Jun 1 2019, 13:32
deadalnix committed rABCa517dc381d85: unsigned char => uint8_t (authored by deadalnix).
unsigned char => uint8_t
Jun 1 2019, 13:31
deadalnix closed D3170: unsigned char => uint8_t.
Jun 1 2019, 13:31
deadalnix added inline comments to D3152: Added release.sh script for generating a release commit.
Jun 1 2019, 13:07
deadalnix added a comment to T366: Fix CVE-2018-12356 by hardening the regex..

The main reason is that we aren't using that script, that therefore it is low priority to do so and that no diff has been open for it.

Jun 1 2019, 12:49 · Restricted Project

May 31 2019

deadalnix requested review of D3165: Fix wallet RPC race by waiting for callbacks in sendrawtransaction.
May 31 2019, 17:58
deadalnix requested changes to D3152: Added release.sh script for generating a release commit.

This seems to be an extremely convoluted way to launch one command that you could launch directly instead of using this. This does nothing to help the slow part of the process, where you need to submit a patch, get it reviewed land it. There are no guarantee that this will generate the proper man pages, because the manpage generated will be dependent on the system on which the software is built.

May 31 2019, 17:24
deadalnix accepted D3174: Bump version number to 0.19.8.
May 31 2019, 17:07
Herald added a reviewer for D3170: unsigned char => uint8_t: Restricted Project.
May 31 2019, 13:20
Herald added a reviewer for D3169: Add tests to SingleThreadedSchedulerClient() and document the memory model: Restricted Project.
May 31 2019, 12:53
Herald added a reviewer for D3168: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending: Restricted Project.
May 31 2019, 12:33
Herald added a reviewer for D3167: Various improvements to the scheduler: Restricted Project.
May 31 2019, 11:59
deadalnix accepted D3162: [mining] Add a test for TestCBlockTemplateEntry.
May 31 2019, 07:46
deadalnix accepted D3166: [nit] do not capture unused `this` in wallet interface.
May 31 2019, 07:29
Herald added a reviewer for D3165: Fix wallet RPC race by waiting for callbacks in sendrawtransaction: Restricted Project.
May 31 2019, 07:01
deadalnix committed rABCe7005b7fe82c: Reoder various argument declarations (authored by deadalnix).
Reoder various argument declarations
May 31 2019, 05:50
deadalnix closed D3161: Reoder various argument declarations.
May 31 2019, 05:50

May 30 2019

Herald added a reviewer for D3161: Reoder various argument declarations: Restricted Project.
May 30 2019, 22:42
deadalnix accepted D3157: [Tests] Require exact match in assert_start_raises_init_eror().
May 30 2019, 13:34
deadalnix committed rABC17c966b4c03a: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread (authored by Matt Corallo <git@bluematt.me>).
Give ZMQ consistent order with UpdatedBlockTip on scheduler thread
May 30 2019, 12:03
deadalnix closed D3154: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread.
May 30 2019, 12:03
Herald added a reviewer for D3156: Also call other wallet notify callbacks in scheduler thread: Restricted Project.
May 30 2019, 01:17
Herald added a reviewer for D3154: Give ZMQ consistent order with UpdatedBlockTip on scheduler thread: Restricted Project.
May 30 2019, 01:08

May 29 2019

deadalnix added a comment to D3151: Don't use the functional test arguments in the tmp directory name.

It begs the question, what is core doing and why are we doing something different.

May 29 2019, 23:02
deadalnix accepted D3151: Don't use the functional test arguments in the tmp directory name.
May 29 2019, 23:01
deadalnix accepted D3150: wallet: Display non-HD error on first run.
May 29 2019, 20:41
deadalnix requested changes to D3148: Invert meaning of Segwit Recovery flag..
May 29 2019, 15:12
deadalnix requested changes to D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.

That is not necessary.

May 29 2019, 15:03
deadalnix accepted D3145: Merge #10056: [zmq] Call va_end() on va_start()ed args..
May 29 2019, 15:03

May 28 2019

Herald added a reviewer for D3147: Deprecate parts of validateaddress and introduce getaddressinfo: Restricted Project.
May 28 2019, 23:43
deadalnix accepted D3105: Create new wallet databases as directories rather than files.
May 28 2019, 17:29
deadalnix accepted D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
May 28 2019, 16:52
deadalnix accepted D2938: index: Move index DBs into index/ directory..
May 28 2019, 15:27
deadalnix added inline comments to D2938: index: Move index DBs into index/ directory..
May 28 2019, 15:26
deadalnix accepted D3104: Allow wallet files not in -walletdir directory.
May 28 2019, 15:24
deadalnix requested changes to D3105: Create new wallet databases as directories rather than files.
May 28 2019, 15:23
deadalnix requested changes to D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
May 28 2019, 15:22
deadalnix committed rABC999fe62d4074: Support downgrading after recovered keypool witness keys (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Support downgrading after recovered keypool witness keys
May 28 2019, 14:12
deadalnix closed D3134: Support downgrading after recovered keypool witness keys.
May 28 2019, 14:12
deadalnix committed rABC7ab304b79261: SegWit wallet support (authored by Pieter Wuille <pieter.wuille@gmail.com>).
SegWit wallet support
May 28 2019, 14:09
deadalnix closed D3133: SegWit wallet support.
May 28 2019, 14:09
deadalnix updated the diff for D3133: SegWit wallet support.

Fix more doc

May 28 2019, 14:09
deadalnix updated the diff for D3133: SegWit wallet support.

Remove address type from the RPC doc.
Add missed backport in wallet.cpp

May 28 2019, 11:47
deadalnix accepted D3141: [CMAKE] Fix Miniupnpc error message.
May 28 2019, 11:46
deadalnix committed rABCfa09461d4e80: Remove IsSolvable (authored by deadalnix).
Remove IsSolvable
May 28 2019, 11:30
deadalnix closed D3136: Remove IsSolvable.
May 28 2019, 11:30
deadalnix committed rABC0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Simplify "bool x = y ? true : false". Remove unused function and trailing…
May 28 2019, 11:26
deadalnix closed D3137: Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon..
May 28 2019, 11:26