Page MenuHomePhabricator
Feed All Stories

Jun 17 2019

D3355: Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running is now accepted and ready to land.
Jun 17 2019, 23:02
teamcity added a comment to D3359: Replumb ibd.sh to prepare for better post-IBD checks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 22:57
teamcity added a comment to D3359: Replumb ibd.sh to prepare for better post-IBD checks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 22:50
jasonbcox planned changes to D3359: Replumb ibd.sh to prepare for better post-IBD checks.
Jun 17 2019, 22:50
jasonbcox created D3359: Replumb ibd.sh to prepare for better post-IBD checks.
Jun 17 2019, 22:50
nakihito added a comment to D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.

While there probably isn't very much practical use for the information, I'd image it would be better to deprecate that functionality rather than just outright remove it.

Jun 17 2019, 22:28
Nico Guiton <nico@bitframe.org> committed rABCf760e536af9a: Merge #10577: Add an explanation of quickly hashing onto a non-power of two… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10577: Add an explanation of quickly hashing onto a non-power of two…
Jun 17 2019, 21:23
Nico Guiton <nico@bitframe.org> closed D3356: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range..
Jun 17 2019, 21:22
markblundeberg added a comment to D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.

With patch:

{
  "chain": "test",
  "blocks": 1309568,
  "headers": 1303313,
  "bestblockhash": "0000000000000c97db875750712183dc3d608d225e275ce992a647ba084ea848",
  "difficulty": 842811.5393743159,
  "mediantime": 1560802822,
  "verificationprogress": 0.9999993508198258,
  "initialblockdownload": false,
  "chainwork": "00000000000000000000000000000000000000000000004f5d4024d8d2d6fd56",
  "size_on_disk": 26073090536,
  "pruned": false,
  "warnings": ""
}
Jun 17 2019, 21:13
teamcity added a comment to D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 21:03
jasonbcox added a comment to D3357: Cleanup unnecessary subshell in ibd.sh.

This works worse in the failure case where bitcoind crashes mid-IBD.

Jun 17 2019, 21:00
teamcity added a comment to D3357: Cleanup unnecessary subshell in ibd.sh.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 20:59
D3356: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range. is now accepted and ready to land.
Jun 17 2019, 20:56
markblundeberg updated the test plan for D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.
Jun 17 2019, 20:54
teamcity added a comment to D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 20:53
markblundeberg created D3358: [rpc] deprecate ancient softforks' information from getblockchaininfo.
Jun 17 2019, 20:53
teamcity added a comment to D3357: Cleanup unnecessary subshell in ibd.sh.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 20:53
jasonbcox planned changes to D3357: Cleanup unnecessary subshell in ibd.sh.
Jun 17 2019, 20:52
jasonbcox created D3357: Cleanup unnecessary subshell in ibd.sh.
Jun 17 2019, 20:52
teamcity added a comment to D3356: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 20:26
teamcity added a comment to D3356: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 20:20
nakihito created D3356: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range..
Jun 17 2019, 20:20
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 18:52
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 18:44
nakihito added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Changed amount to pass by reference again.

Jun 17 2019, 18:44
teamcity added a comment to D3355: Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 18:38
teamcity added a comment to D3355: Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 18:32
nakihito created D3355: Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running.
Jun 17 2019, 18:32
jasonbcox accepted D3336: tests: Avoid copies of CTransaction.
Jun 17 2019, 17:33
D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.
Jun 17 2019, 17:32
teamcity added a comment to D3336: tests: Avoid copies of CTransaction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 17:20
jasonbcox committed rABC63419dd727ff: Cleanup ibd.sh (authored by jasonbcox).
Cleanup ibd.sh
Jun 17 2019, 17:14
jasonbcox closed D3340: Cleanup ibd.sh.
Jun 17 2019, 17:14
teamcity added a comment to D3336: tests: Avoid copies of CTransaction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 17:12
deadalnix added a comment to D3336: tests: Avoid copies of CTransaction.

Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.

Jun 17 2019, 17:12
D3342: Use mempool's descendent count in the wallet code is now accepted and ready to land.
Jun 17 2019, 17:00
D3352: Restore minRelayTxFee is now accepted and ready to land.
Jun 17 2019, 16:56
D3340: Cleanup ibd.sh is now accepted and ready to land.
Jun 17 2019, 16:55
jasonbcox added a comment to D3340: Cleanup ibd.sh.

IBD passed

Jun 17 2019, 16:51
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 16:34
deadalnix added inline comments to D3336: tests: Avoid copies of CTransaction.
Jun 17 2019, 16:31
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 16:27
deadalnix added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Remove witness overhead

Jun 17 2019, 16:27
teamcity added a comment to D3352: Restore minRelayTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 15:46
teamcity added a comment to D3352: Restore minRelayTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 15:39
deadalnix added a comment to D3352: Restore minRelayTxFee.

Fix comment

Jun 17 2019, 15:39
teamcity added a comment to D3354: Clarify include guard naming convention.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 14:30
teamcity added a comment to D3354: Clarify include guard naming convention.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 14:24
Fabien created D3354: Clarify include guard naming convention.
Jun 17 2019, 14:23
deadalnix requested review of D3342: Use mempool's descendent count in the wallet code.
Jun 17 2019, 14:00
deadalnix committed rABC79d37414f1ac: Dead code removal (authored by Thomas Snider <tjps636@gmail.com>).
Dead code removal
Jun 17 2019, 13:59
deadalnix closed D3349: Dead code removal.
Jun 17 2019, 13:59
Fabien committed rABCbaca373a81a8: [LINTER] Set the rules for the phpdoc comments (authored by Fabien).
[LINTER] Set the rules for the phpdoc comments
Jun 17 2019, 11:12
Fabien closed D3334: [LINTER] Set the rules for the phpdoc comments.
Jun 17 2019, 11:12
Fabien committed rABCa330cd7bffce: Add benchmark for AES (authored by Fabien).
Add benchmark for AES
Jun 17 2019, 11:11
Fabien closed D3341: Add benchmark for AES.
Jun 17 2019, 11:11
D3353: Restore CWallet::minTxFee is now accepted and ready to land.
Jun 17 2019, 10:18
D3352: Restore minRelayTxFee now requires changes to proceed.

One nit, looks good otherwise.

Jun 17 2019, 10:06
D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it now requires changes to proceed.
Jun 17 2019, 09:36
D3349: Dead code removal is now accepted and ready to land.
Jun 17 2019, 07:27
D3348: Implement getRequiredFee in the node interface and use it is now accepted and ready to land.
Jun 17 2019, 07:22
D3336: tests: Avoid copies of CTransaction now requires changes to proceed.

See Jason's comments, clearing my queue.

Jun 17 2019, 07:18
Fabien accepted D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.
Jun 17 2019, 07:17
D3343: [refactor] Make TransactionWithinChainLimit more flexible now requires changes to proceed.
Jun 17 2019, 07:09
D3342: Use mempool's descendent count in the wallet code now requires changes to proceed.
Jun 17 2019, 07:07
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14085: index: Fix for indexers skipping genesis block.
Jun 17 2019, 03:13
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Jun 17 2019, 03:13
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 03:13
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Jun 17 2019, 03:08
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 03:07
markblundeberg added a comment to D3253: Remove Schnorr activation.

remove mocktiming

Jun 17 2019, 03:07
markblundeberg updated the summary of D3350: [script_tests] improve test coverage of minimal push rules.
Jun 17 2019, 03:01
teamcity added a comment to D3353: Restore CWallet::minTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 17 2019, 00:56
teamcity added a comment to D3353: Restore CWallet::minTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 17 2019, 00:49
deadalnix created D3353: Restore CWallet::minTxFee.
Jun 17 2019, 00:49
D3253: Remove Schnorr activation now requires changes to proceed.
Jun 17 2019, 00:23

Jun 16 2019

teamcity added a comment to D3352: Restore minRelayTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 23:02
teamcity added a comment to D3352: Restore minRelayTxFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 22:53
deadalnix created D3352: Restore minRelayTxFee.
Jun 16 2019, 22:53
schancel committed rABC0965d7294845: Fix lock reference in miner.h (authored by schancel).
Fix lock reference in miner.h
Jun 16 2019, 21:51
schancel closed D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:50
teamcity added a comment to D3351: Fix lock reference in miner.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 21:44
D3351: Fix lock reference in miner.h is now accepted and ready to land.
Jun 16 2019, 21:41
schancel updated the test plan for D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:40
schancel retitled D3351: Fix lock reference in miner.h from Fix lock reference in miner.cpp to Fix lock reference in miner.h.
Jun 16 2019, 21:37
teamcity added a comment to D3351: Fix lock reference in miner.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 21:37
schancel created D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:37
teamcity added a comment to D3350: [script_tests] improve test coverage of minimal push rules.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 16:37
teamcity added a comment to D3350: [script_tests] improve test coverage of minimal push rules.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 16:30
teamcity added a comment to D3350: [script_tests] improve test coverage of minimal push rules.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 16:26
markblundeberg added a comment to D3350: [script_tests] improve test coverage of minimal push rules.

oops, some tests duplicated

Jun 16 2019, 16:26
markblundeberg planned changes to D3350: [script_tests] improve test coverage of minimal push rules.
Jun 16 2019, 16:24
teamcity added a comment to D3350: [script_tests] improve test coverage of minimal push rules.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 16:24
markblundeberg created D3350: [script_tests] improve test coverage of minimal push rules.
Jun 16 2019, 16:24
teamcity added a comment to D3349: Dead code removal.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 15:19
teamcity added a comment to D3349: Dead code removal.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 15:13
deadalnix created D3349: Dead code removal.
Jun 16 2019, 15:12
teamcity added a comment to D3348: Implement getRequiredFee in the node interface and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 16 2019, 14:23
teamcity added a comment to D3348: Implement getRequiredFee in the node interface and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 16 2019, 14:16
deadalnix created D3348: Implement getRequiredFee in the node interface and use it.
Jun 16 2019, 14:16