Page MenuHomePhabricator
Feed All Stories

Oct 15 2024

tobias_ruck closed D16912: [ecash-lib] Add missing `modules/ecash-lib-wasm` to a few CI tests.
Oct 15 2024, 19:30
tobias_ruck committed rABC11d9f816adfe: [ecash-lib] Add missing `modules/ecash-lib-wasm` to a few CI tests (authored by tobias_ruck).
[ecash-lib] Add missing `modules/ecash-lib-wasm` to a few CI tests
Oct 15 2024, 19:30
Fabien added inline comments to D16896: [Cashtab] Support testnet with env variable.
Oct 15 2024, 19:28
Fabien accepted D16500: [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 19:22
Fabien accepted D16912: [ecash-lib] Add missing `modules/ecash-lib-wasm` to a few CI tests.
Oct 15 2024, 19:19
tobias_ruck added inline comments to D16896: [Cashtab] Support testnet with env variable.
Oct 15 2024, 16:55
tobias_ruck requested review of D16912: [ecash-lib] Add missing `modules/ecash-lib-wasm` to a few CI tests.
Oct 15 2024, 16:53
bytesofman updated the test plan for D16911: [ecash-herald] Support daily summary msgs.
Oct 15 2024, 15:44
bytesofman updated the diff for D16911: [ecash-herald] Support daily summary msgs.

syntax improvement

Oct 15 2024, 15:43
bytesofman updated the diff for D16911: [ecash-herald] Support daily summary msgs.

show %s for miners and stakers, better formatting, show the thru-blockheight

Oct 15 2024, 15:42
teamcity awarded D16902: Deprecate the ARM (32 bits) variant a Piece of Eight token.
Oct 15 2024, 15:28
Fabien added a comment to D16902: Deprecate the ARM (32 bits) variant.

@bot guix-linux

Oct 15 2024, 15:28
PiRK updated the diff for D16908: [seeder] Fix such that seeder node awaits both headers and addr messages.

remove useless return, fix comment nit, use MainNet testing setup for new test (needed after changing HasCheckPoint in parent diff)

Oct 15 2024, 14:24
Fabien updated the diff for D16902: Deprecate the ARM (32 bits) variant.

Fix the CI guix-linux build

Oct 15 2024, 14:18
PiRK updated the diff for D16500: [seeder] Mark nodes as unreliable until checkpoint verified.

use GetRequireHeight in HasCheckpoint

Oct 15 2024, 14:18
PiRK updated the diff for D16500: [seeder] Mark nodes as unreliable until checkpoint verified.

check last checkpoint height to decide whether checkpoints should be validated
This requires a unit test to now use the MainNet params.

Oct 15 2024, 14:16
Fabien planned changes to D16902: Deprecate the ARM (32 bits) variant.
Oct 15 2024, 13:48
Fabien requested changes to D16911: [ecash-herald] Support daily summary msgs.
Oct 15 2024, 13:14
bytesofman updated the test plan for D16896: [Cashtab] Support testnet with env variable.
Oct 15 2024, 12:25
bytesofman added inline comments to D16896: [Cashtab] Support testnet with env variable.
Oct 15 2024, 12:23
bytesofman updated the diff for D16896: [Cashtab] Support testnet with env variable.

change explorer for testnet, addr prefix in app config, disable swap page

Oct 15 2024, 12:21
teamcity added a comment to D16902: Deprecate the ARM (32 bits) variant.
Oct 15 2024, 12:19
bytesofman updated the test plan for D16911: [ecash-herald] Support daily summary msgs.
Oct 15 2024, 11:56
bytesofman published D16911: [ecash-herald] Support daily summary msgs for review.
Oct 15 2024, 11:55
teamcity awarded D16902: Deprecate the ARM (32 bits) variant a Haypence token.
Oct 15 2024, 11:40
Fabien added a comment to D16902: Deprecate the ARM (32 bits) variant.

@bot guix-linux

Oct 15 2024, 11:40
teamcity closed T3658: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Resolved.
Oct 15 2024, 09:51
PiRK added inline comments to D16500: [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 07:55
Fabien requested changes to D16908: [seeder] Fix such that seeder node awaits both headers and addr messages.
Oct 15 2024, 07:50
PiRK closed D16899: [chronik] fix script compression.
Oct 15 2024, 07:47
PiRK committed rABC4c73e2329958: [chronik] fix script compression (authored by PiRK).
[chronik] fix script compression
Oct 15 2024, 07:47
Fabien requested changes to D16500: [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 07:45
Fabien requested changes to D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`.

I'm very happy to see this happen but there is no way to review such a change. You really need to split it into pieces, starting with running the ecash-lib integration tests properly on CI when there is a relevant change, which seems to not be the case here.
Then you can go through the list that is in the summary.

Oct 15 2024, 07:15
tobias_ruck updated the diff for D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`.

add rust-secp256k1 to the rust workspace

Oct 15 2024, 07:00
PiRK updated the diff for D16899: [chronik] fix script compression.

-,

Oct 15 2024, 06:49
PiRK published D16908: [seeder] Fix such that seeder node awaits both headers and addr messages for review.
Oct 15 2024, 05:09
PiRK retitled D16500: [seeder] Mark nodes as unreliable until checkpoint verified from Seeder: Mark nodes as unreliable until checkpoint verified to [seeder] Mark nodes as unreliable until checkpoint verified.
Oct 15 2024, 05:08
PiRK published D16500: [seeder] Mark nodes as unreliable until checkpoint verified for review.
Oct 15 2024, 05:08
PiRK closed D16499: [seeder] Make unreliable node reasons clear and consistent.
Oct 15 2024, 05:06
PiRK closed D16905: [seeder] Remove variable that is never read.
Oct 15 2024, 05:06
PiRK committed rABC2c02a0dcb3a9: [seeder] Make unreliable node reasons clear and consistent (authored by PiRK).
[seeder] Make unreliable node reasons clear and consistent
Oct 15 2024, 05:06
PiRK committed rABCa0f49bf60e9e: [seeder] Remove variable that is never read (authored by PiRK).
[seeder] Remove variable that is never read
Oct 15 2024, 05:06
PiRK closed D16904: [seeder] Get rid of pointless `wait` variable and params.
Oct 15 2024, 05:06
PiRK committed rABC06b9d443c921: [seeder] Get rid of pointless `wait` variable and params (authored by PiRK).
[seeder] Get rid of pointless `wait` variable and params
Oct 15 2024, 05:06

Oct 14 2024

tobias_ruck updated the summary of D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`.
Oct 14 2024, 22:43
tobias_ruck published D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm` for review.
Oct 14 2024, 22:38
teamcity awarded D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm` a Doubloon token.
Oct 14 2024, 22:37
johnkuney closed D16910: [explorer] Update css version.
Oct 14 2024, 21:40
johnkuney committed rABC7e378757246f: [explorer] Update css version (authored by johnkuney).
[explorer] Update css version
Oct 14 2024, 21:40
bytesofman accepted D16910: [explorer] Update css version.
Oct 14 2024, 21:39
johnkuney requested review of D16910: [explorer] Update css version.
Oct 14 2024, 21:36
bytesofman closed D16906: [ecash-herald] Stop handling block connected event.
Oct 14 2024, 21:15
bytesofman committed rABC29ca08179cc6: [ecash-herald] Stop handling block connected event (authored by bytesofman).
[ecash-herald] Stop handling block connected event
Oct 14 2024, 21:15
tobias_ruck accepted D16899: [chronik] fix script compression.
Oct 14 2024, 20:59
Fabien accepted D16906: [ecash-herald] Stop handling block connected event.
Oct 14 2024, 20:55
teamcity closed T3659: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Oct 14 2024, 20:54
Fabien accepted D16899: [chronik] fix script compression.
Oct 14 2024, 20:51
teamcity awarded D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm` a Piece of Eight token.
Oct 14 2024, 20:47
johnkuney closed D16909: [explorer] Testnet faucet success message styles.
Oct 14 2024, 20:41
johnkuney committed rABC2eb517becf36: [explorer] Testnet faucet success message styles (authored by johnkuney).
[explorer] Testnet faucet success message styles
Oct 14 2024, 20:41
teamcity added a comment to D16909: [explorer] Testnet faucet success message styles.

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41751 for the next 60 minutes.

Oct 14 2024, 20:40
teamcity awarded D16909: [explorer] Testnet faucet success message styles a Haypence token.
Oct 14 2024, 20:38
Fabien added a comment to D16909: [explorer] Testnet faucet success message styles.

@bot preview-explorer

Oct 14 2024, 20:38
Fabien accepted D16909: [explorer] Testnet faucet success message styles.
Oct 14 2024, 20:36
bytesofman updated the diff for D16906: [ecash-herald] Stop handling block connected event.

no need to cache blk_invalidated, remove '2*' factor for ttl

Oct 14 2024, 20:34
johnkuney requested review of D16909: [explorer] Testnet faucet success message styles.
Oct 14 2024, 20:33
Fabien requested changes to D16906: [ecash-herald] Stop handling block connected event.

For the next follow-up: you can remove the memoryCache entry for the block status as well as it's no longer needed

Oct 14 2024, 20:22
Fabien accepted D16905: [seeder] Remove variable that is never read.
Oct 14 2024, 19:33
Fabien accepted D16904: [seeder] Get rid of pointless `wait` variable and params.

There clearly was an attempt to make the thread sleep longer if there is no processing to do, but the implementation failed. In any case > 5s of delay should be enough to not create any meaningful load on the CPU even with hundreds of crawlers.

Oct 14 2024, 19:32
Fabien requested changes to D16896: [Cashtab] Support testnet with env variable.

The address handling seems incomplete but otherwise looks ok

Oct 14 2024, 19:22
teamcity triaged T3659: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Oct 14 2024, 19:17
Fabien accepted D16499: [seeder] Make unreliable node reasons clear and consistent.
Oct 14 2024, 19:14
teamcity awarded D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm` a Haypence token.
Oct 14 2024, 19:02
Fabien closed D16901: [doc] Add pytest to the required dependencies.
Oct 14 2024, 18:58
Fabien committed rABCd6d1d19a434e: [doc] Add pytest to the required dependencies (authored by Fabien).
[doc] Add pytest to the required dependencies
Oct 14 2024, 18:58
Fabien closed D16903: Bump version to 0.30.3.
Oct 14 2024, 18:58
Fabien committed rABC7af303ca3281: Bump version to 0.30.3 (authored by Fabien).
Bump version to 0.30.3
Oct 14 2024, 18:58
PiRK updated the diff for D16499: [seeder] Make unreliable node reasons clear and consistent.

rebase

Oct 14 2024, 18:49
PiRK accepted D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 18:47
bytesofman accepted D16903: Bump version to 0.30.3.
Oct 14 2024, 18:36
bytesofman accepted D16901: [doc] Add pytest to the required dependencies.
Oct 14 2024, 18:35
bytesofman published D16896: [Cashtab] Support testnet with env variable for review.
Oct 14 2024, 17:07
bytesofman published D16906: [ecash-herald] Stop handling block connected event for review.
Oct 14 2024, 16:23
teamcity updated the summary of D16905: [seeder] Remove variable that is never read.
Oct 14 2024, 15:30
PiRK requested review of D16905: [seeder] Remove variable that is never read.
Oct 14 2024, 15:29
teamcity updated the summary of D16904: [seeder] Get rid of pointless `wait` variable and params.
Oct 14 2024, 14:58
PiRK requested review of D16904: [seeder] Get rid of pointless `wait` variable and params.
Oct 14 2024, 14:58
teamcity triaged T3658: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Oct 14 2024, 14:06
Fabien updated the summary of D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 12:57
Fabien updated the diff for D16902: Deprecate the ARM (32 bits) variant.

Add a release note

Oct 14 2024, 12:57
Fabien requested review of D16903: Bump version to 0.30.3.
Oct 14 2024, 12:49
Fabien added a comment to D16902: Deprecate the ARM (32 bits) variant.

This will need a release note

Oct 14 2024, 10:25
Fabien requested review of D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 10:25
Fabien requested review of D16901: [doc] Add pytest to the required dependencies.
Oct 14 2024, 10:10
teamcity closed T3657: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Resolved.
Oct 14 2024, 09:32
PiRK committed rABC8e0aed83034d: add missing cstdint include in iguana_formatter.h (authored by PiRK).
add missing cstdint include in iguana_formatter.h
Oct 14 2024, 09:16
PiRK closed D16897: add missing cstdint include in iguana_formatter.h.
Oct 14 2024, 09:16

Oct 13 2024

teamcity closed T3656: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Resolved.
Oct 13 2024, 22:11
teamcity triaged T3657: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
Oct 13 2024, 22:05
teamcity triaged T3656: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.
Oct 13 2024, 21:42